refactor: improve maintainability

Seli0303 · Seli0303 · commit 851c404bb843 · 2024-06-18T17:41:39.000+02:00
diff --git a/src/fragments/forms/map-form/components/optimization/components/edit-dialog/edit-dialog.js b/src/fragments/forms/map-form/components/optimization/components/edit-dialog/edit-dialog.js
@@ -208,8 +208,8 @@ export default {
       for (const s of this.editSkills) {
         editSkillIds.push(s.id)
       }
-      let newSkillIdsSorted = newSkillIds.sort((a,b) => a-b)
-      for (const id of newSkillIdsSorted) {
+      newSkillIds.sort((a,b) => a-b)
+      for (const id of newSkillIds) {
         if (!editSkillIds.includes(id)) {
           this.editSkills.push(new Skill(' Skill from imported ' + this.content.item + ' ' + id, id))
         }

Original file line number	Diff line number	Diff line change
`@@ -208,8 +208,8 @@ export default {`
`208`	`208`	`for (const s of this.editSkills) {`
`209`	`209`	`editSkillIds.push(s.id)`
`210`	`210`	`}`
`211`		`- let newSkillIdsSorted = newSkillIds.sort((a,b) => a-b)`
`212`		`- for (const id of newSkillIdsSorted) {`
	`211`	`+ newSkillIds.sort((a,b) => a-b)`
	`212`	`+ for (const id of newSkillIds) {`
`213`	`213`	`if (!editSkillIds.includes(id)) {`
`214`	`214`	`this.editSkills.push(new Skill(' Skill from imported ' + this.content.item + ' ' + id, id))`
`215`	`215`	`}`