Fix: don't disable menu items for regular users

Author: garrettjstevens

packages/jbrowse-plugin-apollo/src/LinearApolloDisplay/glyphs/GeneGlyph.ts

@@ -842,7 +842,7 @@ function getContextMenuItems(
   const currentAssemblyId = display.getAssemblyId(region.assemblyName)
   const menuItems: MenuItem[] = []
   const role = internetAccount ? internetAccount.role : 'admin'
-  const admin = role === 'admin'
+  const readOnly = !(role && ['admin', 'user'].includes(role))
   if (!hoveredFeature) {
     return menuItems
   }
@@ -902,7 +902,7 @@ function getContextMenuItems(
         contextMenuItemsForFeature.push(
           {
             label: 'Merge exons',
-            disabled: !admin,
+            disabled: readOnly,
             onClick: () => {
               ;(session as unknown as AbstractSessionModel).queueDialog(
                 (doneCallback) => [
@@ -926,7 +926,7 @@ function getContextMenuItems(
           },
           {
             label: 'Split exon',
-            disabled: !admin,
+            disabled: readOnly,
             onClick: () => {
               ;(session as unknown as AbstractSessionModel).queueDialog(
                 (doneCallback) => [

packages/jbrowse-plugin-apollo/src/LinearApolloSixFrameDisplay/glyphs/GeneGlyph.ts

@@ -859,7 +859,7 @@ function getContextMenuItems(
   const currentAssemblyId = display.getAssemblyId(region.assemblyName)
   const menuItems: MenuItem[] = []
   const role = internetAccount ? internetAccount.role : 'admin'
-  const admin = role === 'admin'
+  const readOnly = !(role && ['admin', 'user'].includes(role))
   if (!hoveredFeature) {
     return menuItems
   }
@@ -928,7 +928,7 @@ function getContextMenuItems(
         contextMenuItemsForFeature.push(
           {
             label: 'Merge exons',
-            disabled: !admin,
+            disabled: readOnly,
             onClick: () => {
               ;(session as unknown as AbstractSessionModel).queueDialog(
                 (doneCallback) => [
@@ -952,7 +952,7 @@ function getContextMenuItems(
           },
           {
             label: 'Split exon',
-            disabled: !admin,
+            disabled: readOnly,
             onClick: () => {
               ;(session as unknown as AbstractSessionModel).queueDialog(
                 (doneCallback) => [

packages/jbrowse-plugin-apollo/src/TabularEditor/HybridGrid/featureContextMenuItems.ts

@@ -32,7 +32,6 @@ export function featureContextMenuItems(
 ) {
   const internetAccount = getApolloInternetAccount(session)
   const role = internetAccount ? internetAccount.role : 'admin'
-  const admin = role === 'admin'
   const readOnly = !(role && ['admin', 'user'].includes(role))
   const menuItems: MenuItem[] = []
   if (feature) {
@@ -102,7 +101,7 @@ export function featureContextMenuItems(
       },
       {
         label: 'Delete feature',
-        disabled: !admin,
+        disabled: readOnly,
         onClick: () => {
           ;(session as unknown as AbstractSessionModel).queueDialog(
             (doneCallback) => [
@@ -124,7 +123,7 @@ export function featureContextMenuItems(
       },
       {
         label: 'Merge transcripts',
-        disabled: !admin,
+        disabled: readOnly,
         onClick: () => {
           ;(session as unknown as AbstractSessionModel).queueDialog(
             (doneCallback) => [
@@ -146,7 +145,7 @@ export function featureContextMenuItems(
       },
       {
         label: 'Merge exons',
-        disabled: !admin,
+        disabled: readOnly,
         onClick: () => {
           ;(session as unknown as AbstractSessionModel).queueDialog(
             (doneCallback) => [
@@ -168,7 +167,7 @@ export function featureContextMenuItems(
       },
       {
         label: 'Split exon',
-        disabled: !admin,
+        disabled: readOnly,
         onClick: () => {
           ;(session as unknown as AbstractSessionModel).queueDialog(
             (doneCallback) => [

packages/jbrowse-plugin-apollo/src/util/glyphUtils.ts

@@ -288,7 +288,6 @@ export function getContextMenuItemsForFeature(
   } = display
   const menuItems: MenuItem[] = []
   const role = internetAccount ? internetAccount.role : 'admin'
-  const admin = role === 'admin'
   const readOnly = !(role && ['admin', 'user'].includes(role))
   const [region] = regions
   const sourceAssemblyId = display.getAssemblyId(region.assemblyName)
@@ -341,7 +340,7 @@ export function getContextMenuItemsForFeature(
     },
     {
       label: 'Delete feature',
-      disabled: !admin,
+      disabled: readOnly,
       onClick: () => {
         ;(session as unknown as AbstractSessionModel).queueDialog(
           (doneCallback) => [