-
-
Notifications
You must be signed in to change notification settings - Fork 3
[frontend-npm]: Bump react-window and @types/react-window in /smo-frontend #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[frontend-npm]: Bump react-window and @types/react-window in /smo-frontend #229
Conversation
| "@types/react": "^18.3.10", | ||
| "@types/react-dom": "^18.3.1", | ||
| "@types/react-window": "^1.8.8", | ||
| "@types/react-window": "^2.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Updating react-window to v2.0+ without migrating ListBoxComponent causes TypeError due to removed props and data property.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The ListBoxComponent.tsx uses properties like itemData, overscanCount, outerElementType, and innerElementType with FixedSizeList from react-window. These properties were removed in react-window v2.0. Additionally, the renderRow function expects a data property within ListChildComponentProps, which is no longer present in v2.0+. This will cause data to be undefined, leading to a TypeError when data[index] is accessed. This occurs when the search autocomplete attempts to render the list.
💡 Suggested Fix
Update ListBoxComponent.tsx to align with react-window v2.0+ API. This involves changing itemData={itemData} to rowProps={{ data: itemData }} and adjusting other removed props.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: smo-frontend/package.json#L49
Potential issue: The `ListBoxComponent.tsx` uses properties like `itemData`,
`overscanCount`, `outerElementType`, and `innerElementType` with `FixedSizeList` from
`react-window`. These properties were removed in `react-window` v2.0. Additionally, the
`renderRow` function expects a `data` property within `ListChildComponentProps`, which
is no longer present in v2.0+. This will cause `data` to be `undefined`, leading to a
`TypeError` when `data[index]` is accessed. This occurs when the search autocomplete
attempts to render the list.
Did we get this right? 👍 / 👎 to inform future reviews.
Bumps [react-window](https://github.com/bvaughn/react-window) and [@types/react-window](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-window). These dependencies needed to be updated together. Updates `react-window` from 1.8.11 to 2.2.2 - [Release notes](https://github.com/bvaughn/react-window/releases) - [Changelog](https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md) - [Commits](bvaughn/react-window@1.8.11...2.2.2) Updates `@types/react-window` from 1.8.8 to 2.0.0 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-window) --- updated-dependencies: - dependency-name: react-window dependency-version: 2.2.2 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: "@types/react-window" dependency-version: 2.0.0 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
2641daa to
351a127
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the react-window library from version 1.8.11 to 2.2.2, along with its corresponding TypeScript type definitions from @types/react-window 1.8.8 to 2.0.0.
- Major version upgrade of
react-windowfrom v1 to v2 - Updated type definitions to match the new major version
- Removed deprecated dependencies (
memoize-oneand@babel/runtime@^7.0.0)
Reviewed Changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| smo-frontend/package.json | Updated react-window and @types/react-window package versions |
| smo-frontend/yarn.lock | Updated lockfile entries for react-window, @types/react-window, and removed unused dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Bumps react-window and @types/react-window. These dependencies needed to be updated together.
Updates
react-windowfrom 1.8.11 to 2.2.2Release notes
Sourced from react-window's releases.
... (truncated)
Changelog
Sourced from react-window's changelog.
... (truncated)
Commits
a2bae7b2.2.1 - 2.2.25d59563Annotate Grid and List return types explicitly to avoid redundant inlined inf...b2fe9edUpdate README.md docs with component prop types (#873)2d844eaFormatting tweakse4c83fdImprove RowProps and CellProps generics docs03fd826Increased font size of code blocksa4eef4cTweaked <code> CSS color8028616Decreased intensity of warning blocks17e625cImprove component props docs (#871)f84477ePrettier config changesUpdates
@types/react-windowfrom 1.8.8 to 2.0.0Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)