Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 1, 2025

Bumps react-window and @types/react-window. These dependencies needed to be updated together.
Updates react-window from 1.8.11 to 2.2.2

Release notes

Sourced from react-window's releases.

2.2.1

  • Fix possible scroll-jump scenario with useDynamicRowHeight

2.2.0

  • Support for dynamic row heights via new useDynamicRowHeight hook.
const rowHeight = useDynamicRowHeight({
  defaultRowHeight: 50
});
return <List rowHeight={rowHeight} {...rest} />;

  • Smaller NPM bundle; (docs are no longer included as part of the bundle due to the added size)

Documentation at: https://react-window-9gegorjnr-brian-vaughns-projects.vercel.app/

2.1.2

Prevent ResizeObserver API from being called at all if an explicit List height (or Grid width and height) is provided.

Thanks to @​tnajdek for the PR!


Documentation at: https://react-window-8cygyvomv-brian-vaughns-projects.vercel.app/

2.1.1

Grids with only one row no longer incorrectly set cell height to 100%.


Documentation at: https://react-window-8cygyvomv-brian-vaughns-projects.vercel.app/

2.1.0

Improved ARIA support:

  • Add better default ARIA attributes for outer HTMLDivElement
  • Add optional ariaAttributes prop to row and cell renderers to simplify better ARIA attributes for user-rendered cells
  • Remove intermediate HTMLDivElement from List and Grid
    • This may enable more/better custom CSS styling
    • This may also enable adding an optional children prop to List and Grid for e.g. overlays/tooltips
  • Add optional tagName prop; defaults to "div" but can be changed to e.g. "ul"
// Example of how to use new `ariaAttributes` prop
function RowComponent({
  ariaAttributes,
</tr></table> 

... (truncated)

Changelog

Sourced from react-window's changelog.

2.2.2

The return type of List and Grid components is explicitly annotated as ReactElement. The return type of rowComponent and cellComponent changed from ReactNode to ReactElement. This was done to fix TypeScript warnings for React versions 18.0 - 18.2. (See issue #875)

2.2.1

  • Fix possible scroll-jump scenario with useDynamicRowHeight

2.2.0

  • Support for dynamic row heights via new useDynamicRowHeight hook.
const rowHeight = useDynamicRowHeight({
  defaultRowHeight: 50
});
return <List rowHeight={rowHeight} {...rest} />;

  • Smaller NPM bundle; (docs are no longer included as part of the bundle due to the added size)

2.1.2

Prevent ResizeObserver API from being called at all if an explicit List height (or Grid width and height) is provided.

2.1.1

Grids with only one row no longer incorrectly set cell height to 100%.

2.1.0

Improved ARIA support:

  • Add better default ARIA attributes for outer HTMLDivElement
  • Add optional ariaAttributes prop to row and cell renderers to simplify better ARIA attributes for user-rendered cells
  • Remove intermediate HTMLDivElement from List and Grid
    • This may enable more/better custom CSS styling
    • This may also enable adding an optional children prop to List and Grid for e.g. overlays/tooltips
  • Add optional tagName prop; defaults to "div" but can be changed to e.g. "ul"
// Example of how to use new `ariaAttributes` prop
function RowComponent({
  ariaAttributes,
  index,
  style,
  ...rest
}: RowComponentProps<object>) {
  return (
</tr></table> 

... (truncated)

Commits
  • a2bae7b 2.2.1 - 2.2.2
  • 5d59563 Annotate Grid and List return types explicitly to avoid redundant inlined inf...
  • b2fe9ed Update README.md docs with component prop types (#873)
  • 2d844ea Formatting tweaks
  • e4c83fd Improve RowProps and CellProps generics docs
  • 03fd826 Increased font size of code blocks
  • a4eef4c Tweaked <code> CSS color
  • 8028616 Decreased intensity of warning blocks
  • 17e625c Improve component props docs (#871)
  • f84477e Prettier config changes
  • Additional commits viewable in compare view

Updates @types/react-window from 1.8.8 to 2.0.0

Commits

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Nov 1, 2025
"@types/react": "^18.3.10",
"@types/react-dom": "^18.3.1",
"@types/react-window": "^1.8.8",
"@types/react-window": "^2.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Updating react-window to v2.0+ without migrating ListBoxComponent causes TypeError due to removed props and data property.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The ListBoxComponent.tsx uses properties like itemData, overscanCount, outerElementType, and innerElementType with FixedSizeList from react-window. These properties were removed in react-window v2.0. Additionally, the renderRow function expects a data property within ListChildComponentProps, which is no longer present in v2.0+. This will cause data to be undefined, leading to a TypeError when data[index] is accessed. This occurs when the search autocomplete attempts to render the list.

💡 Suggested Fix

Update ListBoxComponent.tsx to align with react-window v2.0+ API. This involves changing itemData={itemData} to rowProps={{ data: itemData }} and adjusting other removed props.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: smo-frontend/package.json#L49

Potential issue: The `ListBoxComponent.tsx` uses properties like `itemData`,
`overscanCount`, `outerElementType`, and `innerElementType` with `FixedSizeList` from
`react-window`. These properties were removed in `react-window` v2.0. Additionally, the
`renderRow` function expects a `data` property within `ListChildComponentProps`, which
is no longer present in v2.0+. This will cause `data` to be `undefined`, leading to a
`TypeError` when `data[index]` is accessed. This occurs when the search autocomplete
attempts to render the list.

Did we get this right? 👍 / 👎 to inform future reviews.

Bumps [react-window](https://github.com/bvaughn/react-window) and [@types/react-window](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-window). These dependencies needed to be updated together.

Updates `react-window` from 1.8.11 to 2.2.2
- [Release notes](https://github.com/bvaughn/react-window/releases)
- [Changelog](https://github.com/bvaughn/react-window/blob/master/CHANGELOG.md)
- [Commits](bvaughn/react-window@1.8.11...2.2.2)

Updates `@types/react-window` from 1.8.8 to 2.0.0
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-window)

---
updated-dependencies:
- dependency-name: react-window
  dependency-version: 2.2.2
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/react-window"
  dependency-version: 2.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/smo-frontend/multi-cbabd270ae branch from 2641daa to 351a127 Compare November 1, 2025 15:24
@GNimrodG GNimrodG requested a review from Copilot November 1, 2025 15:31
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the react-window library from version 1.8.11 to 2.2.2, along with its corresponding TypeScript type definitions from @types/react-window 1.8.8 to 2.0.0.

  • Major version upgrade of react-window from v1 to v2
  • Updated type definitions to match the new major version
  • Removed deprecated dependencies (memoize-one and @babel/runtime@^7.0.0)

Reviewed Changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
smo-frontend/package.json Updated react-window and @types/react-window package versions
smo-frontend/yarn.lock Updated lockfile entries for react-window, @types/react-window, and removed unused dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants