Skip to content

Commit 35ccc28

Browse files
committed
Merge remote-tracking branch 'amb26/GPII-1848'
* amb26/GPII-1848: GPII-1848: Updated to current GPII-1848 version of universal to acquire node-jqunit as nested dependency, tidied up unused grunt-shell dependency, removed unneeded material from vagrant provisioning script GPII-1852: Fix for (quietly reported) test failure in registryResolver GPII-1848: Removal of grunt-gpii and stale build files, update to grunt 1.x and ESLint linting, position universal as a standard npm dependency
2 parents b5ee46c + 9f5d627 commit 35ccc28

File tree

20 files changed

+161
-172
lines changed

20 files changed

+161
-172
lines changed

.eslintrc.json

Lines changed: 75 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,75 @@
1+
{
2+
"env": {
3+
"node": true
4+
},
5+
"rules": {
6+
"block-scoped-var": "error",
7+
"comma-style": [
8+
"error",
9+
"last"
10+
],
11+
"curly": [
12+
"error",
13+
"all"
14+
],
15+
"dot-notation": [
16+
"error",
17+
{
18+
"allowKeywords": false
19+
}
20+
],
21+
"eol-last": "error",
22+
"eqeqeq": [
23+
"error",
24+
"allow-null"
25+
],
26+
"indent": ["error", 4],
27+
"new-cap": ["error", { "properties": false }],
28+
"no-caller": "error",
29+
"no-cond-assign": [
30+
"error",
31+
"except-parens"
32+
],
33+
"no-debugger": "error",
34+
"no-empty": ["error", {"allowEmptyCatch": true}],
35+
"no-eval": "error",
36+
"no-extend-native": "error",
37+
"no-irregular-whitespace": "error",
38+
"no-iterator": "error",
39+
"no-loop-func": "error",
40+
"no-multi-str": "error",
41+
"no-new": "error",
42+
"no-proto": "error",
43+
"no-script-url": "error",
44+
"no-sequences": "error",
45+
"no-trailing-spaces": "error",
46+
"no-undef": "error",
47+
"no-unused-vars": "error",
48+
"no-with": "error",
49+
"quotes": [
50+
"error",
51+
"double"
52+
],
53+
"semi": [
54+
"error",
55+
"always"
56+
],
57+
"space-before-blocks": ["error", "always"],
58+
"space-before-function-paren": ["error", {"anonymous": "always", "named": "never"}],
59+
"space-infix-ops": "error",
60+
"space-unary-ops": [
61+
"error", {
62+
"words": true,
63+
"nonwords": false,
64+
"overrides": {
65+
"typeof": false
66+
}
67+
}],
68+
"strict": ["error", "safe"],
69+
"valid-typeof": "error",
70+
"wrap-iife": [
71+
"error",
72+
"inside"
73+
]
74+
}
75+
}

.jshintrc

Lines changed: 0 additions & 32 deletions
This file was deleted.

Gruntfile.js

Lines changed: 15 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,30 @@
1-
/*!
1+
/*
22
GPII Windows Personalization Framework Gruntfile
3+
Copyright 2013-2014 OCAD University
34
4-
Copyright 2014 RTF-US
5+
Licensed under the Educational Community License (ECL), Version 2.0 or the New
6+
BSD license. You may not use this file except in compliance with one these
7+
Licenses.
58
6-
Licensed under the New BSD license. You may not use this file except in
7-
compliance with this License.
8-
9-
You may obtain a copy of the License at
10-
https://github.com/gpii/universal/LICENSE.txt
9+
You may obtain a copy of the ECL 2.0 License and BSD License at
10+
https://github.com/fluid-project/infusion/raw/master/Infusion-LICENSE.txt
1111
*/
1212

1313
"use strict";
1414

1515
module.exports = function (grunt) {
16-
grunt.loadNpmTasks("grunt-contrib-jshint");
17-
grunt.loadNpmTasks("grunt-jsonlint");
18-
grunt.loadNpmTasks("grunt-shell");
19-
grunt.loadNpmTasks("grunt-gpii");
20-
21-
grunt.config.getRaw("gpiiGruntGlobal");
16+
2217
grunt.initConfig({
23-
jshint: {
24-
src: ["gpii/**/*.js", "tests/**/*.js", "index.js", "gpii.js"],
25-
buildScripts: ["Gruntfile.js"],
26-
options: {
27-
jshintrc: true
28-
}
18+
eslint: {
19+
src: ["./gpii/**/*.js", "./tests/**/*.js", "./*.js"]
2920
},
3021
jsonlint: {
31-
src: ["gpii/**/*.json", "tests/**/*.json"]
22+
src: ["gpii/**/*.json", "tests/**/*.json", "examples/**/*.json"]
3223
}
3324
});
3425

35-
grunt.registerTask("build", "Build the entire GPII", function () {
36-
grunt.task.run("gpii-universal");
37-
});
26+
grunt.loadNpmTasks("grunt-jsonlint");
27+
grunt.loadNpmTasks("fluid-grunt-eslint");
28+
29+
grunt.registerTask("lint", "Apply jshint and jsonlint", ["eslint", "jsonlint"]);
3830
};

README.md

Lines changed: 3 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -9,33 +9,15 @@ Windows 7 SP1 and Windows 8 SP2) unless the following hotfix from Microsoft is a
99

1010
See http://issues.gpii.net/browse/GPII-49 for more details of this issue.
1111

12-
# Grunt Builds
12+
# Building
1313

14-
We are in the process of adding support for building and running utility tasks
15-
with grunt.js. At some point these will replace the current build scripts.
14+
This package depends on the node 4.x LTS infrastructure - at the time of writing, node 4.4.1 and npm 2.1.14.
1615

17-
To use these, you must be running a recent version of npm, necessarily greater
18-
than 1.4. If you need to upgrade npm you can issue the following command:
19-
20-
npm install -g npm
21-
22-
To build the GPII for Windows using grunt, perform the following:
16+
To build the GPII for Windows, perform the following:
2317

2418
git clone https://github.com/GPII/windows.git
2519
cd windows
2620
npm install
27-
grunt build
28-
29-
Note that whenever you run the `npm install` task for this project, you must use the option appearing above.
30-
31-
# Old Builds
32-
33-
This project is still bundled with command-line build scripts (with the same effect as the above grunt builds) - support for these
34-
will be withdrawn soon. You can operate these as follows:
35-
36-
37-
* `build.cmd` will check out GPII's universal project https://github.com/GPII/universal in a subdirectory.
38-
* `start.cmd` will run the GPII personalisation system
3921

4022
# Test VM
4123

build.cmd

Lines changed: 0 additions & 20 deletions
This file was deleted.

clean.cmd

Lines changed: 0 additions & 3 deletions
This file was deleted.

gpii.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* https://github.com/GPII/universal/blob/master/LICENSE.txt
1515
*/
1616

17+
"use strict";
1718

1819
var fluid = require("universal"),
1920
gpii = fluid.registerNamespace("gpii");

gpii/node_modules/killProcess/killProcess.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gpii/node_modules/registryResolver/index.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gpii/node_modules/registryResolver/src/RegistryResolver.js

Lines changed: 45 additions & 48 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)