poweshell CI cleanups (#1437)

* switch actons powershell->pwsh

* cleanup ps1 scripts

Invoke-Formatter -ScriptDefinition (Get-Content -Path '.\ci_script_windows.ps1' -Raw)
Invoke-ScriptAnalyzer -Path .\ci_script_windows.ps1 [-Settings _]

* delete obsolete comment

Author: tsteven4

.github/workflows/windows.yml

@@ -106,7 +106,7 @@ jobs:
       run: choco install innosetup 
 
     - name: Build
-      shell: powershell
+      shell: pwsh
       run: |
         if ([string]::IsNullOrEmpty("${{  matrix.CROSS_COMPILER }}")) {
           .\tools\ci_setup_windows.ps1 -qtdir "$Home\Cache\Qt\${{ matrix.QT_VERSION }}\${{ matrix.COMPILER }}" -arch "${{ matrix.ARCH }}" -host_arch "${{ matrix.HOST_ARCH }}" -vcversion "${{ matrix.VCVERSION }}"
@@ -118,7 +118,7 @@ jobs:
           $hash["target_arch"] = "${{ matrix.TARGET_ARCH }}"
           $hash["compiler"] = "${{ matrix.COMPILER }}"
           $hash["cross_compiler"] = "${{ matrix.CROSS_COMPILER }}"
-          .\tools\ci_windows_cross_compile @hash
+          .\tools\ci_windows_cross_compile.ps1 @hash
         }
 
     - name: Rename
@@ -134,7 +134,6 @@ jobs:
       shell: bash
       if: matrix.CROSS_COMPILER == ''
       run: |
-        # PATH="${HOME}/Cache/Qt/${{ matrix.QT_VERSION }}/${{ matrix.COMPILER }}/bin:${PATH}"
         PNAME=./bld/gui/package/gpsbabel.exe GBTEMP=./gbtemp ./testo 2>&1
         PNAME=./bld/gui/package/gpsbabel.exe GBTEMP=./gbtemp ./test_encoding_utf8 2>&1
 
@@ -181,7 +180,7 @@ jobs:
         merge-multiple: true
 
     - name: 'Install Artifact'
-      shell: powershell
+      shell: pwsh
       run: |
         $install_path=Join-Path $(Get-Location) bld
         .\bld\GPSBabel-*-*-Setup-arm64.exe /SILENT /NORESTART /DIR="${install_path}" /LOG=bld\log.txt

tools/ci_script_windows.ps1

@@ -7,7 +7,7 @@
 # powershell.exe -ExecutionPolicy Unrestricted -File tools\make_windows_release.ps1
 #
 # The defaults should be compatible with github action builds.
-Param(
+param(
     $build_dir_name = "bld",
     $generator = "Ninja",
     $toolset = "",
@@ -40,15 +40,16 @@ New-Item $build_dir -type directory -Force | Out-Null
 Set-Location $build_dir
 $hashargs = "-G", $generator
 if ( $toolset ) {
-  $hashargs += "-T", $toolset
+    $hashargs += "-T", $toolset
 }
 if ( $generator -like "Visual Studio*") {
-  $hashargs += "-A", $platform
-} else {
-  $hashargs += "-DCMAKE_BUILD_TYPE:STRING=Release"
+    $hashargs += "-A", $platform
+}
+else {
+    $hashargs += "-DCMAKE_BUILD_TYPE:STRING=Release"
 }
 $hashargs += "-DCMAKE_PREFIX_PATH:PATH=$CMAKE_PREFIX_PATH"
-Write-Output cmake $hashargs $src_dir
+Write-Output "cmake $hashargs $src_dir"
 cmake $hashargs $src_dir
 if ($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode) }
 switch -wildcard ($generator) {
@@ -58,6 +59,6 @@ switch -wildcard ($generator) {
 if ($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode) }
 switch -wildcard ($generator) {
     "Visual Studio*" { cmake --build $build_dir --config Release --target package_app }
-    default { cmake --build $build_dir --target package_app}
+    default { cmake --build $build_dir --target package_app }
 }
 if ($LastExitCode -ne 0) { $host.SetShouldExit($LastExitCode) }

tools/ci_setup_windows.ps1

@@ -6,7 +6,7 @@
 # see https://github.com/actions/virtual-environments/issues/294
 # and https://github.com/microsoft/vswhere/wiki/Start-Developer-Command-Prompt
 
-Param(
+param(
     [string] $qtdir = "C:\Qt\6.5.3\msvc2019_64",
     [ValidateSet("x86", "amd64")][string] $arch = "amd64",
     [ValidateSet("x86", "amd64")][string] $host_arch = "amd64",

tools/ci_windows_cross_compile.ps1

@@ -1,4 +1,4 @@
-Param(
+param(
     $build_dir_name = "bld",
     $qt_root_dir = "C:/Qt/6.8.3",
     $host_arch = "amd64",