Merge pull request #1534 from tsteven4/redundant-member-init

minor tidy cleanups

Author: tsteven4

kalman.cc

@@ -342,7 +342,7 @@ void Kalman::process() {
             i++;
 
             if (current_original_wpt->wpt_flags.marked_for_deletion) {
-                auto extra_data = static_cast<KalmanExtraData*>(current_original_wpt->extra_data);
+                auto* extra_data = static_cast<KalmanExtraData*>(current_original_wpt->extra_data);
                 // FIXME: marked_for_deletion <==> is_zinger deletion.
                 // Interpolate to estimate missing data, or alternatively just
                 // let the kalman filter predict across the gap.

lowranceusr.cc

@@ -1743,7 +1743,7 @@ LowranceusrFormat::lowranceusr_merge_trail_hdr(const route_head* trk)
 void
 LowranceusrFormat::lowranceusr_merge_trail_tlr(const route_head* /*unused*/)
 {
-  if (trail_count == (int)track_count()) {  /* last trail */
+  if (trail_count == track_count()) {  /* last trail */
     short num_trail_points = trail_point_count;
     short max_trail_size = MAX_TRAIL_POINTS;
     if (num_trail_points > max_trail_size) {

mtk_logger.h

@@ -217,7 +217,7 @@ class MtkLoggerBase
 
   void* fd{};  /* serial fd */
   FILE* fl{};  /* bin.file fd */
-  QString port{}; /* serial port name */
+  QString port; /* serial port name */
   OptionBool OPT_erase;  /* erase ? command option */
   OptionBool OPT_erase_only;  /* erase_only ? command option */
   OptionBool OPT_log_enable;  /* enable ? command option */

src/core/nvector.h

@@ -83,7 +83,7 @@ class NVector : public Vector3D
   static LatLon crossTrackProjection(double latitude_a_degrees, double longitude_a_degrees, double latitude_b_degrees, double longitude_b_degrees, double latitude_x_degrees, double longitude_x_degrees);
   static double crossTrackDistance(const NVector& n_EA_E, const NVector& n_EB_E, const NVector& n_EX_E);
   static double crossTrackDistance(double latitude_a_degrees, double longitude_a_degrees, double latitude_b_degrees, double longitude_b_degrees, double latitude_x_degrees, double longitude_x_degrees);
-  static double euclideanDistance(const NVector& a, const NVector& b);
+  static double euclideanDistance(const NVector& n_EA_E, const NVector& n_EB_E);
 };
 
 class PVector : public Vector3D