Skip to content

Commit 558f3ea

Browse files
authored
[AMDGPU] Remove #if 0 code for indexed resources in SIInsertWaitcnts (llvm#92905)
I do not understand what optimization this was supposed to implement. It has never been enabled. I suspect it no longer applies to GCN/RDNA architectures.
1 parent 2117136 commit 558f3ea

File tree

1 file changed

+0
-11
lines changed

1 file changed

+0
-11
lines changed

llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2244,17 +2244,6 @@ bool SIInsertWaitcnts::insertWaitcntInBlock(MachineFunction &MF,
22442244

22452245
updateEventWaitcntAfter(Inst, &ScoreBrackets);
22462246

2247-
#if 0 // TODO: implement resource type check controlled by options with ub = LB.
2248-
// If this instruction generates a S_SETVSKIP because it is an
2249-
// indexed resource, and we are on Tahiti, then it will also force
2250-
// an S_WAITCNT vmcnt(0)
2251-
if (RequireCheckResourceType(Inst, context)) {
2252-
// Force the score to as if an S_WAITCNT vmcnt(0) is emitted.
2253-
ScoreBrackets->setScoreLB(LOAD_CNT,
2254-
ScoreBrackets->getScoreUB(LOAD_CNT));
2255-
}
2256-
#endif
2257-
22582247
if (ST->isPreciseMemoryEnabled() && Inst.mayLoadOrStore()) {
22592248
AMDGPU::Waitcnt Wait = WCG->getAllZeroWaitcnt(
22602249
Inst.mayStore() && !SIInstrInfo::isAtomicRet(Inst));

0 commit comments

Comments
 (0)