Skip to content

Commit e444453

Browse files
authored
Updated latest Core 3.1.4 (#658)
* Updated RadeonProRenderSDK. Adjusted build script. * Added backward compatibility for RPR Toon. * Review comments.
1 parent 2fb1622 commit e444453

File tree

7 files changed

+24
-4
lines changed

7 files changed

+24
-4
lines changed

src/bindings/pyrpr/src/pyrprapi.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -683,7 +683,10 @@ def get_rif_sdk(base=Path()):
683683
'rpr_format_ext',
684684
'RPR_CONTEXT_CREATE_IMAGE_FROM_EXTERNAL_HANDLE',
685685
'rprSetLogFunction',
686-
'RPR_GET_SUPPORTED_DEVICES_FUNC_NAME'
686+
'RPR_GET_SUPPORTED_DEVICES_FUNC_NAME',
687+
'rpr_debug_timings_mode',
688+
'RPR_CONTEXT_DEBUG_GET_CPU_TIMINGS',
689+
'RPR_CONTEXT_DEBUG_GET_GPU_TIMINGS'
687690
]
688691
)
689692

src/rprblender/engine/preview_engine.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ def sync(self, depsgraph):
134134
self.rpr_context.set_parameter(pyrpr.CONTEXT_PREVIEW, True)
135135
settings_scene.rpr.export_ray_depth(self.rpr_context)
136136
settings_scene.rpr.export_pixel_filter(self.rpr_context)
137+
settings_scene.rpr.export_compatibility_settings(self.rpr_context)
137138
self.rpr_context.texture_compression = settings_scene.rpr.texture_compression
138139

139140
self.render_samples = settings_scene.rpr.viewport_limits.preview_samples

src/rprblender/engine/render_engine.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -771,6 +771,7 @@ def sync(self, depsgraph):
771771
self.rpr_context.set_parameter(pyrpr.CONTEXT_PREVIEW, False)
772772
scene.rpr.export_ray_depth(self.rpr_context)
773773
scene.rpr.export_pixel_filter(self.rpr_context)
774+
scene.rpr.export_compatibility_settings(self.rpr_context)
774775
self.rpr_context.texture_compression = scene.rpr.texture_compression
775776

776777
self.render_samples, self.render_time = (scene.rpr.limits.max_samples, scene.rpr.limits.seconds)

src/rprblender/engine/viewport_engine.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,7 @@ def sync(self, context, depsgraph):
529529
scene.rpr.export_viewport_ray_depth(self.rpr_context)
530530
self.rpr_context.texture_compression = scene.rpr.texture_compression
531531
scene.rpr.export_pixel_filter(self.rpr_context)
532+
scene.rpr.export_compatibility_settings(self.rpr_context)
532533

533534
self.render_iterations, self.render_time = (viewport_limits.max_samples, 0)
534535

@@ -1109,6 +1110,7 @@ def update_render(self, scene: bpy.types.Scene, view_layer: bpy.types.ViewLayer)
11091110
restart = scene.rpr.export_render_mode(self.rpr_context)
11101111
restart |= scene.rpr.export_viewport_ray_depth(self.rpr_context)
11111112
restart |= scene.rpr.export_pixel_filter(self.rpr_context)
1113+
restart |= scene.rpr.export_compatibility_settings(self.rpr_context)
11121114

11131115
render_iterations, render_time = (scene.rpr.viewport_limits.max_samples, 0)
11141116

src/rprblender/properties/render.py

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -582,6 +582,12 @@ def update_viewport_render_preset(self, context):
582582
update=update_viewport_render_preset
583583
)
584584

585+
legacy_toon_shader: BoolProperty(
586+
name="Use Legacy RPR Toon",
587+
description="Enable backward compatibility of RPR Toon shader appearance",
588+
default=False,
589+
)
590+
585591
hybrid_low_mem: BoolProperty(
586592
name="Use 4GB memory",
587593
description="Enable to support GPUs with 4Gb VRAM or less for Final render mode",
@@ -801,6 +807,13 @@ def export_viewport_render_quality(self, rpr_context):
801807
quality = getattr(pyrpr, 'RENDER_QUALITY_' + self.viewport_render_mode)
802808
return rpr_context.set_parameter(pyrpr.CONTEXT_RENDER_QUALITY, quality)
803809

810+
def export_compatibility_settings(self, rpr_context):
811+
""" Exports backward compatibility settings """
812+
if self.final_render_mode != 'FULL2':
813+
return False
814+
815+
return rpr_context.set_parameter(pyrpr.CONTEXT_NORMALIZE_LIGHT_INTENSITY_ENABLED, not self.legacy_toon_shader)
816+
804817
@classmethod
805818
def register(cls):
806819
log("Register")

src/rprblender/ui/render.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -239,8 +239,8 @@ def draw(self, context):
239239
row.prop(limits, 'seed')
240240
row.prop(limits, 'anim_seed', text="", icon='TIME')
241241

242-
row = col.row()
243-
row.prop(rpr, 'texture_compression')
242+
col.prop(rpr, 'texture_compression')
243+
col.prop(rpr, 'legacy_toon_shader')
244244

245245

246246
class RPR_RENDER_PT_settings(RPR_Panel):

0 commit comments

Comments
 (0)