Skip to content

Commit ff39614

Browse files
committed
Clearing up some TODOs
1 parent 81d8dc0 commit ff39614

File tree

4 files changed

+3
-7
lines changed

4 files changed

+3
-7
lines changed

RadeonRays/src/accelerator/bvh2.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,7 @@ namespace RadeonRays
199199
std::size_t num_items = 0;
200200
for (auto iter = begin; iter != end; ++iter)
201201
{
202-
// TODO: how to deal with quads? create 2 trianles?? (gboisse)
202+
// Quads are deprecated and no longer supported
203203
assert(static_cast<const Mesh *>(*iter)->puretriangle());
204204
num_items += static_cast<const Mesh *>(*iter)->num_faces();
205205
}

RadeonRays/src/intersector/intersector_lds.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ namespace RadeonRays
113113
}
114114
else
115115
{
116-
// TODO: implement (gboisse)
116+
// TODO: implement vulkan kernels (gboisse)
117117
assert(device->GetPlatform() == Calc::Platform::kVulkan);
118118
m_gpuData->bvh_prog.executable = m_device->CompileExecutable("../RadeonRays/src/kernels/GLSL/bvh2.comp", nullptr, 0, buildopts.c_str());
119119
m_gpuData->qbvh_prog.executable = m_device->CompileExecutable("../RadeonRays/src/kernels/GLSL/bvh2_fp16.comp", nullptr, 0, buildopts.c_str());
@@ -129,7 +129,7 @@ namespace RadeonRays
129129
#if USE_VULKAN
130130
if (device->GetPlatform() == Calc::Platform::kVulkan)
131131
{
132-
// TODO: implement (gboisse)
132+
// TODO: implement vulkan kernels (gboisse)
133133
if (m_gpudata->bvh_prog.executable == nullptr)
134134
m_gpuData->executable = m_device->CompileExecutable(g_bvh2_vulkan, std::strlen(g_bvh2_vulkan), buildopts.c_str());
135135
if (m_gpuData->qbvh_prog.executable == nullptr)

RadeonRays/src/kernels/CL/intersect_bvh2_lds.cl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ TYPE DEFINITIONS
3939
// BVH node
4040
typedef struct
4141
{
42-
// TODO: add explanatory comment (gboisse)
43-
4442
float4 aabb_left_min_or_v0_and_addr_left;
4543
float4 aabb_left_max_or_v1_and_mesh_id;
4644
float4 aabb_right_min_or_v2_and_addr_right;

RadeonRays/src/kernels/CL/intersect_bvh2_lds_fp16.cl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ TYPE DEFINITIONS
4141
// BVH node
4242
typedef struct
4343
{
44-
// TODO: add explanatory comment (gboisse)
45-
4644
uint4 aabb01_min_or_v0_and_addr0;
4745
uint4 aabb01_max_or_v1_and_addr1_or_mesh_id;
4846
uint4 aabb23_min_or_v2_and_addr2_or_prim_id;

0 commit comments

Comments
 (0)