Add some warnings from clang-tidy to ignore list

[IAmNotHanni]

Hello

I think some warnings from clang-tidy can be added to the ignore list, since in my opinion they are either not that helpful or out of the scope of the project.
If you have any to add, let me know.

best regards
Johannes

[IAmNotHanni]

Here is a list of warnigns I personally would ignore:

• altera-unroll-loops ("kernel performance could be improved by unrolling this loop" I don't think this is necessary)
• misc-definitions-in-headers (I think definitions in header file are fine for this project)
• cppcoreguidelines-pro-bounds-pointer-arithmetic (I think this project just relies on pointer arithmetics)
• readability-function-cognitive-complexity (Some functions are just long)

Mentioned in #482:

• llvmlibc-restrict-system-libc-headers
• modernize-use-nodiscard
• cppcoreguidelines-pro-type-union-access

[IAmNotHanni]

@adam-sawicki-a I just saw your comment on #482
I enabled all warnings by default, and now you can pick which ones you want to ignore. (I don't know all warnings myself)

[adam-sawicki-a]

OK, your list looks good to me. If you add those I mentioned in that comment #482 (comment), that will be great.

[IAmNotHanni]

About the analysis of CMakeCXXCompilerId.cpp: I need to check how to configure clang-tidy more correctly so it only analyzes the files of VMA. I'm looking into this.

[adam-sawicki-a]

Maybe there is a way to tell clang-tidy the version of C++ we are targeting (C++14)?

[IAmNotHanni]

Maybe there is a way to tell clang-tidy the version of C++ we are targeting (C++14)?

Just for my understanding: Does VMA really not use any C++17 feature?
Because if it's really C++14 only, there is this:

VulkanMemoryAllocator/src/CMakeLists.txt

Line 37 in fc2cea5

set(CMAKE_CXX_STANDARD 17)

[IAmNotHanni]

I also think llvmlibc-implementation-in-namespace makes not much sense.

[IAmNotHanni]

Hmm clang-tidy seems to have ignored these changes: 8a739e4
I think the arguments must be in one line.

Anyways I will look into how to use a .clang.tidy configuration file (like this here) instead. This will allow us to configure everything more easily (both warnings we want to ignore and files we want to ignore) instead of putting it all into the command line of the GitHub workflow.

I still don't know why I can't run the CI in my fork (maybe this is forbidden in GitHub?).
Otherwise I could test the CI easily before making a pull request.

EDIT: Ah ok, only project owners can run the CI of a fork: https://medium.com/@alexey.inkin/you-should-enable-ci-on-your-forks-manually-7ee152238394 I think we should wait for CI results of the pr before merging a pr then.

[IAmNotHanni]

I think I will close this. We can add further warnings to ignore list as needed.