style: update clang-format to v20

ACP-21694

Author: pbanyai

.github/workflows/format.yaml

@@ -8,8 +8,8 @@ jobs:
 
     steps:
     - uses: actions/checkout@v2
-    - uses: DoozyX/clang-format-lint-action@v0.13
+    - uses: DoozyX/clang-format-lint-action@v0.20
       with:
         source: 'p4-fusion tests'
         extensions: 'h,cc'
-        clangFormatVersion: 12.0.1
+        clangFormatVersion: 20

p4-fusion/commands/change_list.cc

@@ -56,8 +56,7 @@ void ChangeList::PrepareDownload(const BranchSet& branchSet)
 
 		    std::unique_lock<std::mutex> lock(*cl.stateMutex);
 		    cl.state = Described;
-		    cl.stateCV->notify_all();
-	    });
+		    cl.stateCV->notify_all(); });
 }
 
 void ChangeList::StartDownloadAndLFSUpload(int nPrintBatch)
@@ -108,8 +107,7 @@ void ChangeList::StartDownloadAndLFSUpload(int nPrintBatch)
 
 		    // Download any remaining files that were smaller in number than the total batch size.
 		    // Additionally, signal the batch processing end.
-		    cl.DownloadBatch(printBatchFiles, printBatchFileData);
-	    });
+		    cl.DownloadBatch(printBatchFiles, printBatchFileData); });
 }
 
 void ChangeList::DownloadBatch(std::shared_ptr<std::vector<std::string>> printBatchFiles, std::shared_ptr<std::vector<FileData*>> printBatchFileData)
@@ -160,8 +158,7 @@ void ChangeList::DownloadBatch(std::shared_ptr<std::vector<std::string>> printBa
 		    {
 			    state = CommitReady;
 			    stateCV->notify_all();
-		    }
-	    });
+		    } });
 }
 
 void ChangeList::WaitForBeingCommitReady()

p4-fusion/lfs/communication/lfscomm.cc

@@ -30,8 +30,7 @@ const char* GetUserAgent()
 		    if (version_info && version_info->version)
 		    {
 			    result = std::string("curl/") + version_info->version;
-		    }
-	    });
+		    } });
 
 	return result.c_str();
 }
@@ -200,8 +199,7 @@ RequestResult PerformPostRequestWithRetry(CURL* curl,
 			    curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &result.response_code);
 		    }
 
-		    return result;
-	    });
+		    return result; });
 }
 
 // Helper function to perform a PUT request with binary data
@@ -224,8 +222,7 @@ RequestResult PerformPutRequestWithRetry(CURL* curl, const std::string& url,
 			    curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &result.response_code);
 		    }
 
-		    return result;
-	    });
+		    return result; });
 }
 
 struct BatchResponse
@@ -407,8 +404,7 @@ Communicator::UploadResult PerformUpload(const std::string& uploadUrl, const std
 		    {
 			    curl_easy_getinfo(curl.get(), CURLINFO_RESPONSE_CODE, &uploadResult.response_code);
 		    }
-		    return uploadResult;
-	    });
+		    return uploadResult; });
 
 	curl_slist_free_all(uploadHeaders);
 
@@ -466,8 +462,7 @@ bool PerformVerify(const std::string& verifyUrl, const std::string& oid, size_t
 		    {
 			    curl_easy_getinfo(curl.get(), CURLINFO_RESPONSE_CODE, &verifyResult.response_code);
 		    }
-		    return verifyResult;
-	    });
+		    return verifyResult; });
 
 	curl_slist_free_all(verifyHeaders);
 

p4-fusion/lfs/communication/s3comm.cc

@@ -37,7 +37,7 @@ Communicator::UploadResult S3Comm::UploadFile(const std::vector<char>& fileConte
 
 	std::string objectKey = m_Repository + "/" + oid;
 
-	//Check if object already exists
+	// Check if object already exists
 	Aws::S3::Model::HeadObjectRequest headRequest;
 	headRequest.SetBucket(m_Bucket);
 	headRequest.SetKey(objectKey);

p4-fusion/p4_api.cc

@@ -205,7 +205,8 @@ ChangesResult P4API::Changes(const std::string& path, const std::string& from, i
 {
 	std::vector<std::string> args = {
 		"-l", // Get full descriptions instead of sending cut-short ones
-		"-s", "submitted", // Only include submitted CLs
+		"-s",
+		"submitted", // Only include submitted CLs
 	};
 
 	// This needs to be declared outside the if scope below to

p4-fusion/thread_pool.cc

@@ -134,8 +134,7 @@ void ThreadPool::Initialize(int size, LFSClient* lfsClient)
 					    m_ThreadExceptions[i] = std::current_exception();
 				    }
 				    m_JobsProcessing--;
-			    }
-		    }));
+			    } }));
 	}
 }