Merge pull request #2923 from GSA/main

09/19/2025 Production Deploy

Author: ccostino

.ds.baseline

@@ -527,23 +527,23 @@
         "filename": "tests/app/main/views/test_register.py",
         "hashed_secret": "bdbb156d25d02fd7792865824201dda1c60f4473",
         "is_verified": false,
-        "line_number": 115,
+        "line_number": 111,
         "is_secret": false
       },
       {
         "type": "Secret Keyword",
         "filename": "tests/app/main/views/test_register.py",
         "hashed_secret": "5baa61e4c9b93f3f0682250b6cf8331b7ee68fd8",
         "is_verified": false,
-        "line_number": 185,
+        "line_number": 172,
         "is_secret": false
       },
       {
         "type": "Secret Keyword",
         "filename": "tests/app/main/views/test_register.py",
         "hashed_secret": "bb5b7caa27d005d38039e3797c3ddb9bcd22c3c8",
         "is_verified": false,
-        "line_number": 256,
+        "line_number": 243,
         "is_secret": false
       }
     ],
@@ -634,5 +634,5 @@
       }
     ]
   },
-  "generated_at": "2025-08-21T16:06:57Z"
+  "generated_at": "2025-09-17T19:16:00Z"
 }

.github/actions/setup-project/action.yml

@@ -9,10 +9,10 @@ runs:
         sudo apt-get update \
         && sudo apt-get install -y --no-install-recommends \
         libcurl4-openssl-dev
-    - name: Set up Python 3.12.9
+    - name: Set up Python 3.13.2
       uses: actions/setup-python@v4
       with:
-        python-version: "3.12.9"
+        python-version: "3.13.2"
     - name: Install poetry
       shell: bash
       run: pip install poetry==2.1.3

README.md

@@ -189,12 +189,12 @@ session to make the changes take effect.
 Now we're ready to install the Python version we need with `pyenv`, like so:
 
 ```sh
-pyenv install 3.12
+pyenv install 3.13
 ```
 
-This will install the latest version of Python 3.12.
+This will install the latest version of Python 3.13.
 
-_NOTE: This project currently runs on Python 3.12.x._
+_NOTE: This project currently runs on Python 3.13.x._
 
 #### [API Step] Python Dependency Installation
 
@@ -246,12 +246,12 @@ git clone git@github.com:GSA/notifications-admin.git
 
 Now go into the project directory (`notifications-admin` by default), create a
 virtual environment, and set the local Python version to point to the virtual
-environment (assumes version Python `3.12.9` is what is installed on your
+environment (assumes version Python `3.13.2` is what is installed on your
 machine):
 
 ```sh
 cd notifications-admin
-pyenv virtualenv 3.12.9 notify-admin
+pyenv virtualenv 3.13.2 notify-admin
 pyenv local notify-admin
 ```
 
@@ -284,10 +284,10 @@ If you're upgrading an existing project to a newer version of Python, you can
 follow these steps to get yourself up-to-date.
 
 First, use `pyenv` to install the newer version of Python you'd like to use;
-we'll use `3.12` in our example here since we recently upgraded to this version:
+we'll use `3.13` in our example here since we recently upgraded to this version:
 
 ```sh
-pyenv install 3.12
+pyenv install 3.13
 ```
 
 Next, delete the virtual environment you previously had set up. If you followed
@@ -302,7 +302,7 @@ environment with the newer version of Python you just installed:
 
 ```sh
 cd notifications-admin
-pyenv virtualenv 3.12.9 notify-admin
+pyenv virtualenv 3.13.2 notify-admin
 pyenv local notify-admin
 ```
 

app/__init__.py

@@ -191,7 +191,7 @@ def add_security_headers(response):
     @application.context_processor
     def inject_feature_flags():
         # this is where feature flags can be easily added as a dictionary within context
-        feature_socket_enabled = application.config.get("FEATURE_SOCKET_ENABLED", False)
+        feature_socket_enabled = application.config.get("FEATURE_SOCKET_ENABLED", True)
         return dict(
             FEATURE_SOCKET_ENABLED=feature_socket_enabled,
         )

app/assets/javascripts/activityChart.js

@@ -5,6 +5,9 @@
         const tableContainer = document.getElementById('activityContainer');
         const currentUserName = tableContainer.getAttribute('data-currentUserName');
         const currentServiceId = tableContainer.getAttribute('data-currentServiceId');
+        let pollInterval;
+        let isPolling = false;
+        const POLL_INTERVAL_MS = 25000;
         const COLORS = {
             delivered: '#0076d6',
             failed: '#fa9441',
@@ -153,8 +156,6 @@
             .on('mouseout', function() {
                 tooltip.style('display', 'none');
             })
-            .transition()
-            .duration(1000)
             .attr('y', d => y(d[1]))
             .attr('height', d => {
                 const calculatedHeight = y(d[0]) - y(d[1]);
@@ -209,28 +210,35 @@
         table.append(tbody);
     };
 
-    const fetchData = function(type) {
+    const fetchData = async function(type) {
+        if (isPolling) {
+            return;
+        }
+
+        if (document.hidden) {
+            return;
+        }
 
         var ctx = document.getElementById('weeklyChart');
         if (!ctx) {
             return;
         }
 
+        isPolling = true;
+
         var userTimezone = Intl.DateTimeFormat().resolvedOptions().timeZone;
 
         var url = type === 'service'
             ? `/services/${currentServiceId}/daily-stats.json?timezone=${encodeURIComponent(userTimezone)}`
             : `/services/${currentServiceId}/daily-stats-by-user.json?timezone=${encodeURIComponent(userTimezone)}`;
 
+        try {
+            const response = await fetch(url);
+            if (!response.ok) {
+                throw new Error('Network response was not ok');
+            }
 
-        return fetch(url)
-            .then(response => {
-                if (!response.ok) {
-                    throw new Error('Network response was not ok');
-                }
-                return response.json();
-            })
-            .then(data => {
+            const data = await response.json();
                 labels = [];
                 deliveredData = [];
                 failedData = [];
@@ -277,10 +285,41 @@
                     }
 
                     return data;
-                })
-                .catch(error => console.error('Error fetching daily stats:', error));
-        };
-        setInterval(() => fetchData(currentType), 25000);
+        } catch (error) {
+            console.error('Error fetching daily stats:', error);
+        } finally {
+            isPolling = false;
+        }
+    };
+
+    function startPolling() {
+        fetchData(currentType);
+
+        pollInterval = setInterval(() => {
+            fetchData(currentType);
+        }, POLL_INTERVAL_MS);
+    }
+
+    function stopPolling() {
+        if (pollInterval) {
+            clearInterval(pollInterval);
+            pollInterval = null;
+        }
+    }
+
+    document.addEventListener('visibilitychange', () => {
+        if (document.hidden) {
+            stopPolling();
+        } else {
+            stopPolling();
+            startPolling();
+        }
+    });
+
+    if (typeof jest === 'undefined') {
+        startPolling();
+    }
+
     const handleDropdownChange = function(event) {
         const selectedValue = event.target.value;
         currentType = selectedValue;

app/assets/javascripts/collapsibleCheckboxes.js

@@ -118,7 +118,8 @@
   CollapsibleCheckboxes.prototype.addHeadingHideLegend = function() {
     const headingLevel = this.$component.data('heading-level') || '2';
 
-    this.$heading = $(`<h${headingLevel} class="heading-small">${this.legendText}</h${headingLevel}>`);
+    this.$heading = $(`<h${headingLevel} class="heading-small"></h${headingLevel}>`);
+    this.$heading.text(this.legendText);
     this.$fieldset.before(this.$heading);
 
     this.$fieldset.find('legend').addClass('usa-sr-only');

app/assets/javascripts/modules/all.mjs

@@ -14,7 +14,6 @@ import Button from 'govuk-frontend/components/button/button';
 import Radios from 'govuk-frontend/components/radios/radios';
 
 // Modules from 3rd party vendors
-import morphdom from 'morphdom';
 
 /**
  * TODO: Ideally this would be a NodeList.prototype.forEach polyfill
@@ -67,13 +66,8 @@ var Frontend = {
   "initAll": initAll
 }
 
-var vendor = {
-  "morphdom": morphdom
-}
-
 // The exported object will be assigned to window.GOVUK in our production code
 // (bundled into an IIFE by RollupJS)
 export {
-  Frontend,
-  vendor
+  Frontend
 }

app/assets/javascripts/radioSlider.js

@@ -14,8 +14,8 @@
           if (valuesInLabel.length === 2) {
             leftValue = valuesInLabel[0];
             rightValue = valuesInLabel[1];
-            $(this).find('.radio-slider-left-value').html(leftValue);
-            $(this).find('.radio-slider-right-value').html(rightValue);
+            $(this).find('.radio-slider-left-value').text(leftValue);
+            $(this).find('.radio-slider-right-value').text(rightValue);
           }
 
         })