[SRCH-6115] remove access to features that we plan to discontinue. (#1863)

luisgmetzger · luismetzger · web-flow · commit ee8b2de204e3 · 2025-09-18T12:32:59.000-06:00
* [SRCH-6115] In customer admin center, remove access to features that we plan to discontinue.

---------

Co-authored-by: Luis Metzger &lt;luismetzger@me.com&gt;
diff --git a/app/helpers/navigations_helper.rb b/app/helpers/navigations_helper.rb
@@ -13,10 +13,6 @@ def link_to_navigable_facet_type(nav)
     case nav.navigable_facet_type
     when 'DocumentCollection'
       link_to('Collection', edit_site_collection_path(nav.navigable.affiliate, nav.navigable))
-    when 'YouTube'
-      link_to('YouTube', site_youtube_channels_path(nav.navigable.owner))
-    when 'RSS'
-      link_to('RSS', edit_site_rss_feed_path(nav.navigable.owner, nav.navigable))
     when 'ImageSearchLabel'
       build_image_search_navigable_label nav.navigable
     end
diff --git a/app/helpers/sites_helper.rb b/app/helpers/sites_helper.rb
@@ -126,7 +126,7 @@ def site_analytics_controllers
   def site_manage_content_controllers
     %w[boosted_contents boosted_contents_bulk_uploads
        contents document_collections routed_queries excluded_urls
-       flickr_profiles indexed_documents rss_feeds
+       flickr_profiles indexed_documents
        site_domains site_feed_urls i14y_drawers
        youtube_profiles featured_collections]
   end
diff --git a/app/views/admin/home/index.html.haml b/app/views/admin/home/index.html.haml
@@ -4,7 +4,6 @@
 %ul
   %li=link_to("Users", admin_users_path)
   %li=link_to("Sites", admin_affiliates_path)
-  %li=link_to('Rss Feeds', admin_rss_feeds_path)
   %li=link_to('Rss Feed Urls', admin_rss_feed_urls_path)
   %li=link_to("System Alerts", admin_system_alerts_path)
   %li=link_to("Excluded Domains", admin_excluded_domains_path)
diff --git a/app/views/sites/contents/show.html.haml b/app/views/sites/contents/show.html.haml
@@ -27,18 +27,6 @@
   %li.content-item.routed-queries
     = link_to site_routed_queries_path(@site) do
       %span.no-icon Routed Queries
-  %li.content-item.rss
-    = link_to site_rss_feeds_path(@site) do
-      = image_tag 'sites/rss_logo.png', alt: 'YouTube logo', style: 'text-align: center'
-      %div.name RSS
-  %li.content-item.youtube
-    = link_to site_youtube_channels_path(@site) do
-      = image_tag 'sites/youtube_logo.png', alt: 'YouTube logo'
-      %div.name YouTube
-  %li.content-item.flickr
-    = link_to site_flickr_urls_path(@site) do
-      = image_tag 'sites/flickr_logo.png', alt: 'Flickr logo'
-      %div.name Flickr
 
 = form_tag site_autodiscovery_path(@site), id: 'autodiscovery'
 = label_tag :autodiscovery_url, 'Discover and add the RSS feeds and social media accounts listed on the following page:'
diff --git a/app/views/sites/embed_codes/show.html.haml b/app/views/sites/embed_codes/show.html.haml
@@ -9,7 +9,4 @@
 = find_and_preserve do
   = render 'form_embed_code_text_area'
 
-%h3 Type-ahead search and Search.gov Tag Snippet
-= find_and_preserve do
-  = render 'bottom_page_embed_code_text_area'
 
diff --git a/app/views/sites/excluded_urls/index.html.haml b/app/views/sites/excluded_urls/index.html.haml
@@ -4,7 +4,6 @@
   .action-bar
     %ul
       = list_item_with_link_to_current_help_page
-      = render 'sites/shared/domains_advanced_options'
       %li= link_to 'Add Filter URL', new_site_filter_url_path(@site)
 
 = render_flash_message
diff --git a/app/views/sites/indexed_documents/index.html.haml b/app/views/sites/indexed_documents/index.html.haml
@@ -4,7 +4,6 @@
   .action-bar
     %ul
       = list_item_with_link_to_current_help_page
-      = render 'sites/shared/domains_advanced_options'
       %li= link_to 'Add Supplemental URL', new_site_supplemental_url_path(@site)
 
 = render_flash_message
diff --git a/app/views/sites/shared/_domains_advanced_options.html.haml b/app/views/sites/shared/_domains_advanced_options.html.haml
diff --git a/app/views/sites/shared/_manage_content_sub_nav.html.haml b/app/views/sites/shared/_manage_content_sub_nav.html.haml
@@ -8,6 +8,3 @@
   %li{ site_nav_css_class_hash(*%w(boosted_contents boosted_contents_bulk_uploads)) }= link_to 'Best Bets: Text', site_best_bets_texts_path(@site)
   %li{ site_nav_css_class_hash('featured_collections') }= link_to 'Best Bets: Graphics', site_best_bets_graphics_path(@site)
   %li{ site_nav_css_class_hash('routed_queries') }= link_to 'Routed Queries', site_routed_queries_path(@site)
-  %li{ site_nav_css_class_hash('rss_feeds') }= link_to 'RSS', site_rss_feeds_path(@site)
-  %li{ site_nav_css_class_hash('youtube_profiles') }= link_to 'YouTube', site_youtube_channels_path(@site)
-  %li{ site_nav_css_class_hash('flickr_profiles') }= link_to 'Flickr', site_flickr_urls_path(@site)
diff --git a/app/views/sites/site_domains/index.html.haml b/app/views/sites/site_domains/index.html.haml
@@ -4,7 +4,6 @@
   .action-bar
     %ul
       = list_item_with_link_to_current_help_page
-      = render 'sites/shared/domains_advanced_options'
       %li= link_to 'Add Domain', new_site_domain_path(@site)
 
 = render_flash_message
diff --git a/app/views/sites/site_feed_urls/edit.html.haml b/app/views/sites/site_feed_urls/edit.html.haml
@@ -5,7 +5,6 @@
     .action-bar
       %ul
         = list_item_with_link_to_current_help_page
-        = render 'sites/shared/domains_advanced_options'
         %li= f.submit 'Save', class: 'btn submit disabled', disabled: true
 
   = render_flash_message
diff --git a/app/views/sites/tag_filters/index.html.haml b/app/views/sites/tag_filters/index.html.haml
@@ -4,7 +4,6 @@
   .action-bar
     %ul
       = list_item_with_link_to_current_help_page
-      = render 'sites/shared/domains_advanced_options'
       %li= link_to 'Add Filter Tag', new_site_tag_filter_path(@site)
 
 = render_flash_message
diff --git a/app/views/sites/third_party_tracking_requests/new.html.haml b/app/views/sites/third_party_tracking_requests/new.html.haml
@@ -23,3 +23,8 @@
         %p The tracking code you submitted will be reviewed shortly. You can submit an updated version below to overwrite it.
 
   = text_area_tag :submitted_external_tracking_code, nil, required: true, class: 'required input-primary', placeholder: "Please insert your web analytics JavaScript code here.", id: 'external_tracking_code'
+
+  %dl
+    %dd
+      %p When developing your third party tracking code, make sure to encode special characters such as question marks.
+      %p After submitting a third party tracking request, email search@gsa.gov to let the team know about the change.
diff --git a/features/admin.feature b/features/admin.feature
@@ -111,10 +111,6 @@ Feature:  Administration
     And I follow "Users"
     And I should see the following breadcrumbs: Super Admin > Users
 
-    When I go to the admin home page
-    And I follow "Rss Feeds"
-    Then I should see "An Agency Feed"
-
     When I go to the admin home page
     And I follow "Rss Feed Urls"
     And I should see the following breadcrumbs: Super Admin > Rss Feed Urls
diff --git a/features/admin_center_activate_search.feature b/features/admin_center_activate_search.feature
@@ -7,7 +7,6 @@ Feature: Activate Search
     And I am logged in with email "aff@bar.gov"
     When I go to the aff.gov's Activate Search page
     Then I should see "Form Snippet"
-    And I should see "Type-ahead search and Search.gov Tag Snippet"
     And I should see the code for English language sites
 
   Scenario: Getting an embed code for my affiliate site search in Spanish
diff --git a/features/admin_center_manage_content.feature b/features/admin_center_manage_content.feature
@@ -481,128 +481,6 @@ Feature: Manage Content
     And I submit the form by pressing "Add"
     Then I should see "Tag has already been taken"
 
-  Scenario: View Flickr URLs
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    When the following flickr URLs exist for the site "agency.gov":
-      | url                                      |
-      | http://www.flickr.com/photos/whitehouse/ |
-      | http://www.flickr.com/groups/usagov/     |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Manage Content page
-    And I follow "Flickr" within the Admin Center content
-    Then I should see the following table rows:
-      | www.flickr.com/groups/usagov/     |
-      | www.flickr.com/photos/whitehouse/ |
-
-  Scenario: Add/remove Flickr URL
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Manage Content page
-    And I follow "Flickr" within the Admin Center content
-    And I follow "Add Flickr URL"
-    When I fill in "Flickr URL" with "www.flickr.com/groups/usagov/"
-    And I submit the form by pressing "Add"
-    Then I should see "You have added www.flickr.com/groups/usagov/ to this site"
-    When I press "Remove" and confirm "Are you sure you wish to remove https://www.flickr.com/groups/usagov/ from this site?"
-    Then I should see "You have removed www.flickr.com/groups/usagov/ from this site"
-
-  Scenario: View RSS
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And affiliate "agency.gov" has the following RSS feeds:
-      | name   | url                                                     | last_crawl_status | last_crawled_at | show_only_media_content | is_managed |
-      | News   | search.gov/all.atom                                     | OK                | 2013-01-01      |                         |            |
-      | Videos | gdata.youtube.com/feeds/base/videos?author=usgovernment | Pending           | Pending         |                         | true       |
-      | Images | www.flickr.com/photos_public.gne?id=27784370@N05        | 404 Not Found     | 2013-07-01      | true                    |            |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Manage Content page
-    And I follow "RSS" within the Admin Center content
-    Then I should see the following table rows:
-      | Images (Media RSS) |
-      | News               |
-      | Videos (YouTube)   |
-    And I should find "Images" in the first table body error row
-    And I should find "News" in the first table body success row
-    And I should find "Videos" in the first table body warning row
-
-    When I follow "Images"
-    Then I should find "www.flickr.com/photos_public.gne?id=27784370@N05" in the RSS URLs modal
-
-    When I go to the agency.gov's "Images" RSS feed page
-    And I follow "Error"
-    Then I should find "404 Not Found" in the RSS URL last crawl status error message
-
-  Scenario: Add/edit/remove RSS Feed
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And I am logged in with email "john@agency.gov"
-    And www.fda.gov has valid RSS feeds
-    When I go to the agency.gov's Manage Content page
-    And I follow "RSS" within the Admin Center content
-    And I follow "Add RSS Feed"
-    When I fill in the following:
-      | Name  | Recalls                                                                                |
-      | URL 1 | https://www.fda.gov/rss/health-fraud/rss.xml |
-    And I choose "RSS"
-    And I add the following RSS Feed URLs:
-      | url                                                                                      |
-      | https://www.fda.gov/rss/food-allergies/rss.xml |
-    And I submit the form by pressing "Add"
-    Then I should see "You have added Recalls to this site"
-    When I follow "Edit"
-    Then the "Name" field should contain "Recalls"
-    And the "URL 1" field should contain "https://www.fda.gov/rss/food-allergies/rss.xml"
-    And the "URL 2" field should contain "https://www.fda.gov/rss/health-fraud/rss.xml"
-    When I fill in "Name" with "Food, Safety and Pet Health Recalls"
-    And I add the following RSS Feed URLs:
-      | url                                                                                           |
-      | https://www.fda.gov/rss/food-safety-recalls/rss.xml |
-    And I submit the form by pressing "Save"
-    Then I should see "You have updated Food, Safety and Pet Health Recalls"
-    When I press "Remove" and confirm "Are you sure you wish to remove Food, Safety and Pet Health Recalls from this site?"
-    Then I should see "You have removed Food, Safety and Pet Health Recalls from this site"
-
-  Scenario: Edit/remove Supplemental Feed
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Supplemental URLs page
-    And I access the "Advanced" dropdown menu
-    And I follow "Supplemental Feed"
-    When I fill in the following:
-      | URL | search.gov/all.atom |
-    And I submit the form by pressing "Save"
-    Then I should see "You have updated your supplemental feed for this site"
-    And the "URL" field should contain "http://search.gov/all.atom"
-    And I should see "Last Crawled Pending"
-    And I should see "Status Pending"
-    When I press "Remove" and confirm "Are you sure you wish to remove your supplemental feed?"
-    Then I should see "You have removed your supplemental feed from this site"
-
-  Scenario: View Supplemental URLs
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And the following IndexedDocuments exist:
-      | url                                             | title                | description                     | affiliate  | last_crawled_at | last_crawl_status | source |
-      | http://aff.gov/extremelysuperlongurl/space-suit | Space Suit Evolution | description text for space suit | agency.gov | 11/02/2011      | OK                | manual |
-      | http://aff.gov/extremelysuperlongurl/rocket     | Rocket Evolution     | description text for rocket     | agency.gov | 11/01/2011      | 404 Not Found     | rss    |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Supplemental URLs page
-    Then I should see the following table rows:
-      | URL                                      | Source | Last Crawled | Status |
-      | aff.gov/extremelysuperlongurl/rocket     | Feed   | 11/1/2011    | Error  |
-      | aff.gov/extremelysuperlongurl/space-suit | Manual | 11/2/2011    | OK     |
-    When I follow "Error"
-    Then I should find "404 Not Found" in the Supplemental URL last crawl status error message
-
   Scenario: Filtering Supplemental URLs
     Given the following BingV7 Affiliates exist:
       | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
@@ -623,74 +501,4 @@ Feature: Manage Content
     And I press "Search"
     Then I should see "No Supplemental URLs found matching 'lksdjflskdjf'"
     When I follow "Reset"
-    Then I should be on the agency.gov's Supplemental URLs page
-
-  Scenario: Add/edit/remove Supplemental URL
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Supplemental URLs page
-    And I follow "Add Supplemental URL"
-    And I fill in the following:
-      | URL         | search.gov/developer/jobs.html                      |
-      | Title       | Jobs API                                            |
-      | Description | Helping job seekers land a job with the government. |
-    And I submit the form by pressing "Add"
-    Then I should see "You have added search.gov/developer/jobs.html to this site"
-    And I should see the following table rows:
-      | URL                            | Source |
-      | search.gov/developer/jobs.html | Manual |
-    And I should see the following table rows:
-      | Status     |
-      | Summarized |
-    When I press "Remove" and confirm "Are you sure you wish to remove search.gov/developer/jobs.html from this site?"
-    Then I should see "You have removed search.gov/developer/jobs.html from this site"
-
-  Scenario: View YouTube Channels
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And the following YouTube channels exist for the site "agency.gov":
-      | title        | channel_id              |
-      | USGovernment | usgovernment_channel_id |
-      | GobiernoUSA  | gobiernousa_channel_id  |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Manage Content page
-    And I follow "YouTube" within the Admin Center content
-    Then I should see the following table rows:
-      | GobiernoUSA  |
-      | USGovernment |
-
-  Scenario: Add/remove YouTube Channel
-    Given the following BingV7 Affiliates exist:
-      | display_name | name       | contact_email   | first_name | last_name | use_redesigned_results_page |
-      | agency site  | agency.gov | john@agency.gov | John       | Bar       | false                       |
-    And I am logged in with email "john@agency.gov"
-    When I go to the agency.gov's Manage Content page
-    And I follow "YouTube" within the Admin Center content
-    And I follow "Add YouTube Channel"
-    When I fill in "YouTube Channel URL" with " youtube.com/USGovernment "
-    And I submit the form by pressing "Add"
-    Then I should see "You have added usgovernment channel to this site"
-    And I should see a link to "usgovernment" with url for "https://www.youtube.com/channel/UCWjkPmmzCdPZEKtGciLf1mg"
-
-    When I follow "Display"
-    Then the "Is video govbox enabled" should be switched on
-
-    When I follow "Content" within the Admin Center main navigation list
-    And I follow "RSS" within the Admin Center content
-    And I follow "Videos"
-    Then I should see "www.youtube.com/channel/UCWjkPmmzCdPZEKtGciLf1mg"
-
-    When I go to the agency.gov's Manage Content page
-    And I follow "YouTube" within the Admin Center content
-    And I press "Remove" and confirm "Are you sure you wish to remove usgovernment channel from this site?"
-    Then I should see "You have removed usgovernment channel from this site"
-    When I follow "Add YouTube Channel"
-    When I fill in "YouTube Channel URL" with "http://www.youtube.com/usasearch"
-    And I submit the form by pressing "Add"
-    Then I should see "Url is not found"
-
-    When I follow "Display"
-    Then I should not see "Videos"
+    Then I should be on the agency.gov's Supplemental URLs page
diff --git a/features/admin_center_manage_display.feature b/features/admin_center_manage_display.feature
diff --git a/spec/lib/js_fetcher_spec.rb b/spec/lib/js_fetcher_spec.rb
diff --git a/spec/lib/url_status_code_fetcher_spec.rb b/spec/lib/url_status_code_fetcher_spec.rb
diff --git a/spec/vcr_cassettes/js_fetcher.yml b/spec/vcr_cassettes/js_fetcher.yml
