Skip to content

SRCH-5556 Setup package.json to use node v20.10.0 #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenbarragan wants to merge 11 commits into
base: main
Choose a base branch
from
Open

SRCH-5556 Setup package.json to use node v20.10.0 #1684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
eecd2e8
Setup package.json to use node v20.10.0
stevenbarragan Oct 1, 2024
13f1849
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Oct 2, 2024
c85635a
Update node version in dockerfiles
stevenbarragan Oct 2, 2024
3c3027f
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Oct 2, 2024
acf4c63
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Oct 2, 2024
0a92f57
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Oct 15, 2024
2b34be1
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Oct 21, 2024
7cc0e58
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Nov 12, 2024
188a6c0
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Dec 20, 2024
3933611
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Jan 21, 2025
d47e402
Merge branch 'main' into SRCH-5556-node-20
stevenbarragan Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ commands:
name: Clean node_modules
command: rm -rf node_modules
- nodejs/install:
node-version: '16'
node-version: '20.10.0'
install-yarn: true
- run:
name: Yarn Install
Expand Down Expand Up @@ -373,7 +373,7 @@ workflows:
mysql_version:
- "8.0"
node_version:
- 16.20.2
- 20.10.0

- report_coverage:
requires:
Expand All @@ -391,4 +391,4 @@ workflows:
mysql_version:
- "8.0"
node_version:
- 16.20.2
- 20.10.0
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ ENV RAILS_ENV="production" \
BUNDLE_WITHOUT="development"

# Install JavaScript dependencies | Needed in base due coffee-rails gem
ARG NODE_VERSION=16.20.2
ARG NODE_VERSION=20.10.0
ARG YARN_VERSION=latest
ENV PATH=/usr/local/node/bin:$PATH
RUN curl -sL https://github.com/nodenv/node-build/archive/master.tar.gz | tar xz -C /tmp/ && \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.dev
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ RUN apt-get update -y && apt-get install -y --no-install-recommends \
# Workaround for PhantomJS: https://github.com/DMOJ/online-judge/pull/1270
ENV OPENSSL_CONF /etc/ssl/

ENV NODE_VERSION 16.20.2
ENV NODE_VERSION 20.10.0
ENV NVM_DIR=/root/.nvm

COPY package.json yarn.lock ./
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
]
},
"engines": {
"node": ">=16.0.0"
"node": ">=20.10.0"
},
"browserslist": [
"defaults"
Expand Down