1784: ensure core_result.filter is in sync with website.filter

Author: akuny

libs/database/src/core-results/core-result.service.spec.ts

@@ -282,10 +282,13 @@ describe('CoreResultService', () => {
       websiteUrl,
     );
     expect(mockRepository.insert).toHaveBeenCalled();
-    expect(mockWebsiteService.setFiltered).not.toHaveBeenCalled();
+    expect(mockWebsiteService.setFilter).not.toHaveBeenCalled();
+    expect(mockRepository.insert).toHaveBeenCalledWith(
+      expect.objectContaining({ filter: false }),
+    );
   });
 
-  it('should call setFiltered when finalUrlMIMEType is a filtered type', async () => {
+  it('should call setFilter when finalUrlMIMEType is a filtered type', async () => {
     const websiteId = 1;
     const scanStatus: ScanStatus = ScanStatus['Completed'];
     const websiteUrl = 'https://example.gov';
@@ -471,9 +474,9 @@ describe('CoreResultService', () => {
     );
 
     expect(mockRepository.insert).toHaveBeenCalled();
-    expect(mockWebsiteService.setFiltered).toHaveBeenCalledWith(
-      websiteId,
-      true,
+    expect(mockWebsiteService.setFilter).toHaveBeenCalledWith(websiteId, true);
+    expect(mockRepository.insert).toHaveBeenCalledWith(
+      expect.objectContaining({ filter: true }),
     );
   });
 });

libs/database/src/core-results/core-result.service.ts

@@ -57,17 +57,18 @@ export class CoreResultService {
       },
     });
 
-    if (exists) {
-      await this.coreResultRepository.update(exists.id, coreResult);
-    } else {
-      await this.coreResultRepository.insert(coreResult);
-    }
-
     if (
       coreResult.finalUrlMIMEType &&
       CoreResult.filteredMediaTypes.includes(coreResult.finalUrlMIMEType)
     ) {
-      await this.websiteService.setFiltered(websiteId, true);
+      coreResult.filter = true;
+      await this.websiteService.setFilter(websiteId, true);
+    }
+
+    if (exists) {
+      await this.coreResultRepository.update(exists.id, coreResult);
+    } else {
+      await this.coreResultRepository.insert(coreResult);
     }
   }
 

libs/database/src/websites/websites.service.ts

@@ -257,7 +257,7 @@ export class WebsiteService {
       .execute();
   }
 
-  async setFiltered(id: number, filtered: boolean): Promise<void> {
-    await this.website.update(id, { filter: filtered });
+  async setFilter(id: number, filter: boolean): Promise<void> {
+    await this.website.update(id, { filter });
   }
 }