Stricter Optical/Laser cable connections (GregTechCEu#2103)

Author: serenibyss

src/main/java/gregtech/api/pipenet/tile/IPipeTile.java

@@ -36,6 +36,8 @@ default long getTickTimer() {
 
     int getConnections();
 
+    int getNumConnections();
+
     boolean isConnected(EnumFacing side);
 
     void setConnection(EnumFacing side, boolean connected, boolean fromNeighbor);

src/main/java/gregtech/api/pipenet/tile/TileEntityPipeBase.java

@@ -143,6 +143,17 @@ public int getConnections() {
         return connections;
     }
 
+    @Override
+    public int getNumConnections() {
+        int count = 0;
+        int connections = getConnections();
+        while (connections > 0) {
+            count++;
+            connections = connections & (connections - 1);
+        }
+        return count;
+    }
+
     @Override
     public int getBlockedConnections() {
         return canHaveBlockedFaces() ? blockedConnections : 0;

src/main/java/gregtech/common/pipelike/laser/tile/TileEntityLaserPipe.java

@@ -13,6 +13,7 @@
 import gregtech.common.pipelike.laser.net.WorldLaserPipeNet;
 import net.minecraft.nbt.NBTTagCompound;
 import net.minecraft.network.PacketBuffer;
+import net.minecraft.tileentity.TileEntity;
 import net.minecraft.util.EnumFacing;
 import net.minecraftforge.common.capabilities.Capability;
 import net.minecraftforge.common.util.Constants;
@@ -116,6 +117,27 @@ public void transferDataFrom(IPipeTile<LaserPipeType, LaserPipeProperties> tileE
         }
     }
 
+    @Override
+    public void setConnection(EnumFacing side, boolean connected, boolean fromNeighbor) {
+        if (!getWorld().isRemote && connected && !fromNeighbor) {
+            int connections = getConnections();
+            // block connection if any side other than the requested side and its opposite side are already connected.
+            connections &= ~(1 << side.getIndex());
+            connections &= ~(1 << side.getOpposite().getIndex());
+            if (connections != 0) return;
+
+            // check the same for the targeted pipe
+            TileEntity tile = getWorld().getTileEntity(getPos().offset(side));
+            if (tile instanceof IPipeTile<?,?> pipeTile && pipeTile.getPipeType().getClass() == this.getPipeType().getClass()) {
+                connections = pipeTile.getConnections();
+                connections &= ~(1 << side.getIndex());
+                connections &= ~(1 << side.getOpposite().getIndex());
+                if (connections != 0) return;
+            }
+        }
+        super.setConnection(side, connected, fromNeighbor);
+    }
+
     public boolean isActive() {
         return this.isActive;
     }

src/main/java/gregtech/common/pipelike/optical/tile/TileEntityOpticalPipe.java

@@ -14,6 +14,7 @@
 import gregtech.common.pipelike.optical.net.OpticalPipeNet;
 import gregtech.common.pipelike.optical.net.WorldOpticalPipeNet;
 import net.minecraft.network.PacketBuffer;
+import net.minecraft.tileentity.TileEntity;
 import net.minecraft.util.EnumFacing;
 import net.minecraftforge.common.capabilities.Capability;
 
@@ -125,6 +126,21 @@ public void transferDataFrom(IPipeTile<OpticalPipeType, OpticalPipeProperties> t
         }
     }
 
+    @Override
+    public void setConnection(EnumFacing side, boolean connected, boolean fromNeighbor) {
+        if (!getWorld().isRemote && connected && !fromNeighbor) {
+            // never allow more than two connections total
+            if (getNumConnections() >= 2) return;
+
+            // also check the other pipe
+            TileEntity tile = getWorld().getTileEntity(getPos().offset(side));
+            if (tile instanceof IPipeTile<?,?> pipeTile && pipeTile.getPipeType().getClass() == this.getPipeType().getClass()) {
+                if (pipeTile.getNumConnections() >= 2) return;
+            }
+        }
+        super.setConnection(side, connected, fromNeighbor);
+    }
+
     public boolean isActive() {
         return this.isActive;
     }