Yet another Crafting station fix PR (GregTechCEu#1255)

* cache the tested itemstacks

* cull some recipe matches() call.
really helps with shapeless recipes

* formatting

* special handling for our transfer energy recipes

Author: PrototypeTrousers

src/main/java/gregtech/common/metatileentities/storage/CachedRecipeData.java

@@ -2,11 +2,15 @@
 
 import gregtech.api.recipes.KeySharedStack;
 import gregtech.api.util.ItemStackKey;
+import gregtech.api.util.ShapedOreEnergyTransferRecipe;
 import gregtech.common.inventory.IItemList;
 import gregtech.common.inventory.itemsource.ItemSources;
+import it.unimi.dsi.fastutil.ints.Int2ObjectArrayMap;
+import it.unimi.dsi.fastutil.objects.Object2BooleanOpenHashMap;
 import net.minecraft.inventory.InventoryCrafting;
 import net.minecraft.item.ItemStack;
 import net.minecraft.item.crafting.IRecipe;
+import net.minecraft.item.crafting.Ingredient;
 import net.minecraft.world.World;
 
 import java.util.HashMap;
@@ -17,6 +21,7 @@ public class CachedRecipeData {
     private final ItemSources itemSources;
     private IRecipe recipe;
     private final Map<ItemStackKey, Integer> requiredItems = new HashMap<>();
+    private final Map<Integer, Map<ItemStackKey, Boolean>> replaceAttemptMap = new Int2ObjectArrayMap<>();
     private final InventoryCrafting inventory;
 
     public CachedRecipeData(ItemSources sourceList, IRecipe recipe, InventoryCrafting inventoryCrafting) {
@@ -74,17 +79,48 @@ public boolean getIngredientEquivalent(int slot) {
             return true;
         }
 
+        ItemStack previousStack = recipe.getCraftingResult(inventory);
+
+        Map<ItemStackKey, Boolean> map = replaceAttemptMap.computeIfAbsent(slot, (m) -> new Object2BooleanOpenHashMap<>());
+
         //iterate stored items to find equivalent
         for (ItemStackKey itemStackKey : itemSources.getStoredItems()) {
+            if (map.containsKey(itemStackKey)) {
+                if (!map.get(itemStackKey)) {
+                    continue;
+                } else {
+                    return true;
+                }
+            }
+
             ItemStack itemStack = itemStackKey.getItemStack();
+
+            boolean matched = false;
+            //Matching shapeless recipes actually is very bad for performance, as it checks the entire
+            //recipe ingredients recursively, so we fail early here if none of the recipes ingredients can
+            //take the stack
+            for (Ingredient in : recipe.getIngredients()) {
+                if (in.apply(itemStack)) {
+                    matched = true;
+                    break;
+                }
+            }
+            if (!matched) {
+                map.put(itemStackKey, false);
+                continue;
+            }
+
             //update item in slot, and check that recipe matches and output item is equal to the expected one
             inventory.setInventorySlotContents(slot, itemStack);
-            if (recipe.matches(inventory, itemSources.getWorld())) {
+            if (recipe.matches(inventory, itemSources.getWorld()) &&
+                    (ItemStack.areItemStacksEqual(recipe.getCraftingResult(inventory), previousStack) || recipe instanceof ShapedOreEnergyTransferRecipe)) {
+                map.put(itemStackKey, true);
                 //ingredient matched, attempt to extract it and return if successful
                 if (simulateExtractItem(itemStackKey)) {
                     return true;
                 }
             }
+            map.put(itemStackKey, false);
             inventory.setInventorySlotContents(slot, currentStack);
         }
         //nothing matched, so return null
@@ -110,6 +146,7 @@ public boolean matches(InventoryCrafting inventoryCrafting, World world) {
 
     public void setRecipe(IRecipe newRecipe) {
         this.recipe = newRecipe;
+        this.replaceAttemptMap.clear();
     }
 
     public IRecipe getRecipe() {