Cyclebutton rework (CleanroomMC#70)

* texture rework

* "minor" changes
- abstract cycle & toggle button
- helper method for drawable arrays
- add widget property for widget theme override
- and some minor things

* minor stuff

(cherry picked from commit f26323b)

Author: brachy84

src/main/java/com/cleanroommc/modularui/api/ITheme.java

@@ -4,7 +4,7 @@
 import com.cleanroommc.modularui.theme.WidgetSlotTheme;
 import com.cleanroommc.modularui.theme.WidgetTextFieldTheme;
 import com.cleanroommc.modularui.theme.WidgetTheme;
-import com.cleanroommc.modularui.theme.WidgetToggleButtonTheme;
+import com.cleanroommc.modularui.theme.WidgetThemeSelectable;
 
 /**
  * A theme is parsed from json and contains style information like color or background texture.
@@ -48,10 +48,18 @@ static ITheme get(String id) {
 
     WidgetTextFieldTheme getTextFieldTheme();
 
-    WidgetToggleButtonTheme getToggleButtonTheme();
+    WidgetThemeSelectable getToggleButtonTheme();
 
     WidgetTheme getWidgetTheme(String id);
 
+    default <T extends WidgetTheme> T getWidgetTheme(Class<T> clazz, String id) {
+        WidgetTheme theme = getWidgetTheme(id);
+        if (clazz.isInstance(theme)) {
+            return (T) theme;
+        }
+        return null;
+    }
+
     int getOpenCloseAnimationOverride();
 
     boolean getSmoothProgressBarOverride();

src/main/java/com/cleanroommc/modularui/api/IThemeApi.java

@@ -44,6 +44,12 @@ static IThemeApi get() {
      */
     boolean hasTheme(String id);
 
+    /**
+     * @param id id of the widget theme
+     * @return if a widget theme with the id is registered
+     */
+    boolean hasWidgetTheme(String id);
+
     /**
      * Registers a theme json object. Themes from resource packs always have greater priority.
      *

src/main/java/com/cleanroommc/modularui/api/drawable/IDrawable.java

@@ -19,6 +19,16 @@
  */
 public interface IDrawable {
 
+    static IDrawable of(IDrawable... drawables) {
+        if (drawables == null || drawables.length == 0) {
+            return null;
+        } else if (drawables.length == 1) {
+            return drawables[0];
+        } else {
+            return new DrawableArray(drawables);
+        }
+    }
+
     /**
      * Draws this drawable at the given position with the given size.
      *

src/main/java/com/cleanroommc/modularui/api/value/IBoolValue.java

@@ -1,8 +1,18 @@
 package com.cleanroommc.modularui.api.value;
 
-public interface IBoolValue<T> extends IValue<T> {
+public interface IBoolValue<T> extends IValue<T>, IIntValue<T> {
 
     boolean getBoolValue();
 
     void setBoolValue(boolean val);
+
+    @Override
+    default int getIntValue() {
+        return getBoolValue() ? 1 : 0;
+    }
+
+    @Override
+    default void setIntValue(int val) {
+        setBoolValue(val == 1);
+    }
 }

src/main/java/com/cleanroommc/modularui/api/value/sync/IBoolSyncValue.java

@@ -7,7 +7,7 @@
  *
  * @param <T> value type
  */
-public interface IBoolSyncValue<T> extends IValueSyncHandler<T>, IBoolValue<T> {
+public interface IBoolSyncValue<T> extends IValueSyncHandler<T>, IBoolValue<T>, IIntSyncValue<T> {
 
     @Override
     default void setBoolValue(boolean val) {
@@ -19,4 +19,19 @@ default void setBoolValue(boolean val, boolean setSource) {
     }
 
     void setBoolValue(boolean value, boolean setSource, boolean sync);
+
+    @Override
+    default void setIntValue(int value, boolean setSource, boolean sync) {
+        setBoolValue(value == 1, setSource, sync);
+    }
+
+    @Override
+    default int getIntValue() {
+        return IBoolValue.super.getIntValue();
+    }
+
+    @Override
+    default void setIntValue(int val) {
+        IBoolValue.super.setIntValue(val);
+    }
 }

src/main/java/com/cleanroommc/modularui/api/widget/ITooltip.java

@@ -51,18 +51,40 @@ default W getThis() {
      * @return this
      */
     default W tooltip(Consumer<Tooltip> tooltipConsumer) {
+        return tooltipStatic(tooltipConsumer);
+    }
+
+    /**
+     * Helper method to call tooltip setters within a widget tree initialisation.
+     * Only called once.
+     *
+     * @param tooltipConsumer tooltip function
+     * @return this
+     */
+    default W tooltipStatic(Consumer<Tooltip> tooltipConsumer) {
         tooltipConsumer.accept(tooltip());
         return getThis();
     }
 
     /**
      * Sets a tooltip builder. The builder will be called every time the tooltip is marked dirty.
-     * Should be used for dynamic tooltips
+     * Should be used for dynamic tooltips.
      *
      * @param tooltipBuilder tooltip function
      * @return this
      */
     default W tooltipBuilder(Consumer<Tooltip> tooltipBuilder) {
+        return tooltipDynamic(tooltipBuilder);
+    }
+
+    /**
+     * Sets a tooltip builder. The builder will be called every time the tooltip is marked dirty.
+     * Should be used for dynamic tooltips.
+     *
+     * @param tooltipBuilder tooltip function
+     * @return this
+     */
+    default W tooltipDynamic(Consumer<Tooltip> tooltipBuilder) {
         tooltip().tooltipBuilder(tooltipBuilder);
         return getThis();
     }

src/main/java/com/cleanroommc/modularui/drawable/AdaptableUITexture.java

@@ -25,7 +25,7 @@ public class AdaptableUITexture extends UITexture {
 
     @Override
     public AdaptableUITexture getSubArea(float uStart, float vStart, float uEnd, float vEnd) {
-        return new AdaptableUITexture(this.location, calcU(uStart), calcV(vStart), calcU(uEnd), calcV(vEnd), this.canApplyTheme, this.imageWidth, this.imageHeight, this.bl, this.bt, this.br, this.bb, this.tiled);
+        return new AdaptableUITexture(this.location, lerpU(uStart), lerpV(vStart), lerpU(uEnd), lerpV(vEnd), this.canApplyTheme, this.imageWidth, this.imageHeight, this.bl, this.bt, this.br, this.bb, this.tiled);
     }
 
     @Override

src/main/java/com/cleanroommc/modularui/drawable/UITexture.java

@@ -1,11 +1,11 @@
 package com.cleanroommc.modularui.drawable;
 
 import com.cleanroommc.modularui.ModularUI;
-import com.cleanroommc.modularui.api.ITheme;
 import com.cleanroommc.modularui.api.drawable.IDrawable;
 import com.cleanroommc.modularui.screen.viewport.GuiContext;
 import com.cleanroommc.modularui.theme.WidgetTheme;
 import com.cleanroommc.modularui.utils.Color;
+import com.cleanroommc.modularui.utils.Interpolations;
 import com.cleanroommc.modularui.utils.JsonHelper;
 import com.cleanroommc.modularui.widget.sizer.Area;
 import com.google.gson.JsonObject;
@@ -109,19 +109,19 @@ public UITexture getSubArea(Area bounds) {
      * @return relative sub area
      */
     public UITexture getSubArea(float uStart, float vStart, float uEnd, float vEnd) {
-        return new UITexture(this.location, calcU(uStart), calcV(vStart), calcU(uEnd), calcV(vEnd), this.canApplyTheme);
+        return new UITexture(this.location, lerpU(uStart), lerpV(vStart), lerpU(uEnd), lerpV(vEnd), this.canApplyTheme);
     }
 
     public ResourceLocation getLocation() {
         return this.location;
     }
 
-    protected final float calcU(float uNew) {
-        return (this.u1 - this.u0) * uNew + this.u0;
+    protected final float lerpU(float u) {
+        return Interpolations.lerp(this.u0, this.u1, u);
     }
 
-    protected final float calcV(float vNew) {
-        return (this.v1 - this.v0) * vNew + this.v0;
+    protected final float lerpV(float v) {
+        return Interpolations.lerp(this.v0, this.v1, v);
     }
 
     @SideOnly(Side.CLIENT)
@@ -140,7 +140,7 @@ public void draw(float x, float y, float width, float height) {
     }
 
     public void drawSubArea(float x, float y, float width, float height, float uStart, float vStart, float uEnd, float vEnd) {
-        GuiDraw.drawTexture(this.location, x, y, x + width, y + height, calcU(uStart), calcV(vStart), calcU(uEnd), calcV(vEnd));
+        GuiDraw.drawTexture(this.location, x, y, x + width, y + height, lerpU(uStart), lerpV(vStart), lerpU(uEnd), lerpV(vEnd));
     }
 
     @Override

src/main/java/com/cleanroommc/modularui/screen/ModularPanel.java

@@ -133,7 +133,7 @@ public boolean hasParent() {
     }
 
     @Override
-    public WidgetTheme getWidgetTheme(ITheme theme) {
+    public WidgetTheme getWidgetThemeInternal(ITheme theme) {
         return theme.getPanelTheme();
     }
 

src/main/java/com/cleanroommc/modularui/test/TestTile.java

@@ -256,8 +256,8 @@ public ModularPanel buildUI(PosGuiData guiData, PanelSyncManager guiSyncManager)
                                                 .coverChildrenHeight()
                                                 .child(new CycleButtonWidget()
                                                         .size(14, 14)
-                                                        .length(3)
-                                                        .texture(GuiTextures.CYCLE_BUTTON_DEMO)
+                                                        .stateCount(3)
+                                                        .stateBackground(GuiTextures.CYCLE_BUTTON_DEMO)
                                                         .value(new IntSyncValue(() -> this.val2, val -> this.val2 = val))
                                                         .margin(8, 0))
                                                 .child(IKey.str("Hello World").asWidget().height(18)))