binfmt/libelf: Fix return code

SPRESENSE · xiaoxiang781216 · commit 5e81726f21f1 · 2024-10-11T13:52:46.000+08:00
Fix return code in case of error in loading constructor and destructor section.

Detected by Codesonar 54667871, 54667873
diff --git a/binfmt/libelf/libelf_ctors.c b/binfmt/libelf/libelf_ctors.c
@@ -99,7 +99,7 @@ int elf_loadctors(FAR struct elf_loadinfo_s *loadinfo)
        */
 
       binfo("elf_findsection .ctors section failed: %d\n", ctoridx);
-      return ret == -ENOENT ? OK : ret;
+      return ctoridx == -ENOENT ? OK : ctoridx;
     }
 
   /* Now we can get a pointer to the .ctor section in the section header
diff --git a/binfmt/libelf/libelf_dtors.c b/binfmt/libelf/libelf_dtors.c
@@ -100,7 +100,7 @@ int elf_loaddtors(FAR struct elf_loadinfo_s *loadinfo)
        */
 
       binfo("elf_findsection .dtors section failed: %d\n", dtoridx);
-      return ret == -ENOENT ? OK : ret;
+      return dtoridx == -ENOENT ? OK : dtoridx;
     }
 
   /* Now we can get a pointer to the .dtor section in the section header

Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ int elf_loadctors(FAR struct elf_loadinfo_s *loadinfo)`
`99`	`99`	`*/`
`100`	`100`
`101`	`101`	`binfo("elf_findsection .ctors section failed: %d\n", ctoridx);`
`102`		`- return ret == -ENOENT ? OK : ret;`
	`102`	`+ return ctoridx == -ENOENT ? OK : ctoridx;`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`/* Now we can get a pointer to the .ctor section in the section header`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ int elf_loaddtors(FAR struct elf_loadinfo_s *loadinfo)`
`100`	`100`	`*/`
`101`	`101`
`102`	`102`	`binfo("elf_findsection .dtors section failed: %d\n", dtoridx);`
`103`		`- return ret == -ENOENT ? OK : ret;`
	`103`	`+ return dtoridx == -ENOENT ? OK : dtoridx;`
`104`	`104`	`}`
`105`	`105`
`106`	`106`	`/* Now we can get a pointer to the .dtor section in the section header`