add field_offsets to layout info for struct-like types

Author: spernsteiner

SCHEMA_CHANGELOG.md

@@ -3,6 +3,12 @@ The following document describes the changes to the JSON schema that
 as a changelog for the code in the `mir-json` tools themselves, which are
 versioned separately.)
 
+## 9
+
+Add field offsets to the layout information for struct-like types.  This is
+omitted for primitives, unions, and arrays, for which the field offsets are
+easy to compute if needed.
+
 ## 8
 
 Add details to the `InlineType` case for `TyKind::Coroutine` and to the

doc/mir-json-schema.ts

@@ -169,7 +169,8 @@ type FloatKind = { kind: "F32" | "F64" }
 
 type Layout = {
   align: number,
-  size: number
+  size: number,
+  field_offsets?: number[]
 }
 
 

src/analyz/ty_json.rs

@@ -1,3 +1,4 @@
+use rustc_abi::FieldsShape;
 use rustc_data_structures::stable_hasher::{HashStable, StableHasher};
 use rustc_hashes::Hash64;
 use rustc_hir as hir;
@@ -639,12 +640,31 @@ impl<'tcx> ToJson<'tcx> for ty::Ty<'tcx> {
                 let layout = tcx
                     .layout_of(ty::TypingEnv::fully_monomorphized().as_query_input(*self))
                     .unwrap_or_else(|e| panic!("failed to get layout of {:?}: {}", self, e));
+                let field_offsets = match layout.fields {
+                    // `FieldsShape::Primitive` has no fields.
+                    FieldsShape::Primitive => None,
+                    // `FieldsShape::Union` puts all fields at offset zero.
+                    FieldsShape::Union(_) => None,
+                    // `FieldsShape::Array` is used only for array-like types, for which offsets
+                    // are easy to compute if needed.
+                    FieldsShape::Array { .. } => {
+                        assert!(matches!(self.kind(),
+                                ty::TyKind::Array(..) | ty::TyKind::Slice(..) | ty::TyKind::Str),
+                            "unexpected TyKind {:?} for FieldsShape::Array", self.kind());
+                        None
+                    },
+                    FieldsShape::Arbitrary { ref offsets, .. } => {
+                        Some(offsets.iter().map(|&off| off.bytes()).collect::<Vec<_>>())
+                    },
+                };
                 if layout.is_sized() {
                     Some(json!({
                         "align": layout.align.abi.bytes(),
-                        "size": layout.size.bytes()
+                        "size": layout.size.bytes(),
+                        "field_offsets": field_offsets
                     }))
                 } else {
+                    // TODO: provide field offsets even for unsized types
                     None
                 }
             }

src/schema_ver.rs

@@ -6,4 +6,4 @@
 /// Each version of the schema is assumed to be backwards-incompatible with
 /// previous versions of the schema. As such, any time this version number is
 /// bumped, it should be treated as a major version bump.
-pub const SCHEMA_VER: u64 = 8;
+pub const SCHEMA_VER: u64 = 9;