Panic in `Expr.Builder.baseIte`

[langston-barrett]

This assertion can fail:

what4/what4/src/What4/Expr/Builder.hs

Line 1731 in 827b069

Ex.assert (isNothing (reduceIte c x y)) $ do

I don't have a minimal test-case to share at the moment (this came up during symex of a binary), so we should feel free to close this issue if nobody can tell how this happens on visual inspection.

Note that this assertion failure essentially reflects a lack of normalization of an ite expression.

[langston-barrett]

IMO this is the most likely culprit:

what4/what4/src/What4/Expr/Builder.hs

Line 1677 in 827b069

r <- baseIte sym c xr yr

The other baseIte calls are guarded by reduceItes. This should probably just call mkIte instead.

[langston-barrett]

Yep, changing that to mkIte avoids the panic in my tool.