bugfix: design event will now receive values

dorin-ga · dorin-ga · commit 83e4191da176 · 2025-02-14T13:23:30.000+02:00
diff --git a/source/gameanalytics/GameAnalytics.cpp b/source/gameanalytics/GameAnalytics.cpp
@@ -517,7 +517,7 @@ namespace gameanalytics
             try
             {
                 json fieldsJson = utilities::parseFields(fields);
-                events::GAEvents::addDesignEvent(eventId, value, false, fieldsJson, mergeFields);
+                events::GAEvents::addDesignEvent(eventId, value, true, fieldsJson, mergeFields);
             }
             catch(json::exception const& e)
             {
@@ -739,11 +739,6 @@ namespace gameanalytics
         });
     }
 
-    std::string GameAnalytics::getRemoteConfigsValueAsString(std::string const& key)
-    {
-        return getRemoteConfigsValueAsString(key, "");
-    }
-
     std::string GameAnalytics::getRemoteConfigsValueAsString(std::string const& key, std::string const& defaultValue)
     {
         return state::GAState::getRemoteConfigsStringValue(key, defaultValue);

Original file line number	Diff line number	Diff line change
`@@ -517,7 +517,7 @@ namespace gameanalytics`
`517`	`517`	`try`
`518`	`518`	`{`
`519`	`519`	`json fieldsJson = utilities::parseFields(fields);`
`520`		`- events::GAEvents::addDesignEvent(eventId, value, false, fieldsJson, mergeFields);`
	`520`	`+ events::GAEvents::addDesignEvent(eventId, value, true, fieldsJson, mergeFields);`
`521`	`521`	`}`
`522`	`522`	`catch(json::exception const& e)`
`523`	`523`	`{`
`@@ -739,11 +739,6 @@ namespace gameanalytics`
`739`	`739`	`});`
`740`	`740`	`}`
`741`	`741`
`742`		`- std::string GameAnalytics::getRemoteConfigsValueAsString(std::string const& key)`
`743`		`- {`
`744`		`- return getRemoteConfigsValueAsString(key, "");`
`745`		`- }`
`746`		`-`
`747`	`742`	`std::string GameAnalytics::getRemoteConfigsValueAsString(std::string const& key, std::string const& defaultValue)`
`748`	`743`	`{`
`749`	`744`	`return state::GAState::getRemoteConfigsStringValue(key, defaultValue);`