return string to avoid dangling ptrs

Author: dorin-ga

source/gameanalytics/Platform/GADeviceOSX.h

@@ -2,14 +2,15 @@
 #define _GADEVICEOSX_H
 
 #include "GACommon.h"
+#include <string>
 
 #if IS_MAC
 
-const char* getOSXVersion();
-const char* getConnectionType();
+std::string getOSXVersion();
+std::string getConnectionType();
 int getNumCpuCores();
 int64_t getTotalDeviceMemory();
-const char* getGPUName();
+std::string getGPUName();
 
 #endif
 

source/gameanalytics/Platform/GADeviceOSX.mm

@@ -26,7 +26,7 @@
     NSInteger patchVersion;
 } MyOperatingSystemVersion;
 
-const char* getOSXVersion()
+std::string getOSXVersion()
 {
     if (floor(kCFCoreFoundationVersionNumber) > kCFCoreFoundationVersionNumber10_9)
     {
@@ -64,7 +64,7 @@ SCNetworkReachabilityRef createReachabilityRef()
     return reachabilityRef;
 }
 
-const char* getConnectionType()
+std::string getConnectionType()
 {
     // todo: keep this in a class
     static SCNetworkReachabilityRef reachabilityRef = createReachabilityRef();
@@ -107,7 +107,7 @@ int64_t getTotalDeviceMemory()
     return (uint64_t)info.physicalMemory;
 }
 
-const char* getGPUName()
+std::string getGPUName()
 {
     NSArray* devices = MTLCopyAllDevices();
     if(devices && [devices count])

source/gameanalytics/Platform/GAMacOS.cpp

@@ -17,7 +17,7 @@ static struct sigaction prevSigAction;
 
 std::string gameanalytics::GAPlatformMacOS::getOSVersion()
 {
-    const char* osxVersion = getOSXVersion();
+    std::string osxVersion = getOSXVersion();
     return getBuildPlatform() + " " + osxVersion;
 }