Skip to content

Commit f4f36eb

Browse files
committed
do not drop fps values outside range
1 parent bea3925 commit f4f36eb

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

source/gameanalytics/GAHealth.cpp

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,9 @@ namespace gameanalytics
2424
void GAHealth::doFpsReading(float fps)
2525
{
2626
int fpsBucket = std::round(fps);
27-
if(fpsBucket >= 0 && fpsBucket < MAX_FPS_COUNT)
28-
{
29-
_fpsReadings[fpsBucket]++;
30-
}
27+
fpsBucket = std::clamp(fpsBucket, 0, MAX_FPS_VALUE);
28+
29+
_fpsReadings[fpsBucket]++;
3130
}
3231

3332
int GAHealth::getMemoryPercent(int64_t memory)
@@ -169,7 +168,6 @@ namespace gameanalytics
169168
}
170169
}
171170
);
172-
173171
}
174172
}
175173
}

source/gameanalytics/GAHealth.h

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,8 @@ namespace gameanalytics
2929

3030
protected:
3131

32-
static constexpr size_t MAX_FPS_COUNT = 120 + 1;
32+
static constexpr int MAX_FPS_VALUE = 120;
33+
static constexpr size_t MAX_FPS_COUNT = MAX_FPS_VALUE + 1;
3334
static constexpr size_t MAX_MEMORY_COUNT = 100 + 1;
3435

3536
static constexpr std::chrono::milliseconds MEMORY_TRACK_FREQ {5000};

0 commit comments

Comments
 (0)