Skip to content

Commit a15fb11

Browse files
authored
Do not bin values for distribution metrics (#17)
For summary metrics, we put values into "bins" of 1000 before entering them into the histogram, which works well for durations in milliseconds. For distribution, let's keep the original values, so that we can report discrete metrics.
1 parent 831948b commit a15fb11

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/telemetry_metrics_statman.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ defmodule TelemetryMetricsStatman do
8080
do: :statman_histogram.record_value(key, :statman_histogram.bin(value))
8181

8282
defp report(%Metrics.Distribution{}, key, value),
83-
do: :statman_histogram.record_value(key, :statman_histogram.bin(value))
83+
do: :statman_histogram.record_value(key, value)
8484

8585

8686
defp metric_key(metric, [] = _tags, _metadata),

0 commit comments

Comments
 (0)