[Bug]: backup (vhserver) stopped working with 25.1.1

[freaky-m0]

User story

I start a backup, backup should be created and old backups should be found and considered.

Game

Valheim

Linux distro

Debian 12

Command

command: backup

Further information

All started with a backup that was way to big (because it included the old backups as I know now).
I have an existing server and a new server. Both stopped doing backups (even manually).

[ FAIL ] Backup vhserver: Problem identifying the previous backup directory for exclusion.

I then tried to find the cause and identified the fn_backup_relpath() function in commmand_backup.sh.

I reverted the latest changes from 25.1.0:

It started working again.

Relevant log output

[ FAIL ] Backup vhserver: Problem identifying the previous backup directory for exclusion.

Steps to reproduce

1. Create a backup
2. See error in output

[NormenKD]

Can reproduce on Ubuntu 24.04.1 LTS and "sdtdserver".

[ FAIL ] Backup sdtdserver: Problem identifying the previous backup directory for exclusion.

Backups seem to have not been working for a long time in my case. Also, the backup lockfile seems to be created but not removed after the error.

[dgibbs64]

Thanks for finding this. I will be releasing a hotfix soon to revert the change

[jamersonnascimento]

Consegui resolver! Atualizei a ferramenta Linux GSM para a versão 25.1.5. Depois, simplesmente eu fui até a pasta ~/lgsm/lock e, dentro da pasta, apaguei o arquivo backup.lock. Depois desse procedimento, o comando ./gameserver backup voltou a funcionar corretamente xD