feat: change Dockerfile naming convention

* Updated `generate-dockerfiles.sh` to use hyphens in Dockerfile names for consistency.
* Modified `action-docker-publish.yml` to ensure proper variable expansion.
* Added permissions section in `action-package-cleanup.yml` for better access control.

Author: dgibbs64

.github/workflows/action-docker-publish.yml

@@ -46,9 +46,9 @@ jobs:
 
       - id: set-matrix
         run: |
-          shortnamearray=$(cat shortnamearray.json)
+          shortnamearray=$(cat "shortnamearray.json")
           echo "${shortnamearray}"
-          echo -n "matrix=${shortnamearray}" >> $GITHUB_OUTPUT
+          echo -n "matrix=${shortnamearray}" >> ${GITHUB_OUTPUT}
 
   generate-docker-compose:
     name: Generate docker-compose.yml files

.github/workflows/action-package-cleanup.yml

@@ -4,6 +4,10 @@ on:
   schedule:
     - cron: "5 4 * * 3"
 
+permissions:
+  contents: read
+  packages: write
+
 jobs:
   package-cleanup:
     name: Cleanup Old GitHub Packages

generate-dockerfiles.sh

@@ -14,9 +14,9 @@ while read -r line; do
   export gamename
   distro=$(echo "$line" | awk -F, '{ print $4 }')
   export distro
-  touch "dockerfiles/Dockerfile.${shortname}"
-  echo "Generating Dockerfile.${shortname} (${gamename})"
-  jinjanate Dockerfile.j2 >"dockerfiles/Dockerfile.${shortname}"
+  touch "dockerfiles/Dockerfile-${shortname}"
+  echo "Generating Dockerfile-${shortname} (${gamename})"
+  jinjanate Dockerfile-j2 >"dockerfiles/Dockerfile-${shortname}"
   { printf '{"shortname":"%s"},' "$shortname"; } >>"shortnamearray.json"
 done < <(tail -n +2 serverlist.csv)
 sed -i '$ s/.$//' "shortnamearray.json"