refactor: shellcheck feedback

* Changed variable assignment to avoid unnecessary exports.
* Simplified the process of generating JSON entries for `shortnamearray.json`.
* Enhanced readability and maintainability of `generate-docker-compose.sh` and `generate-dockerfiles.sh`.

Author: dgibbs64

generate-docker-compose.sh

@@ -5,18 +5,19 @@ curl -O "https://raw.githubusercontent.com/GameServerManagers/LinuxGSM/master/lg
 echo -n "{" >"shortnamearray.json"
 echo -n "\"include\":[" >>"shortnamearray.json"
 
-while read line; do
-  export shortname=$(echo "$line" | awk -F, '{ print $1 }')
-  export servername=$(echo "$line" | awk -F, '{ print $2 }')
-  export gamename=$(echo "$line" | awk -F, '{ print $3 }')
-  export distro=$(echo "$line" | awk -F, '{ print $4 }')
+while read -r line; do
+  shortname=$(echo "$line" | awk -F, '{ print $1 }')
+  export shortname
+  servername=$(echo "$line" | awk -F, '{ print $2 }')
+  export servername
+  gamename=$(echo "$line" | awk -F, '{ print $3 }')
+  export gamename
+  distro=$(echo "$line" | awk -F, '{ print $4 }')
+  export distro
   touch "docker-compose/docker-compose-${shortname}.yml"
   echo "Generating docker-compose-${shortname}.yml (${gamename})"
   jinjanate docker-compose.yml.j2 >"docker-compose/docker-compose-${shortname}.yml"
-  echo -n "{" >>"shortnamearray.json"
-  echo -n "\"shortname\":" >>"shortnamearray.json"
-  echo -n "\"${shortname}\"" >>"shortnamearray.json"
-  echo -n "}," >>"shortnamearray.json"
+  { printf '{"shortname":"%s"},' "$shortname"; } >>"shortnamearray.json"
 done < <(tail -n +1 serverlist.csv)
 sed -i '$ s/.$//' "shortnamearray.json"
 echo -n "]" >>"shortnamearray.json"

generate-dockerfiles.sh

@@ -6,17 +6,18 @@ echo -n "{" >"shortnamearray.json"
 echo -n "\"include\":[" >>"shortnamearray.json"
 
 while read line; do
-  export shortname=$(echo "$line" | awk -F, '{ print $1 }')
-  export servername=$(echo "$line" | awk -F, '{ print $2 }')
-  export gamename=$(echo "$line" | awk -F, '{ print $3 }')
-  export distro=$(echo "$line" | awk -F, '{ print $4 }')
+  shortname=$(echo "$line" | awk -F, '{ print $1 }')
+  export shortname
+  servername=$(echo "$line" | awk -F, '{ print $2 }')
+  export servername
+  gamename=$(echo "$line" | awk -F, '{ print $3 }')
+  export gamename
+  distro=$(echo "$line" | awk -F, '{ print $4 }')
+  export distro
   touch "dockerfiles/Dockerfile.${shortname}"
   echo "Generating Dockerfile.${shortname} (${gamename})"
   jinjanate Dockerfile.j2 >"dockerfiles/Dockerfile.${shortname}"
-  echo -n "{" >>"shortnamearray.json"
-  echo -n "\"shortname\":" >>"shortnamearray.json"
-  echo -n "\"${shortname}\"" >>"shortnamearray.json"
-  echo -n "}," >>"shortnamearray.json"
+  { printf '{"shortname":"%s"},' "$shortname"; } >>"shortnamearray.json"
 done < <(tail -n +2 serverlist.csv)
 sed -i '$ s/.$//' "shortnamearray.json"
 echo -n "]" >>"shortnamearray.json"