cli flag presence and better defaults for svc logging

Author: planetchili

IntelPresentMon/CommonUtilities/cli/CliFramework.cpp

@@ -88,12 +88,16 @@ namespace pmon::util::cli
 	}
 	Flag::operator bool() const
 	{
-		return (bool)*pOption_;
+		return data_;
 	}
 	bool Flag::operator!() const
 	{
 		return !bool(*this);
 	}
+	bool Flag::IsPresent() const
+	{
+		return (bool)*pOption_;
+	}
 	std::function<std::string(std::string)> OptionsElement_::GetCaptureCallback_()
 	{
 		return [this](std::string s) -> std::string {

IntelPresentMon/CommonUtilities/cli/CliFramework.h

@@ -213,6 +213,7 @@ namespace pmon::util::cli
 		{
 			return pOption_->get_name();
 		}
+		bool IsPresent() const;
 	private:
 		bool data_ = false;
 		CLI::Option* pOption_ = nullptr;

IntelPresentMon/PresentMonService/CliOptions.h

@@ -26,8 +26,8 @@ namespace clio
 	private: Group gl_{ this, "Logging", "Control logging behavior" }; public:
 		Option<std::string> logDir{ this, "--log-dir", "", "Enable logging to a file in the specified directory" };
 		Option<std::string> logPipeName{ this, "--log-pipe-name", pmon::gid::defaultLogPipeBaseName, "Name of the pipe to connect to for log IPC" };
-		Flag disableStdioLog{ this, "--disable-stdio-log", "Disable logging to stderr" };
-		Flag disableDebuggerLog{ this, "--disable-debugger-log", "Disable logging to system debugger" };
+		Flag enableStdioLog{ this, "--enable-stdio-log", "Disable logging to stderr" };
+		Flag enableDebuggerLog{ this, "--enable-debugger-log", "Disable logging to system debugger" };
 		Flag disableIpcLog{ this, "--disable-ipc-log", "Disable logging to named pipe connection" };
 		Option<Level> logLevel{ this, "--log-level", Level::Error, "Severity to log at", logLevelTf_ };
 

IntelPresentMon/PresentMonService/LogSetup.cpp

@@ -71,10 +71,10 @@ namespace logsetup
 			if (opt.logLevel) {
 				GlobalPolicy::Get().SetLogLevel(*opt.logLevel);
 			}
-			if (opt.disableStdioLog) {
+			if (!opt.enableStdioLog) {
 				pChannel->AttachComponent({}, "drv:std");
 			}
-			if (opt.disableDebuggerLog) {
+			if (!opt.enableDebuggerLog) {
 				pChannel->AttachComponent({}, "drv:dbg");
 			}
 			if (opt.logDir) {