Skip to content

Commit 461fb66

Browse files
committed
improve logging for svc actions
1 parent 61bb0da commit 461fb66

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

IntelPresentMon/PresentMonService/ActionServer.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ namespace pmon::svc
8080
// insert a session context object for this connection, will be initialized properly upon OpenSession action
8181
sessionId = pPipe->GetId();
8282
sessions[*sessionId].pPipe = pPipe;
83+
pmlog_info(std::format("Action pipe connected id:{}", *sessionId));
8384
// fork this acceptor coroutine
8485
as::co_spawn(ioctx_, AcceptConnection_(), as::detached);
8586
// run the action handler until client session is terminated
@@ -95,7 +96,7 @@ namespace pmon::svc
9596
clientPid = i->second.clientPid;
9697
}
9798
actionManager_.ctx_.DisposeSession(*sessionId);
98-
pmlog_info(std::format("Action pipe disconnected id:{} pid:{}", *sessionId, clientPid));
99+
pmlog_info(std::format("Action pipe disconnected, session closed id:{} pid:{}", *sessionId, clientPid));
99100
co_return;
100101
}
101102
pmlog_info("Sessionless pipe disconnected");

IntelPresentMon/PresentMonService/acts/OpenSession.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ namespace pmon::svc::acts
3636
stx.clientPid = in.clientPid;
3737
stx.clientBuildId = in.clientBuildId;
3838
ctx.pSvc->SignalClientSessionOpened();
39-
pmlog_dbg(std::format("Received open session action from {} BID={} vs {} (svc)",
40-
in.clientPid, in.clientBuildId, BuildIdShortHash()));
39+
pmlog_info(std::format("Open action for session #{} pid={}; [BID] cli={} svc={}",
40+
stx.pPipe->GetId(), in.clientPid, in.clientBuildId, BuildIdShortHash()));
4141
return Response{ .serviceBuildId = BuildIdShortHash() };
4242
}
4343
};

IntelPresentMon/PresentMonService/acts/StartTracking.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ namespace pmon::svc::acts
3939
}
4040
stx.trackedPids.insert(in.targetPid);
4141
const Response out{ .nsmFileName = std::move(nsmFileName) };
42-
pmlog_dbg(std::format("StartStreaming action from [{}] targetting [{}] assigned nsm [{}]",
42+
pmlog_info(std::format("StartTracking action from [{}] targeting [{}] assigned nsm [{}]",
4343
stx.clientPid, in.targetPid, out.nsmFileName));
4444
return out;
4545
}

IntelPresentMon/PresentMonService/acts/StopTracking.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace pmon::svc::acts
2727
{
2828
ctx.pPmon->StopStreaming(stx.clientPid, in.targetPid);
2929
stx.trackedPids.erase(in.targetPid);
30-
pmlog_dbg(std::format("StopStreaming action from [{}] un-targeting [{}]", stx.clientPid, in.targetPid));
30+
pmlog_info(std::format("StopTracking action from [{}] un-targeting [{}]", stx.clientPid, in.targetPid));
3131
return {};
3232
}
3333
};

0 commit comments

Comments
 (0)