Merge branch 'infra/coverity-fixes-ray' into infra/coverity

Author: planetchili

IntelPresentMon/CommonUtilities/cli/CliFramework.h

@@ -87,6 +87,11 @@ namespace pmon::util::cli
 		{
 			pOption_ = pParent->app_.add_option(std::move(names), data_, std::move(description));
 		}
+		Option(const Option&) = delete;
+		Option & operator=(const Option&) = delete;
+		Option(Option&&) = delete;
+		Option & operator=(Option&&) = delete;
+		~Option() = default;
 		const T& operator*() const
 		{
 			return data_;

IntelPresentMon/Core/source/pmon/RawFrameDataWriter.cpp

@@ -100,7 +100,8 @@ namespace p2c::pmon
             if (available) {
                 const auto typeId = metric.GetDataTypeInfo().GetFrameType();
                 // DISPLAYED_TIME and DISPLAY_LATENCY should just show zeros when NaN is encountered
-                const bool zeroForNA = metricId == PM_METRIC_DISPLAYED_TIME || PM_METRIC_DISPLAY_LATENCY;
+                const bool zeroForNA = (metricId == PM_METRIC_DISPLAYED_TIME)
+                    || (metricId == PM_METRIC_DISPLAY_LATENCY);
                 // special case for TIME, it needs to be relative to TIME of first frame and scaled ms => s
                 if (metricId == PM_METRIC_TIME) {
                     pAnnotation = std::make_unique<TypedAnnotation_<TimeAnnotationType_>>();

IntelPresentMon/Core/source/pmon/metric/MetricFetcher.h

@@ -9,8 +9,14 @@ namespace p2c::pmon::met
     class MetricFetcher
     {
     public:
+        MetricFetcher() = default;
         virtual ~MetricFetcher();
         virtual std::wstring ReadStringValue();
         virtual std::optional<float> ReadValue() = 0;
+
+        MetricFetcher(const MetricFetcher&) = delete;
+        MetricFetcher & operator=(const MetricFetcher&) = delete;
+        MetricFetcher(MetricFetcher&&) = delete;
+        MetricFetcher & operator=(MetricFetcher&&) = delete;
     };
 }

IntelPresentMon/Interprocess/source/IntrospectionCloneAllocators.h

@@ -16,6 +16,7 @@ namespace pmon::ipc::intro
 		ProbeAllocator(const ProbeAllocator<void>& other)
 			: pTotalSize(other.pTotalSize)
 		{}
+		ProbeAllocator& operator=(const ProbeAllocator&) = delete;
 		T* allocate(size_t count)
 		{
 			*pTotalSize += sizeof(T) * count + util::GetPadding<T>(*pTotalSize);
@@ -43,6 +44,7 @@ namespace pmon::ipc::intro
 			pTotalSize(other.pTotalSize),
 			pBytes{ other.pBytes }
 		{}
+		BlockAllocator& operator=(const BlockAllocator&) = delete;
 		T* allocate(size_t count)
 		{
 			*pTotalSize += util::GetPadding<T>(*pTotalSize);

IntelPresentMon/PresentMonService/Service.h

@@ -20,6 +20,7 @@ class Service
 	std::optional<int> GetErrorCode() const;
 	virtual HANDLE GetServiceStopHandle() = 0;
 	virtual HANDLE GetResetPowerTelemetryHandle() = 0;
+	virtual ~Service() = default;
 private:
 	std::optional<int> errCode_;
 };
@@ -31,6 +32,12 @@ class ConsoleDebugMockService : public Service
 	void Run();
 	HANDLE GetServiceStopHandle() override;
 	HANDLE GetResetPowerTelemetryHandle() override;
+
+	ConsoleDebugMockService(const ConsoleDebugMockService&) = delete;
+	ConsoleDebugMockService & operator=(const ConsoleDebugMockService&) = delete;
+	ConsoleDebugMockService(ConsoleDebugMockService&&) = delete;
+	ConsoleDebugMockService & operator=(ConsoleDebugMockService&&) = delete;
+
 private:
 	ConsoleDebugMockService();
 	~ConsoleDebugMockService();
@@ -52,6 +59,15 @@ class ConcreteService : public Service
   }
   void ReportServiceStatus(DWORD currentState, DWORD win32ExitCode,
                                   DWORD waitHint);
+
+
+  ConcreteService(const ConcreteService&) = delete;
+  ConcreteService & operator=(const ConcreteService&) = delete;
+  ConcreteService(ConcreteService&&) = delete;
+  ConcreteService & operator=(ConcreteService&&) = delete;
+  ~ConcreteService() = default;
+
+
  private:
   void ServiceInit();