Skip to content

Commit f10fc2c

Browse files
committed
more verbose telemetry logging
1 parent d737295 commit f10fc2c

File tree

5 files changed

+21
-13
lines changed

5 files changed

+21
-13
lines changed

IntelPresentMon/ControlLib/ControlLib.vcxproj

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@
206206
<ClInclude Include="Exceptions.h" />
207207
<ClInclude Include="IntelPowerTelemetryAdapter.h" />
208208
<ClInclude Include="Logging.h" />
209+
<ClInclude Include="LoggingVerbose.h" />
209210
<ClInclude Include="MacroHelpers.h" />
210211
<ClInclude Include="nvapi.h" />
211212
<ClInclude Include="NvapiWrapper.h" />

IntelPresentMon/ControlLib/ControlLib.vcxproj.filters

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@
7979
<ClInclude Include="ctlpvttemp_api.h">
8080
<Filter>Intel</Filter>
8181
</ClInclude>
82+
<ClInclude Include="LoggingVerbose.h" />
8283
</ItemGroup>
8384
<ItemGroup>
8485
<ClCompile Include="NvapiWrapper.cpp">

IntelPresentMon/ControlLib/IntelPowerTelemetryAdapter.cpp

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ namespace pwr::intel
3333

3434
bool IntelPowerTelemetryAdapter::Sample() noexcept
3535
{
36+
pmlog_verb(v::gpu)("Sample called");
37+
3638
LARGE_INTEGER qpc;
3739
QueryPerformanceCounter(&qpc);
3840
bool success = true;
@@ -473,9 +475,10 @@ namespace pwr::intel
473475
currentSample.vramReadBandwidth,
474476
pm_gpu_power_telemetry_info.gpu_mem_read_bandwidth_bps,
475477
GpuTelemetryCapBits::gpu_mem_read_bandwidth);
476-
pmlog_verb(v::gpu)(std::format("VR read BW bSupported [{}] type [{}] units [{}] data [{}]",
478+
pmlog_verb(v::gpu)(std::format("VRAM read BW bSupported [{}] type [{}] units [{}] data_64 [{}] data_double [{}]",
477479
currentSample.vramReadBandwidth.bSupported, (int)currentSample.vramReadBandwidth.type,
478-
(int)currentSample.vramReadBandwidth.units, currentSample.vramReadBandwidth.value.datau64));
480+
(int)currentSample.vramReadBandwidth.units, currentSample.vramReadBandwidth.value.datau64,
481+
currentSample.vramReadBandwidth.value.datadouble));
479482
if (result != CTL_RESULT_SUCCESS ||
480483
!(HasTelemetryCapBit(GpuTelemetryCapBits::gpu_mem_read_bandwidth))) {
481484
useNewBandwidthTelemetry = false;
@@ -488,9 +491,10 @@ namespace pwr::intel
488491
currentSample.vramWriteBandwidth,
489492
pm_gpu_power_telemetry_info.gpu_mem_write_bandwidth_bps,
490493
GpuTelemetryCapBits::gpu_mem_write_bandwidth);
491-
pmlog_verb(v::gpu)(std::format("VR write BW bSupported [{}] type [{}] units [{}] data [{}]",
494+
pmlog_verb(v::gpu)(std::format("VRAM write BW bSupported [{}] type [{}] units [{}] data_64 [{}] data_double [{}]",
492495
currentSample.vramWriteBandwidth.bSupported, (int)currentSample.vramWriteBandwidth.type,
493-
(int)currentSample.vramWriteBandwidth.units, currentSample.vramWriteBandwidth.value.datau64));
496+
(int)currentSample.vramWriteBandwidth.units, currentSample.vramWriteBandwidth.value.datau64,
497+
currentSample.vramReadBandwidth.value.datadouble));
494498
if (result != CTL_RESULT_SUCCESS ||
495499
!(HasTelemetryCapBit(GpuTelemetryCapBits::gpu_mem_write_bandwidth))) {
496500
useNewBandwidthTelemetry = false;

IntelPresentMon/ControlLib/Logging.h

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,7 @@
55
#include <format>
66
#include "igcl_api.h"
77
#include "../CommonUtilities/log/Log.h"
8-
9-
namespace pwr::v
10-
{
11-
#ifndef VVV_GPU_TELEMETRY // system that reads power, temperature, etc. telemetry of graphics adapter devices
12-
inline constexpr bool gpu = false;
13-
#else
14-
inline constexpr bool gpu = true;
15-
#endif
16-
}
8+
#include "LoggingVerbose.h"
179

1810
namespace pwr::log
1911
{
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
#pragma once
2+
3+
namespace pwr::v
4+
{
5+
#ifndef VVV_GPU_TELEMETRY // system that reads power, temperature, etc. telemetry of graphics adapter devices
6+
inline constexpr bool gpu = false;
7+
#else
8+
inline constexpr bool gpu = true;
9+
#endif
10+
}

0 commit comments

Comments
 (0)