Spawner Minecarts - feature update (#1210)

* update Spawner Minecarts

* don't count yourself, what are you doing?

* beeps' comments

Author: TheThanathor

gm4_spawner_minecarts/README.md

@@ -4,5 +4,4 @@ Pick up Spawners and move them wherever you want with Minecarts.<!--$pmc:headerS
 
 ### Features
 - Any spawner can be pushed into a Minecart buy pushing it with a piston
-- Spawner Minecarts have a max number of spawns and need to be re-charged by consuming nearby tall grass and flowers
-- Each world has a different set of good/bad flowers for recharging which need to discovered by particles emitted during the charging process
+- Spawner Minecarts have a reduced spawn rate for each nearby spawner minecart

gm4_spawner_minecarts/assets/translations.csv

@@ -2,7 +2,5 @@ key,en_us
 advancement.gm4.spawner_minecarts.title,Don't Go Breaking My Cart
 advancement.gm4.spawner_minecarts.description,Capture a Monster Spawner
 text.gm4.guidebook.module_desc.spawner_minecarts,Pick up Spawners and move them wherever you want with Minecarts.
-text.gm4.guidebook.spawner_minecarts.description,Spawners can be picked up with Minecarts.\n\nOnce a spawner is in a minecart it cannot be ejected and requires charging to spawn mobs.
+text.gm4.guidebook.spawner_minecarts.description,Spawners can be picked up with Minecarts.\n\nOnce a spawner is in a minecart it cannot be ejected and has reduced spawn rates for all carts within a 9x8x9 area around the spawner.
 text.gm4.guidebook.spawner_minecarts.pick_up,"To capture a spawner, place a minecart under it, then a downwards piston above the spawner, and finally a redstone block above the piston."
-text.gm4.guidebook.spawner_minecarts.recharging,"Spawner minecarts require charge to spawn mobs. They passively charge over time.\n\nWhen on a powered rail, it will stop spawning mobs and start actively charging by consuming flowers in a 9x9 area."
-text.gm4.guidebook.spawner_minecarts.recharging_1,"Some flowers charge the spawner minecart twice as fast as others; this differs in each world.\n\nWhen a spawner minecart fully recharges, it will activate any detector rails it is on."

gm4_spawner_minecarts/beet.yaml

@@ -1,6 +1,6 @@
 id: gm4_spawner_minecarts
 name: Spawner Minecarts
-version: 2.7.X
+version: 3.0.X
 
 data_pack:
   load: .

gm4_spawner_minecarts/data/gm4_spawner_minecarts/function/capture_spawner.mcfunction

@@ -0,0 +1,19 @@
+# try to pick up spawner with minecart
+# @s = minecarts under spawners
+# at @s
+# run from main
+
+# get spawner data
+data modify storage gm4_spawner_minecarts:temp spawner set from block ~ ~1 ~
+
+# check if this spawner is blacklisted
+execute if data storage gm4_spawner_minecarts:temp spawner.SpawnPotentials[{data:{entity:{data:{gm4_spawner_minecrarts:{ban_pickup:1}}}}}] run return run function gm4_spawner_minecarts:capture_spawner/fail_pickup
+execute if data storage gm4_spawner_minecarts:temp spawner.SpawnData[{data:{entity:{data:{gm4_spawner_minecrarts:{ban_pickup:1}}}}}] run return run function gm4_spawner_minecarts:capture_spawner/fail_pickup
+
+# pick up spawner
+summon spawner_minecart ~ ~ ~ {Tags:["gm4_spawner_minecart","gm4_spawner_minecart.new"],MaxNearbyEntities:6,RequiredPlayerRange:16,SpawnCount:4,SpawnData:{entity:{id:"minecraft:pig"}},MaxSpawnDelay:600s,Delay:-1,SpawnRange:4s,MinSpawnDelay:100s,SpawnPotentials:[],Invulnerable:1b}
+setblock ~ ~1 ~ air destroy
+data modify entity @e[tag=gm4_spawner_minecart.new,limit=1,distance=..1] {} merge from storage gm4_spawner_minecarts:temp spawner
+tag @e[tag=gm4_spawner_minecart.new,limit=1,distance=..1] remove gm4_spawner_minecart.new
+advancement grant @a[distance=..5,gamemode=!spectator] only gm4:spawner_minecarts
+kill @s