End Fishing - Change enderpuff to be nonplaceable (#1221)

* Change enderpuff to poisonous potato w/ player head model

* Change predicates to not check ID
- so existing enderpuffs still function

* Bring back the id checks as a tag list

Author: runcows

gm4_end_fishing/data/gm4_end_fishing/loot_table/items/enderpuff.json

@@ -5,7 +5,7 @@
       "entries": [
         {
           "type": "minecraft:item",
-          "name": "minecraft:player_head",
+          "name": "minecraft:poisonous_potato",
           "functions": [
             {
               "function": "minecraft:set_name",
@@ -20,7 +20,9 @@
               "function": "minecraft:set_components",
               "components": {
                 "minecraft:custom_model_data": "item/enderpuff",
-                "minecraft:profile": "$enderpuff"
+                "minecraft:profile": "$enderpuff",
+                "minecraft:item_model": "minecraft:player_head",
+                "!minecraft:consumable": {}
               }
             },
             {

gm4_end_fishing/data/gm4_end_fishing/predicate/carries_enderpuff.json

@@ -7,7 +7,7 @@
       "predicate": {
         "slots": {
           "container.*": {
-            "items": "minecraft:player_head",
+            "items": "#gm4_end_fishing:enderpuff",
             "predicates": {
               "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
             }
@@ -21,7 +21,7 @@
       "predicate": {
         "slots": {
           "armor.*": {
-            "items": "minecraft:player_head",
+            "items": "#gm4_end_fishing:enderpuff",
             "predicates": {
               "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
             }
@@ -35,7 +35,7 @@
       "predicate": {
         "slots": {
           "player.cursor": {
-            "items": "minecraft:player_head",
+            "items": "#gm4_end_fishing:enderpuff",
             "predicates": {
               "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
             }
@@ -49,7 +49,7 @@
       "predicate": {
         "slots": {
           "player.crafting.*": {
-            "items": "minecraft:player_head",
+            "items": "#gm4_end_fishing:enderpuff",
             "predicates": {
               "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
             }
@@ -63,7 +63,7 @@
       "predicate": {
         "slots": {
           "weapon.*": {
-            "items": "minecraft:player_head",
+            "items": "#gm4_end_fishing:enderpuff",
             "predicates": {
               "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
             }

gm4_end_fishing/data/gm4_end_fishing/predicate/holding_enderpuff.json

@@ -4,9 +4,7 @@
   "predicate": {
     "slots": {
       "weapon.*": {
-        "items": [
-          "minecraft:player_head"
-        ],
+        "items": "#gm4_end_fishing:enderpuff",
         "predicates": {
           "minecraft:custom_data": "{gm4_end_fishing:{enderpuff:1b}}"
         }

gm4_end_fishing/data/gm4_end_fishing/tags/item/enderpuff.json

@@ -0,0 +1,6 @@
+{
+  "values": [
+    "minecraft:player_head",
+    "minecraft:poisonous_potato"
+  ]
+}