Huge modifications!

Author: GamerPablito

haxelib.json

@@ -9,7 +9,7 @@
         "fnf"
     ],
     "description": "An useful tool to work with GameJolt for FNF Mods and Haxe Games as well!",
-    "version": "6.0.0",
+    "version": "6.1.0",
     "classPath": "src/",
     "releasenote": "Brand New Organization to Everything!",
     "contributors": [

src/gamejolt/GameJolt.hx

@@ -53,7 +53,7 @@ class GJRequest {
 	/**
 	 * The last response generated by `send()` spawns here.
 	 */
-	public var lastResponse(default, null):Response = {};
+	public var lastResponse(default, null):Response = {success: false, message: "No response has been received yet"};
 
 	/**
 	 * The current instruction `this` is willing to execute. Cannot be modified while `executing == true`.
@@ -84,7 +84,7 @@ class GJRequest {
 		call = Call;
 
 	function get_url():String
-		return 'https://api.gamejolt.com/api/game/v1_2${parseType(call)}';
+		return sign('https://api.gamejolt.com/api/game/v1_2${parseType(call)}');
 
 	function set_call(value:RequestType):RequestType {
 		if (executing)
@@ -101,45 +101,36 @@ class GJRequest {
 			return;
 		executing = true;
 
-		sys.thread.Thread.create(function() {
-			var loader = new openfl.net.URLLoader();
-			loader.addEventListener(Event.COMPLETE, function(complete) {
-				var response:Response = lastResponse = formatImages(cast haxe.Json.parse(loader.data).response);
-				if (response.message != null) {
-					var err:String = 'Response Error: ${response.message}';
-					if (response.responses != null) {
-						var index:Int = response.responses.findIndex(r -> r.message != null);
-						if (index >= 0)
-							err += ' (Request #$index: ${response.responses[index].message})';
-					}
-					onError(err);
-				} else
-					onComplete(response);
-
-				executing = false;
-			});
-			loader.addEventListener(ProgressEvent.PROGRESS, progress -> onProgress(progress.bytesLoaded, progress.bytesTotal));
-			loader.addEventListener(IOErrorEvent.IO_ERROR, function(ioError) {
-				lastResponse = {message: 'IO Error: ${ioError.text}'}
-				onError(lastResponse.message);
-				executing = false;
-			});
-			loader.addEventListener(SecurityErrorEvent.SECURITY_ERROR, securityError -> {
-				lastResponse = {message: 'Security Error: ${securityError.text}'}
-				onError(lastResponse.message);
-				executing = false;
-			});
-			loader.load(new openfl.net.URLRequest(url));
+		var loader = new openfl.net.URLLoader();
+		loader.addEventListener(Event.COMPLETE, function(complete) {
+			trace("Success!");
+			lastResponse = formatImages(cast haxe.Json.parse(loader.data).response);
+			if (lastResponse.message != null)
+				onError('Response Error: ${lastResponse.message}');
+			else
+				onComplete(lastResponse);
+			executing = false;
+		});
+		loader.addEventListener(ProgressEvent.PROGRESS, progress -> onProgress(progress.bytesLoaded, progress.bytesTotal));
+		loader.addEventListener(IOErrorEvent.IO_ERROR, function(ioError) {
+			lastResponse = {success: false, message: 'IO Error: ${ioError.text}'}
+			onError(lastResponse.message);
+			executing = false;
+		});
+		loader.addEventListener(SecurityErrorEvent.SECURITY_ERROR, securityError -> {
+			lastResponse = {success: false, message: 'Security Error: ${securityError.text}'}
+			onError(lastResponse.message);
+			executing = false;
 		});
+		loader.load(new openfl.net.URLRequest(url));
 	}
 
 	/**
 	 * Makes retrieved images to have a better resolution.
 	 * @param oldRes The `Response` to be modified.
 	 * @return A new `Response` with every Image URL modified for a better resolution when requested.
 	 */
-	function formatImages(oldRes:Response):Response {
-		var res:Response = oldRes;
+	function formatImages(res:Response):Response {
 		if (res.users != null)
 			res.users.iter(u -> u.avatar_url = '${u.avatar_url.substring(0, 32)}1000${u.avatar_url.substr(34)}'.replace(".jpg", ".png")
 				.replace(".webp", ".png"));
@@ -346,7 +337,7 @@ class GJRequest {
 
 		var urlSection:String = '/$command${action != "" ? '/$action' : ""}?game_id=${GameJolt.gameID}${[for (p in params) '&${p.name}=${p.value}'].join("")}';
 		if (signed)
-			urlSection = sign(urlSection);
+			urlSection = sign(urlSection).urlEncode();
 		return urlSection;
 	}
 
@@ -357,6 +348,6 @@ class GJRequest {
 	 */
 	function sign(daUrl:String):String {
 		var urlToEncode:String = daUrl + GameJolt.gameKey;
-		return '$daUrl&signature=${GameJolt.usingMd5 ? haxe.crypto.Md5.encode(urlToEncode) : haxe.crypto.Sha1.encode(urlToEncode)}'.urlEncode();
+		return '$daUrl&signature=${GameJolt.usingMd5 ? haxe.crypto.Md5.encode(urlToEncode) : haxe.crypto.Sha1.encode(urlToEncode)}';
 	}
 }

src/gamejolt/formats/Response.hx

@@ -3,33 +3,32 @@ package gamejolt.formats;
 /**
  * This is how GameJolt API responses are formatted like.
  */
-@:structInit
-class Response {
+typedef Response = {
 	// General
-	public var success:Bool = false;
-	@:optional public var message:String = "No successful response has been received yet";
+	success:Bool,
+	?message:String,
 	// User Fetching
-	@:optional public var users:Array<User>;
+	?users:Array<User>,
 	// Trophies Fetching
-	@:optional public var trophies:Array<Trophy>;
+	?trophies:Array<Trophy>,
 	// Scores Fetching
-	@:optional public var scores:Array<Score>;
-	@:optional public var tables:Array<ScoreTable>;
-	@:optional public var rank:Int;
+	?scores:Array<Score>,
+	?tables:Array<ScoreTable>,
+	?rank:Int,
 	// Friends Fetching
-	@:optional public var friends:Array<{friend_id:Int}>;
+	?friends:Array<{friend_id:Int}>,
 	// Data Store Fetching
-	@:optional public var keys:Array<{key:String}>;
-	@:optional public var data:String;
+	?keys:Array<{key:String}>,
+	?data:String,
 	// Time Fetching
-	@:optional public var timestamp:Int;
-	@:optional public var timezone:String;
-	@:optional public var year:Int;
-	@:optional public var month:Int;
-	@:optional public var day:Int;
-	@:optional public var hour:Int;
-	@:optional public var minute:Int;
-	@:optional public var second:Int;
+	?timestamp:Int,
+	?timezone:String,
+	?year:Int,
+	?month:Int,
+	?day:Int,
+	?hour:Int,
+	?minute:Int,
+	?second:Int,
 	// Batch Reception
-	@:optional public var responses:Array<Response>;
+	?responses:Array<Response>
 }