Skip to content

Commit 088bc0b

Browse files
authored
Merge pull request #2 from GaryHilares/develop
Improved templates, added changelog and added CMake project version
2 parents f05234e + c4c403f commit 088bc0b

File tree

4 files changed

+51
-17
lines changed

4 files changed

+51
-17
lines changed
Lines changed: 10 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
---
22
name: Bug report
33
about: Create a report to help us improve
4-
title: ''
5-
labels: ''
6-
assignees: ''
7-
4+
title: ""
5+
labels: ""
6+
assignees: ""
87
---
98

109
**Describe the bug**
1110
A clear and concise description of what the bug is.
1211

1312
**To Reproduce**
1413
Steps to reproduce the behavior:
14+
1515
1. Go to '...'
1616
2. Click on '....'
1717
3. Scroll down to '....'
@@ -20,19 +20,16 @@ Steps to reproduce the behavior:
2020
**Expected behavior**
2121
A clear and concise description of what you expected to happen.
2222

23+
**Actual behavior**
24+
A clear and concise description of what actually happened.
25+
2326
**Screenshots**
2427
If applicable, add screenshots to help explain your problem.
2528

2629
**Desktop (please complete the following information):**
27-
- OS: [e.g. iOS]
28-
- Browser [e.g. chrome, safari]
29-
- Version [e.g. 22]
30-
31-
**Smartphone (please complete the following information):**
32-
- Device: [e.g. iPhone6]
33-
- OS: [e.g. iOS8.1]
34-
- Browser [e.g. stock browser, safari]
35-
- Version [e.g. 22]
30+
31+
- OS: [e.g. iOS]
32+
- Version [e.g. 22]
3633

3734
**Additional context**
3835
Add any other context about the problem here.

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,23 @@
1-
# Describe all your changes concisely.
2-
# Use bullets to separate your changes.
1+
# Changelog
2+
3+
<!-- Add a changelog of the PR's changes, similar to the format of https://keepachangelog.com/en/1.1.0/ -->
4+
<!-- Delete sections of the changelog if unused -->
5+
6+
Added:
7+
8+
- ...
9+
10+
Modified:
11+
12+
- ...
13+
14+
Removed:
15+
16+
- ...
17+
18+
# Related issues
19+
20+
<!-- Describe the issue that this PR is related to -->
21+
22+
- Solves issue #...
23+
- Makes progress on issue #...

CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Changelog
2+
3+
Format based on [Keep a Changelog v1.1.0](https://keepachangelog.com/en/1.1.0/).
4+
This project follows [Semantic Versioning v2.0.0](https://semver.org/spec/v2.0.0.html).
5+
6+
## 1.0.0
7+
8+
### Added
9+
10+
- RubberInt class for arbitrarily-sized integer support.
11+
- RubberFloat class for arbitrarily-sized fixed-point decimal number support.

CMakeLists.txt

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,16 @@
1-
# Based on GoogleTest quickstart guide: http://google.github.io/googletest/quickstart-cmake.html
21
cmake_minimum_required(VERSION 3.14)
3-
project(my_project)
2+
project(RubberNumbers VERSION 1.0.0)
43

54
# General C++ standard config
65
# Note: GoogleTest requires at least C++14
76
set(CMAKE_CXX_STANDARD 17)
87
set(CMAKE_CXX_STANDARD_REQUIRED ON)
98

9+
# Default value for BUILD_TYPE variable
10+
if(NOT BUILD_TYPE)
11+
set(BUILD_TYPE "release")
12+
endif()
13+
1014
# Target specific config
1115
if(BUILD_TYPE STREQUAL "testing")
1216
set(CMAKE_BUILD_TYPE "Debug")
@@ -47,6 +51,7 @@ FetchContent_MakeAvailable(googletest)
4751

4852
# Compile and link if necessary
4953
if (INCLUDE_TESTS)
54+
# Based on GoogleTest quickstart guide: http://google.github.io/googletest/quickstart-cmake.html
5055
enable_testing()
5156
add_executable(rubber_numbers src/tests.cpp src/RubberNumbers/RubberIntegers.cpp)
5257

0 commit comments

Comments
 (0)