Skip to content

Commit bc3e469

Browse files
committed
Reduce diff
?
1 parent 64351d5 commit bc3e469

36 files changed

+118
-123
lines changed

mypy/test/teststubtest.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ def use_tmp_dir(mod_name: str) -> Iterator[str]:
3939

4040

4141
stubtest_typing_stub = """
42+
import collections
4243
Any = object()
4344
4445
class _SpecialForm:
@@ -2097,7 +2098,7 @@ class Y(TypedDict):
20972098
@collect_cases
20982099
def test_named_tuple(self) -> Iterator[Case]:
20992100
yield Case(
2100-
stub="from typing import NamedTuple; import collections",
2101+
stub="from typing import NamedTuple",
21012102
runtime="from typing import NamedTuple",
21022103
error=None,
21032104
)
@@ -2133,7 +2134,7 @@ class X2(NamedTuple):
21332134
@collect_cases
21342135
def test_named_tuple_typing_and_collections(self) -> Iterator[Case]:
21352136
yield Case(
2136-
stub="from typing import NamedTuple; import collections",
2137+
stub="from typing import NamedTuple",
21372138
runtime="from collections import namedtuple",
21382139
error=None,
21392140
)

test-data/unit/check-basic.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -462,7 +462,7 @@ def typeddict() -> Sequence[D]:
462462

463463
a = (a.A(), A())
464464
a.x # E: "tuple[a.A, b.A]" has no attribute "x"
465-
[builtins fixtures/tuple.pyi]
465+
[builtins fixtures/dict.pyi]
466466
[typing fixtures/typing-full.pyi]
467467

468468
[case testReturnAnyFromFunctionDeclaredToReturnObject]

test-data/unit/check-callable.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ def g(o: Thing) -> None:
491491
i + s # E: Unsupported operand types for + ("str" and "int")
492492
o(1,2,3)
493493

494-
[builtins fixtures/tuple.pyi]
494+
[builtins fixtures/callable.pyi]
495495

496496
[case testCallableNoArgs]
497497

test-data/unit/check-class-namedtuple.test

Lines changed: 15 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ i, i = l[0] # E: Need more than 1 value to unpack (2 expected)
214214
l = [A(1)]
215215
a = (1,) # E: Incompatible types in assignment (expression has type "tuple[int]", \
216216
variable has type "A")
217-
[builtins fixtures/tuple.pyi]
217+
[builtins fixtures/list.pyi]
218218

219219
[case testNewNamedTupleMissingClassAttribute]
220220
from typing import NamedTuple
@@ -259,7 +259,7 @@ class C(B): pass
259259
B(1).b
260260
C(2).b
261261

262-
[builtins fixtures/tuple.pyi]
262+
[builtins fixtures/property.pyi]
263263

264264
[case testNewNamedTupleAsDict]
265265
from typing import NamedTuple, Any
@@ -271,7 +271,7 @@ class X(NamedTuple):
271271
x: X
272272
reveal_type(x._asdict()) # N: Revealed type is "builtins.dict[builtins.str, Any]"
273273

274-
[builtins fixtures/tuple.pyi]
274+
[builtins fixtures/dict.pyi]
275275

276276
[case testNewNamedTupleReplaceTyped]
277277
from typing import NamedTuple
@@ -301,7 +301,7 @@ reveal_type(X._field_defaults) # N: Revealed type is "builtins.dict[builtins.st
301301
# but it's inferred as `Mapping[str, object]` here due to the fixture we're using
302302
reveal_type(X.__annotations__) # N: Revealed type is "typing.Mapping[builtins.str, builtins.object]"
303303

304-
[builtins fixtures/tuple.pyi]
304+
[builtins fixtures/dict-full.pyi]
305305

306306
[case testNewNamedTupleUnit]
307307
from typing import NamedTuple
@@ -326,7 +326,7 @@ class Y(NamedTuple):
326326

327327
reveal_type([X(3, 'b'), Y(1, 'a')]) # N: Revealed type is "builtins.list[tuple[builtins.int, builtins.str]]"
328328

329-
[builtins fixtures/tuple.pyi]
329+
[builtins fixtures/list.pyi]
330330

331331
[case testNewNamedTupleJoinTuple]
332332
from typing import NamedTuple
@@ -338,7 +338,7 @@ class X(NamedTuple):
338338
reveal_type([(3, 'b'), X(1, 'a')]) # N: Revealed type is "builtins.list[tuple[builtins.int, builtins.str]]"
339339
reveal_type([X(1, 'a'), (3, 'b')]) # N: Revealed type is "builtins.list[tuple[builtins.int, builtins.str]]"
340340

341-
[builtins fixtures/tuple.pyi]
341+
[builtins fixtures/list.pyi]
342342

343343
[case testNewNamedTupleWithTooManyArguments]
344344
from typing import NamedTuple
@@ -358,7 +358,7 @@ class X(typing.NamedTuple):
358358
x.x: int # E: Invalid statement in NamedTuple definition; expected "field_name: field_type [= default]"
359359
z: str = 'z'
360360
aa: int # E: Non-default NamedTuple fields cannot follow default fields
361-
[builtins fixtures/tuple.pyi]
361+
[builtins fixtures/list.pyi]
362362

363363
[case testNewNamedTupleWithoutTypesSpecified]
364364
from typing import NamedTuple
@@ -377,7 +377,7 @@ class N(NamedTuple):
377377

378378
def f(a: Type[N]):
379379
a() # E: Missing positional arguments "x", "y" in call to "N"
380-
[builtins fixtures/tuple.pyi]
380+
[builtins fixtures/list.pyi]
381381

382382
[case testNewNamedTupleWithDefaults]
383383
from typing import List, NamedTuple, Optional
@@ -416,7 +416,7 @@ reveal_type(UserDefined()) # N: Revealed type is "tuple[__main__.Default, fallb
416416
reveal_type(UserDefined(Default())) # N: Revealed type is "tuple[__main__.Default, fallback=__main__.UserDefined]"
417417
UserDefined(1) # E: Argument 1 to "UserDefined" has incompatible type "int"; expected "Default"
418418

419-
[builtins fixtures/tuple.pyi]
419+
[builtins fixtures/list.pyi]
420420

421421
[case testNewNamedTupleWithDefaultsStrictOptional]
422422
from typing import List, NamedTuple, Optional
@@ -434,7 +434,7 @@ class CannotBeNone(NamedTuple):
434434
x: int
435435
y: int = None # E: Incompatible types in assignment (expression has type "None", variable has type "int")
436436

437-
[builtins fixtures/tuple.pyi]
437+
[builtins fixtures/list.pyi]
438438

439439
[case testNewNamedTupleWrongType]
440440
from typing import NamedTuple
@@ -448,8 +448,7 @@ class X(NamedTuple):
448448
from typing import NamedTuple
449449

450450
class X(NamedTuple):
451-
x: int = 1 + '1' # E: Incompatible types in assignment (expression has type "str", variable has type "int") \
452-
# E: Unsupported operand types for + ("int" and "str")
451+
x: int = 1 + '1' # E: Unsupported left operand type for + ("int")
453452
[builtins fixtures/tuple.pyi]
454453

455454
[case testNewNamedTupleInheritance]
@@ -608,7 +607,7 @@ class ReuseCallableNamed(NamedTuple):
608607
def z(self) -> int: # E: Name "z" already defined on line 31
609608
return 0
610609

611-
[builtins fixtures/tuple.pyi]
610+
[builtins fixtures/dict.pyi]
612611

613612
[case testNewNamedTupleDocString]
614613
from typing import NamedTuple
@@ -640,7 +639,7 @@ class HasClassMethod(NamedTuple):
640639
reveal_type(HasClassMethod) # N: Revealed type is "def (x: builtins.str) -> tuple[builtins.str, fallback=__main__.HasClassMethod]"
641640
return cls(x=f)
642641

643-
[builtins fixtures/tuple.pyi]
642+
[builtins fixtures/classmethod.pyi]
644643

645644
[case testNewNamedTupleStaticMethod]
646645
from typing import NamedTuple
@@ -652,7 +651,7 @@ class HasStaticMethod(NamedTuple):
652651
def new(f: str) -> 'HasStaticMethod':
653652
return HasStaticMethod(x=f)
654653

655-
[builtins fixtures/tuple.pyi]
654+
[builtins fixtures/classmethod.pyi]
656655

657656
[case testNewNamedTupleProperty]
658657
from typing import NamedTuple
@@ -665,7 +664,7 @@ class HasStaticMethod(NamedTuple):
665664
reveal_type(self) # N: Revealed type is "tuple[builtins.str, fallback=__main__.HasStaticMethod]"
666665
return 4
667666

668-
[builtins fixtures/tuple.pyi]
667+
[builtins fixtures/property.pyi]
669668

670669
[case testTypingExtensionsNamedTuple]
671670
from typing_extensions import NamedTuple

test-data/unit/check-classes.test

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -3868,7 +3868,7 @@ from typing import Type, NamedTuple
38683868
N = NamedTuple('N', [('x', int), ('y', int)])
38693869
def f(a: Type[N]):
38703870
a()
3871-
[builtins fixtures/tuple.pyi]
3871+
[builtins fixtures/list.pyi]
38723872
[out]
38733873
main:4: error: Missing positional arguments "x", "y" in call to "N"
38743874

@@ -5346,7 +5346,7 @@ class M(NamedTuple):
53465346
n: N
53475347
m: M
53485348
lst = [n, m]
5349-
[builtins fixtures/tuple.pyi]
5349+
[builtins fixtures/isinstancelist.pyi]
53505350

53515351
[case testCorrectJoinOfSelfRecursiveTypedDicts]
53525352
from typing import TypedDict
@@ -5377,7 +5377,7 @@ def parse_ast(name_dict: NameDict) -> None:
53775377
if isinstance(name_dict[''], int):
53785378
pass
53795379
reveal_type(name_dict['test']) # N: Revealed type is "tuple[builtins.bool, fallback=__main__.NameInfo]"
5380-
[builtins fixtures/tuple.pyi]
5380+
[builtins fixtures/isinstancelist.pyi]
53815381
[typing fixtures/typing-medium.pyi]
53825382

53835383
[case testCrashInForwardRefToTypedDictWithIsinstance]
@@ -5600,7 +5600,7 @@ class B(object):
56005600
return self.a.x
56015601

56025602
reveal_type(x.x) # N: Revealed type is "builtins.int"
5603-
[builtins fixtures/tuple.pyi]
5603+
[builtins fixtures/property.pyi]
56045604
[out]
56055605

56065606
[case testCorrectIsinstanceWithForwardUnion]
@@ -5613,7 +5613,7 @@ def f(x: ForwardUnion) -> None:
56135613
reveal_type(x) # N: Revealed type is "Union[tuple[builtins.int, fallback=__main__.TP], builtins.int]"
56145614
if isinstance(x, TP):
56155615
reveal_type(x) # N: Revealed type is "tuple[builtins.int, fallback=__main__.TP]"
5616-
[builtins fixtures/tuple.pyi]
5616+
[builtins fixtures/isinstance.pyi]
56175617
[out]
56185618

56195619
[case testCrashInvalidArgsSyntheticClassSyntax]
@@ -5626,7 +5626,7 @@ class NM(NamedTuple):
56265626
# These two should never crash, reveals are in the next test
56275627
TD({'x': []})
56285628
NM(x=[])
5629-
[builtins fixtures/tuple.pyi]
5629+
[builtins fixtures/dict.pyi]
56305630
[typing fixtures/typing-typeddict.pyi]
56315631
[out]
56325632

@@ -5645,7 +5645,7 @@ reveal_type(x) # N: Revealed type is "TypedDict('__main__.TD', {'x': builtins.li
56455645
reveal_type(x1) # N: Revealed type is "TypedDict('__main__.TD', {'x': builtins.list[Any]})"
56465646
reveal_type(y) # N: Revealed type is "tuple[builtins.list[Any], fallback=__main__.NM]"
56475647
reveal_type(y1) # N: Revealed type is "tuple[builtins.list[Any], fallback=__main__.NM]"
5648-
[builtins fixtures/tuple.pyi]
5648+
[builtins fixtures/dict.pyi]
56495649
[typing fixtures/typing-typeddict.pyi]
56505650
[out]
56515651

@@ -5659,7 +5659,7 @@ NT = NewType('NT', List[int, str]) # E: "list" expects 1 type argument, but 2 gi
56595659
TD({'x': []})
56605660
NM(x=[])
56615661
NT([])
5662-
[builtins fixtures/tuple.pyi]
5662+
[builtins fixtures/dict.pyi]
56635663
[typing fixtures/typing-typeddict.pyi]
56645664
[out]
56655665

@@ -5677,7 +5677,7 @@ x: A1
56775677
y: A2
56785678
reveal_type(x.b) # N: Revealed type is "__main__.B"
56795679
reveal_type(y['b']) # N: Revealed type is "__main__.B"
5680-
[builtins fixtures/tuple.pyi]
5680+
[builtins fixtures/dict.pyi]
56815681
[typing fixtures/typing-typeddict.pyi]
56825682
[out]
56835683

@@ -5691,7 +5691,7 @@ x: A1
56915691
y: A2
56925692
reveal_type(x.b) # N: Revealed type is "__main__.B"
56935693
reveal_type(y['b']) # N: Revealed type is "__main__.B"
5694-
[builtins fixtures/tuple.pyi]
5694+
[builtins fixtures/dict.pyi]
56955695
[typing fixtures/typing-typeddict.pyi]
56965696
[out]
56975697

test-data/unit/check-custom-plugin.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ reveal_type(FullyQualifiedTestNamedTuple('')._asdict()) # N: Revealed type is "b
599599
[file mypy.ini]
600600
\[mypy]
601601
plugins=<ROOT>/test-data/unit/plugins/fully_qualified_test_hook.py
602-
[builtins fixtures/tuple.pyi]
602+
[builtins fixtures/classmethod.pyi]
603603
[typing fixtures/typing-typeddict.pyi]
604604

605605
[case testDynamicClassPlugin]

test-data/unit/check-enum.test

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2452,6 +2452,7 @@ class Foo(Enum):
24522452
# E: Incompatible types in assignment (expression has type "<typing special form>", variable has type "Foo")
24532453
Baz: Any = Callable[[Dict[str, "Missing"]], None] # E: Enum members must be left unannotated \
24542454
# N: See https://typing.readthedocs.io/en/latest/spec/enums.html#defining-members \
2455+
# E: Type application targets a non-generic function or class \
24552456
# E: Name "Missing" is not defined
24562457

24572458
reveal_type(Foo.Bar) # N: Revealed type is "Literal[__main__.Foo.Bar]?"

test-data/unit/check-expressions.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2459,7 +2459,7 @@ def f() -> int: # E: Missing return statement
24592459
from typing import TypeVar
24602460
T = TypeVar("T")
24612461
x: int
2462-
x + T # E: Unsupported operand types for + ("int" and "TypeVar")
2462+
x + T # E: Unsupported left operand type for + ("int")
24632463
T() # E: "TypeVar" not callable
24642464
[builtins fixtures/tuple.pyi]
24652465
[typing fixtures/typing-full.pyi]

test-data/unit/check-flags.test

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1024,7 +1024,7 @@ from missing import Unchecked
10241024

10251025
Point = NamedTuple('Point', [('x', List[Unchecked]),
10261026
('y', Unchecked)])
1027-
[builtins fixtures/tuple.pyi]
1027+
[builtins fixtures/list.pyi]
10281028
[out]
10291029
main:5: error: NamedTuple type becomes "tuple[list[Any], Any]" due to an unfollowed import
10301030

@@ -1315,7 +1315,7 @@ Point = NamedTuple('Point', [('x', int), ('y', int)]) # no error
13151315

13161316
def origin() -> Point:
13171317
return Point(x=0, y=0)
1318-
[builtins fixtures/tuple.pyi]
1318+
[builtins fixtures/list.pyi]
13191319

13201320
[case testDisallowAnyExprNewType]
13211321
# flags: --disallow-any-expr
@@ -1908,7 +1908,7 @@ z = cast(List[Any], x) # E: Explicit "Any" is not allowed [explicit-any]
19081908
from typing import Any, List, NamedTuple
19091909

19101910
Point = NamedTuple('Point', [('x', List[Any]), ('y', Any)]) # E: Explicit "Any" is not allowed [explicit-any]
1911-
[builtins fixtures/tuple.pyi]
1911+
[builtins fixtures/list.pyi]
19121912

19131913
[case testDisallowAnyExplicitTypeVarConstraint]
19141914
# flags: --disallow-any-explicit --show-error-codes

test-data/unit/check-inference.test

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3442,7 +3442,7 @@ x = t and d[t]
34423442
reveal_type(x) # N: Revealed type is "Union[None, builtins.bytes]"
34433443
if x:
34443444
reveal_type(x) # N: Revealed type is "builtins.bytes"
3445-
[builtins fixtures/tuple.pyi]
3445+
[builtins fixtures/dict.pyi]
34463446

34473447
[case testRegression11705_NoStrict]
34483448
# flags: --no-strict-optional
@@ -3457,7 +3457,7 @@ x = t and d[t]
34573457
reveal_type(x) # N: Revealed type is "builtins.bytes"
34583458
if x:
34593459
reveal_type(x) # N: Revealed type is "builtins.bytes"
3460-
[builtins fixtures/tuple.pyi]
3460+
[builtins fixtures/dict.pyi]
34613461

34623462
[case testSuggestPep604AnnotationForPartialNone]
34633463
# flags: --local-partial-types --python-version 3.10

0 commit comments

Comments
 (0)