Skip to content

Commit 7eb4045

Browse files
committed
pin versions to fix node tests
1 parent 9a45ae9 commit 7eb4045

File tree

4 files changed

+54
-10
lines changed

4 files changed

+54
-10
lines changed

test/fastboot-build-test.js

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,23 @@ describe('it builds with ember-cli-fastboot', function () {
1616
app = new AddonTestApp();
1717

1818
return app
19-
.create('dummy', { skipNpm: true })
19+
.create('dummy', {
20+
skipNpm: true,
21+
emberVersion: '^3.28.10',
22+
emberDataVersion: '^3.28.9',
23+
})
2024
.then((app) =>
2125
app.editPackageJSON((pkg) => {
26+
pkg.devDependencies['isbinaryfile'] = '5.0.0';
27+
pkg.devDependencies['ember-resolver'] = '^8.1.0';
2228
pkg.devDependencies['ember-cli-fastboot'] = '*';
2329
})
2430
)
25-
.then(() => app.run('npm', 'install'));
31+
.then(() => app.run('npm', 'install'))
32+
.catch((e) => {
33+
//eslint-disable-next-line no-console
34+
console.error(e);
35+
});
2636
});
2737

2838
it('builds into dist/ember-fetch/fetch-fastboot.js', function () {

test/fastboot-fetch-test.js

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,21 @@ describe('renders in fastboot build', function () {
1616
app = new AddonTestApp();
1717

1818
return app
19-
.create('dummy', { skipNpm: true })
19+
.create('dummy', {
20+
skipNpm: true,
21+
emberVersion: '^3.28.10',
22+
emberDataVersion: '^3.28.9',
23+
})
2024
.then((app) =>
2125
app.editPackageJSON((pkg) => {
26+
pkg.devDependencies['isbinaryfile'] = '5.0.0';
27+
pkg.devDependencies['ember-resolver'] = '^8.1.0';
2228
pkg.devDependencies['ember-cli-fastboot'] = '*';
2329
// [email protected] has ember-fetch as dependency, we want to test
24-
pkg.devDependencies['ember-fetch-adapter'] = '0.4.0';
30+
pkg.devDependencies['ember-fetch-adapter'] = '0.4.3';
2531
// These 2 are in ember-fetch's package.json, symlinking to dummy won't help resolve
2632
pkg.devDependencies['abortcontroller-polyfill'] = '*';
27-
pkg.devDependencies['node-fetch'] = '*';
33+
pkg.devDependencies['node-fetch'] = '^2.6.7';
2834
})
2935
)
3036
.then(function () {
@@ -34,6 +40,10 @@ describe('renders in fastboot build', function () {
3440
return app.startServer({
3541
command: 'serve',
3642
});
43+
})
44+
.catch((e) => {
45+
//eslint-disable-next-line no-console
46+
console.error(e);
3747
});
3848
});
3949

test/fastboot-test.js

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,15 +16,23 @@ describe('renders in fastboot build without calling fetch', function () {
1616
app = new AddonTestApp();
1717

1818
return app
19-
.create('fresh', { skipNpm: true, noFixtures: true })
19+
.create('fresh', {
20+
skipNpm: true,
21+
noFixtures: true,
22+
emberVersion: '^3.28.10',
23+
emberDataVersion: '^3.28.9',
24+
})
2025
.then((app) =>
2126
app.editPackageJSON((pkg) => {
27+
pkg.devDependencies['isbinaryfile'] = '5.0.0';
28+
pkg.devDependencies['ember-resolver'] = '^8.1.0';
2229
pkg.devDependencies['ember-cli-fastboot'] = '*';
2330
// [email protected] has ember-fetch as dependency, we want to test
24-
pkg.devDependencies['ember-fetch-adapter'] = '0.4.0';
31+
pkg.devDependencies['ember-fetch-adapter'] = '0.4.3';
2532
// These 2 are in ember-fetch's package.json, symlinking to dummy won't help resolve
2633
pkg.devDependencies['abortcontroller-polyfill'] = '*';
27-
pkg.devDependencies['node-fetch'] = '*';
34+
pkg.devDependencies['node-fetch'] = '^2.6.7';
35+
delete pkg.devDependencies.dummy;
2836
})
2937
)
3038
.then(function () {
@@ -34,6 +42,10 @@ describe('renders in fastboot build without calling fetch', function () {
3442
return app.startServer({
3543
command: 'serve',
3644
});
45+
})
46+
.catch((e) => {
47+
//eslint-disable-next-line no-console
48+
console.error(e);
3749
});
3850
});
3951

test/without-fastboot-build-test.js

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,15 @@ describe('it builds without ember-cli-fastboot', function () {
1616

1717
it('builds no exist dist/ember-fetch/fetch-fastboot.js', function () {
1818
return app
19-
.create('dummy', { skipNpm: true })
19+
.create('dummy', {
20+
skipNpm: true,
21+
emberVersion: '^3.28.10',
22+
emberDataVersion: '^3.28.9',
23+
})
2024
.then((app) =>
2125
app.editPackageJSON((pkg) => {
26+
pkg.devDependencies['isbinaryfile'] = '5.0.0';
27+
pkg.devDependencies['ember-resolver'] = '^8.1.0';
2228
delete pkg.devDependencies['ember-cli-fastboot'];
2329
})
2430
)
@@ -36,6 +42,8 @@ describe('it builds without ember-cli-fastboot', function () {
3642
.create('dummy', { skipNpm: true })
3743
.then((app) =>
3844
app.editPackageJSON((pkg) => {
45+
pkg.devDependencies['ember-source'] = '^3.28.10';
46+
pkg.devDependencies['isbinaryfile'] = '5.0.0';
3947
pkg.devDependencies['ember-cli-fastboot'] = '*';
4048
})
4149
)
@@ -52,6 +60,10 @@ describe('it builds without ember-cli-fastboot', function () {
5260
function () {
5361
delete process.env.FASTBOOT_DISABLED;
5462
}
55-
);
63+
)
64+
.catch((e) => {
65+
//eslint-disable-next-line no-console
66+
console.error(e);
67+
});
5668
});
5769
});

0 commit comments

Comments
 (0)