Merge branch 'array-paginator-out-of-bounds' into 4.0-fixed

Author: Eric GELOEN

src/State/Pagination/ArrayPaginator.php

@@ -27,14 +27,15 @@ final class ArrayPaginator implements \IteratorAggregate, PaginatorInterface, Ha
 
     public function __construct(array $results, int $firstResult, int $maxResults)
     {
-        if ($maxResults > 0) {
+        $this->firstResult = $firstResult;
+        $this->maxResults = $maxResults;
+        $this->totalItems = \count($results);
+
+        if ($maxResults > 0 && $firstResult < $this->totalItems) {
             $this->iterator = new \LimitIterator(new \ArrayIterator($results), $firstResult, $maxResults);
         } else {
             $this->iterator = new \EmptyIterator();
         }
-        $this->firstResult = $firstResult;
-        $this->maxResults = $maxResults;
-        $this->totalItems = \count($results);
     }
 
     /**

tests/State/Pagination/ArrayPaginatorTest.php

@@ -41,6 +41,7 @@ public static function initializeProvider(): array
             'Second of two pages of 3 items for the first page and 2 for the second' => [[0, 1, 2, 3, 4], 3, 3, 2, 5, 2, 2, false],
             'Empty results' => [[], 0, 2, 0, 0, 1, 1, false],
             '0 for max results' => [[0, 1, 2, 3], 2, 0, 0, 4, 1, 1, false],
+            'First result greater than total items' => [[0, 1], 2, 1, 0, 2, 3, 2, false],
         ];
     }
 }