Skip to content

Commit 6dd637a

Browse files
authored
Only list json files as missions (zeusops#24)
1 parent e5f08a1 commit 6dd637a

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/zeusops_bot/reforger_config_gen.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ def list_missions(self) -> list[str]:
105105
Returns:
106106
List of mission names available in the folder
107107
"""
108-
entries = self.target_dest.iterdir()
108+
entries = self.target_dest.glob("*.json")
109109
ignored_names = [SYMLINK_FILENAME, "config.json"]
110110
mission_names = [
111111
entry.stem

tests/test_list_missions.py

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,19 +10,15 @@
1010

1111
import pytest
1212

13-
from zeusops_bot.reforger_config_gen import ReforgerConfigGenerator, as_config_file
13+
from zeusops_bot.reforger_config_gen import ReforgerConfigGenerator
1414

1515

1616
@pytest.mark.parametrize(
1717
("filenames", "mission_names"),
1818
[
1919
(["mission1.json", "mission2.json"], ["mission1", "mission2"]),
2020
([], []),
21-
pytest.param(
22-
["mission1.json", "mission2.json", ".gitignore"],
23-
["mission1", "mission2"],
24-
marks=pytest.mark.xfail(reason="GH#11"),
25-
),
21+
(["mission1.json", "mission2.json", ".gitignore"], ["mission1", "mission2"]),
2622
],
2723
ids=["two missions", "empty", "non-json extra"],
2824
)
@@ -35,7 +31,7 @@ def test_list_missions(
3531
"""Scenario: List uploaded missions"""
3632
# Given files "mission1.json" and "mission2.json" exist in the mission directory
3733
for filename in filenames:
38-
as_config_file(mission_dir, filename).touch()
34+
(mission_dir / filename).touch()
3935
config_gen = ReforgerConfigGenerator(
4036
base_config_file=base_config, target_folder=mission_dir
4137
)

0 commit comments

Comments
 (0)