Skip to content

Commit 32c192c

Browse files
author
Jeroen de Graaf
committed
Improve service defaults: set in services.yaml instead
1 parent 9abcc8c commit 32c192c

File tree

2 files changed

+23
-16
lines changed

2 files changed

+23
-16
lines changed

config/services.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ services:
3737
- '@gember.rdbms_event_store_doctrine_dbal.table_schema.event_store_relation_table_schema'
3838
- '@gember.rdbms_event_store_doctrine_dbal.doctrine_dbal_rdbms_event_factory'
3939

40-
gember.doctrine.dbal.connection: ~
40+
gember.doctrine.dbal.connection: '@doctrine.dbal.default_connection'
4141

4242
gember.rdbms_event_store_doctrine_dbal.table_schema.event_store_table_schema:
4343
class: Gember\RdbmsEventStoreDoctrineDbal\TableSchema\EventStoreTableSchema
@@ -193,7 +193,7 @@ services:
193193
arguments:
194194
- '@gember.symfony.component.messenger.message_bus.event_bus'
195195

196-
gember.symfony.component.messenger.message_bus.event_bus: ~
196+
gember.symfony.component.messenger.message_bus.event_bus: '@event.bus'
197197

198198
gember.event_sourcing.util.serialization.serializer.serializer:
199199
class: Gember\EventSourcing\Util\Serialization\Serializer\Stacked\StackedSerializer
@@ -211,7 +211,7 @@ services:
211211
arguments:
212212
- '@gember.symfony.component.serializer.serializer_interface'
213213

214-
gember.symfony.component.serializer.serializer_interface: ~
214+
gember.symfony.component.serializer.serializer_interface: '@serializer'
215215

216216
gember.event_sourcing.util.string.friendly_class_namer.friendly_class_namer:
217217
class: Gember\EventSourcing\Util\String\FriendlyClassNamer\Native\NativeFriendlyClassNamer

src/GemberEventSourcingBundle.php

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,8 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
9191
$services = $container->services();
9292

9393
if ($config['cache']['enabled'] ?? false) {
94-
$services->get('gember.event_sourcing.registry.cached.cached_event_registry_decorator') ->decorate('gember.event_sourcing.registry.event_registry');
94+
$services->get('gember.event_sourcing.registry.cached.cached_event_registry_decorator')
95+
->decorate('gember.event_sourcing.registry.event_registry');
9596

9697
$services->get('gember.event_sourcing.util.resolver.cached.cached_attribute_resolver_decorator')
9798
->decorate('gember.event_sourcing.util.attribute.resolver.attribute_resolver');
@@ -118,15 +119,19 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
118119
$services->get('gember.event_sourcing.registry.event_registry')
119120
->arg('$path', $config['registry']['event_registry']['reflector']['path'] ?? '%kernel.project_dir%/src');
120121

121-
$services->alias(
122-
'gember.symfony.component.messenger.message_bus.event_bus',
123-
ltrim($config['message_bus']['symfony']['event_bus'] ?? 'event.bus', '@'),
124-
);
122+
if (!empty($config['message_bus']['symfony']['event_bus'] ?? null)) {
123+
$services->alias(
124+
'gember.symfony.component.messenger.message_bus.event_bus',
125+
ltrim($config['message_bus']['symfony']['event_bus'], '@'),
126+
);
127+
}
125128

126-
$services->alias(
127-
'gember.doctrine.dbal.connection',
128-
ltrim($config['event_store']['rdbms']['doctrine_dbal']['connection'] ?? 'Doctrine\DBAL\Connection', '@'),
129-
);
129+
if (!empty($config['event_store']['rdbms']['doctrine_dbal']['connection'] ?? null)) {
130+
$services->alias(
131+
'gember.doctrine.dbal.connection',
132+
ltrim($config['event_store']['rdbms']['doctrine_dbal']['connection'], '@'),
133+
);
134+
}
130135

131136
if (!empty($config['generator']['identity']['service'] ?? null)) {
132137
$services->alias(
@@ -135,9 +140,11 @@ public function loadExtension(array $config, ContainerConfigurator $container, C
135140
);
136141
}
137142

138-
$services->alias(
139-
'gember.symfony.component.serializer.serializer_interface',
140-
ltrim($config['serializer']['symfony']['serializer'] ?? 'Symfony\Component\Serializer\SerializerInterface', '@'),
141-
);
143+
if (!empty($config['serializer']['symfony']['serializer'] ?? null)) {
144+
$services->alias(
145+
'gember.symfony.component.serializer.serializer_interface',
146+
ltrim($config['serializer']['symfony']['serializer'], '@'),
147+
);
148+
}
142149
}
143150
}

0 commit comments

Comments
 (0)