We no longer have hash collisions, so we can normalize edge cases

Author: Genbox

Src/FastData.Generator.CPlusPlus.Tests/Verify/ArrayStructure_Int64_5.verified.txt

@@ -9,14 +9,14 @@
 class ArrayStructure_Int64_5 final
 {
     static constexpr std::array<int64_t, 5> entries = {
-        std::numeric_limits<int64_t>::lowest(), -5ll, 0ll, 1ll, 9223372036854775806ll
+        std::numeric_limits<int64_t>::lowest(), -1ll, 0ll, 1ll, std::numeric_limits<int64_t>::max()
     };
 
 public:
     [[nodiscard]]
     static bool contains(const int64_t value) noexcept
     {
-        if (value < std::numeric_limits<int64_t>::lowest() || value > 9223372036854775806ll)
+        if (value < std::numeric_limits<int64_t>::lowest() || value > std::numeric_limits<int64_t>::max())
             return false;
 
         for (size_t i = 0; i < 5; i++)
@@ -29,7 +29,7 @@ public:
 
     static constexpr size_t item_count = 5;
     static constexpr int64_t min_value = std::numeric_limits<int64_t>::lowest();
-    static constexpr int64_t max_value = 9223372036854775806ll;
+    static constexpr int64_t max_value = std::numeric_limits<int64_t>::max();
 
 public:
     ArrayStructure_Int64_5() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/ArrayStructure_UInt64_4.verified.txt

@@ -9,14 +9,14 @@
 class ArrayStructure_UInt64_4 final
 {
     static constexpr std::array<uint64_t, 4> entries = {
-        0, 1ull, 2ull, 18446744073709551605ull
+        0, 1ull, 2ull, std::numeric_limits<uint64_t>::max()
     };
 
 public:
     [[nodiscard]]
     static bool contains(const uint64_t value) noexcept
     {
-        if (value < 0 || value > 18446744073709551605ull)
+        if (value < 0 || value > std::numeric_limits<uint64_t>::max())
             return false;
 
         for (size_t i = 0; i < 4; i++)
@@ -29,7 +29,7 @@ public:
 
     static constexpr size_t item_count = 4;
     static constexpr uint64_t min_value = 0;
-    static constexpr uint64_t max_value = 18446744073709551605ull;
+    static constexpr uint64_t max_value = std::numeric_limits<uint64_t>::max();
 
 public:
     ArrayStructure_UInt64_4() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/BinarySearchStructure_Int64_5.verified.txt

@@ -9,14 +9,14 @@
 class BinarySearchStructure_Int64_5 final
 {
     static constexpr std::array<int64_t, 5> entries = {
-        std::numeric_limits<int64_t>::lowest(), -5ll, 0ll, 1ll, 9223372036854775806ll
+        std::numeric_limits<int64_t>::lowest(), -1ll, 0ll, 1ll, std::numeric_limits<int64_t>::max()
     };
 
 public:
     [[nodiscard]]
     static bool contains(const int64_t value) noexcept
     {
-        if (value < std::numeric_limits<int64_t>::lowest() || value > 9223372036854775806ll)
+        if (value < std::numeric_limits<int64_t>::lowest() || value > std::numeric_limits<int64_t>::max())
             return false;
 
         size_t lo = 0;
@@ -39,7 +39,7 @@ public:
 
     static constexpr size_t item_count = 5;
     static constexpr int64_t min_value = std::numeric_limits<int64_t>::lowest();
-    static constexpr int64_t max_value = 9223372036854775806ll;
+    static constexpr int64_t max_value = std::numeric_limits<int64_t>::max();
 
 public:
     BinarySearchStructure_Int64_5() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/BinarySearchStructure_UInt64_4.verified.txt

@@ -9,14 +9,14 @@
 class BinarySearchStructure_UInt64_4 final
 {
     static constexpr std::array<uint64_t, 4> entries = {
-        0, 1ull, 2ull, 18446744073709551605ull
+        0, 1ull, 2ull, std::numeric_limits<uint64_t>::max()
     };
 
 public:
     [[nodiscard]]
     static bool contains(const uint64_t value) noexcept
     {
-        if (value < 0 || value > 18446744073709551605ull)
+        if (value < 0 || value > std::numeric_limits<uint64_t>::max())
             return false;
 
         size_t lo = 0;
@@ -39,7 +39,7 @@ public:
 
     static constexpr size_t item_count = 4;
     static constexpr uint64_t min_value = 0;
-    static constexpr uint64_t max_value = 18446744073709551605ull;
+    static constexpr uint64_t max_value = std::numeric_limits<uint64_t>::max();
 
 public:
     BinarySearchStructure_UInt64_4() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/ConditionalStructure_Int64_5.verified.txt

@@ -12,18 +12,18 @@ public:
     [[nodiscard]]
     static bool contains(const int64_t value) noexcept
     {
-        if (value < std::numeric_limits<int64_t>::lowest() || value > 9223372036854775806ll)
+        if (value < std::numeric_limits<int64_t>::lowest() || value > std::numeric_limits<int64_t>::max())
             return false;
 
-        if (value == std::numeric_limits<int64_t>::lowest() || value == -5ll || value == 0ll || value == 1ll || value == 9223372036854775806ll)
+        if (value == std::numeric_limits<int64_t>::lowest() || value == -1ll || value == 0ll || value == 1ll || value == std::numeric_limits<int64_t>::max())
             return true;
 
         return false;
     }
 
     static constexpr size_t item_count = 5;
     static constexpr int64_t min_value = std::numeric_limits<int64_t>::lowest();
-    static constexpr int64_t max_value = 9223372036854775806ll;
+    static constexpr int64_t max_value = std::numeric_limits<int64_t>::max();
 
 public:
     ConditionalStructure_Int64_5() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/ConditionalStructure_UInt64_4.verified.txt

@@ -12,18 +12,18 @@ public:
     [[nodiscard]]
     static bool contains(const uint64_t value) noexcept
     {
-        if (value < 0 || value > 18446744073709551605ull)
+        if (value < 0 || value > std::numeric_limits<uint64_t>::max())
             return false;
 
-        if (value == 0 || value == 1ull || value == 2ull || value == 18446744073709551605ull)
+        if (value == 0 || value == 1ull || value == 2ull || value == std::numeric_limits<uint64_t>::max())
             return true;
 
         return false;
     }
 
     static constexpr size_t item_count = 4;
     static constexpr uint64_t min_value = 0;
-    static constexpr uint64_t max_value = 18446744073709551605ull;
+    static constexpr uint64_t max_value = std::numeric_limits<uint64_t>::max();
 
 public:
     ConditionalStructure_UInt64_4() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/EytzingerSearchStructure_Int64_5.verified.txt

@@ -9,14 +9,14 @@
 class EytzingerSearchStructure_Int64_5 final
 {
     static constexpr std::array<int64_t, 5> entries = {
-        1ll, -5ll, 9223372036854775806ll, std::numeric_limits<int64_t>::lowest(), 0ll
+        1ll, -1ll, std::numeric_limits<int64_t>::max(), std::numeric_limits<int64_t>::lowest(), 0ll
     };
 
 public:
     [[nodiscard]]
     static bool contains(const int64_t value) noexcept
     {
-        if (value < std::numeric_limits<int64_t>::lowest() || value > 9223372036854775806ll)
+        if (value < std::numeric_limits<int64_t>::lowest() || value > std::numeric_limits<int64_t>::max())
             return false;
 
         size_t i = 0;
@@ -36,7 +36,7 @@ public:
 
     static constexpr size_t item_count = 5;
     static constexpr int64_t min_value = std::numeric_limits<int64_t>::lowest();
-    static constexpr int64_t max_value = 9223372036854775806ll;
+    static constexpr int64_t max_value = std::numeric_limits<int64_t>::max();
 
 public:
     EytzingerSearchStructure_Int64_5() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/EytzingerSearchStructure_UInt64_4.verified.txt

@@ -9,14 +9,14 @@
 class EytzingerSearchStructure_UInt64_4 final
 {
     static constexpr std::array<uint64_t, 4> entries = {
-        2ull, 1ull, 18446744073709551605ull, 0
+        2ull, 1ull, std::numeric_limits<uint64_t>::max(), 0
     };
 
 public:
     [[nodiscard]]
     static bool contains(const uint64_t value) noexcept
     {
-        if (value < 0 || value > 18446744073709551605ull)
+        if (value < 0 || value > std::numeric_limits<uint64_t>::max())
             return false;
 
         size_t i = 0;
@@ -36,7 +36,7 @@ public:
 
     static constexpr size_t item_count = 4;
     static constexpr uint64_t min_value = 0;
-    static constexpr uint64_t max_value = 18446744073709551605ull;
+    static constexpr uint64_t max_value = std::numeric_limits<uint64_t>::max();
 
 public:
     EytzingerSearchStructure_UInt64_4() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/HashSetChainStructure_Int64_5.verified.txt

@@ -19,11 +19,11 @@ class HashSetChainStructure_Int64_5 final
     };
 
     static constexpr std::array<int8_t, 5> buckets = {
-        3, 5, 0, 1, 0
+        3, 4, 5, 1, 0
      };
 
     inline static const std::array<e, 5> entries = {
-        e(-1, std::numeric_limits<int64_t>::lowest()), e(-1, -5ll), e(-1, 0ll), e(1, 1ll), e(3, 9223372036854775806ll)
+        e(-1, std::numeric_limits<int64_t>::lowest()), e(-1, -1ll), e(1, 0ll), e(-1, 1ll), e(-1, std::numeric_limits<int64_t>::max())
     };
 
     static uint64_t get_hash(const int64_t value) noexcept
@@ -35,7 +35,7 @@ public:
     [[nodiscard]]
     static bool contains(const int64_t value) noexcept
     {
-        if (value < std::numeric_limits<int64_t>::lowest() || value > 9223372036854775806ll)
+        if (value < std::numeric_limits<int64_t>::lowest() || value > std::numeric_limits<int64_t>::max())
             return false;
 
         const uint64_t hash = get_hash(value);
@@ -57,7 +57,7 @@ public:
 
     static constexpr size_t item_count = 5;
     static constexpr int64_t min_value = std::numeric_limits<int64_t>::lowest();
-    static constexpr int64_t max_value = 9223372036854775806ll;
+    static constexpr int64_t max_value = std::numeric_limits<int64_t>::max();
 
 public:
     HashSetChainStructure_Int64_5() = delete;

Src/FastData.Generator.CPlusPlus.Tests/Verify/HashSetChainStructure_UInt64_4.verified.txt

@@ -19,11 +19,11 @@ class HashSetChainStructure_UInt64_4 final
     };
 
     static constexpr std::array<int8_t, 4> buckets = {
-        1, 4, 3, 0
+        1, 2, 3, 4
      };
 
     inline static const std::array<e, 4> entries = {
-        e(-1, 0), e(-1, 1ull), e(-1, 2ull), e(1, 18446744073709551605ull)
+        e(-1, 0), e(-1, 1ull), e(-1, 2ull), e(-1, std::numeric_limits<uint64_t>::max())
     };
 
     static uint64_t get_hash(const uint64_t value) noexcept
@@ -35,7 +35,7 @@ public:
     [[nodiscard]]
     static bool contains(const uint64_t value) noexcept
     {
-        if (value < 0 || value > 18446744073709551605ull)
+        if (value < 0 || value > std::numeric_limits<uint64_t>::max())
             return false;
 
         const uint64_t hash = get_hash(value);
@@ -57,7 +57,7 @@ public:
 
     static constexpr size_t item_count = 4;
     static constexpr uint64_t min_value = 0;
-    static constexpr uint64_t max_value = 18446744073709551605ull;
+    static constexpr uint64_t max_value = std::numeric_limits<uint64_t>::max();
 
 public:
     HashSetChainStructure_UInt64_4() = delete;