Remove notnull constraints

Author: Genbox

Src/FastData.Generator.CPlusPlus.Tests/VectorTests.cs

@@ -17,7 +17,7 @@ public class VectorTests(VectorTests.CPlusPlusContext context) : IClassFixture<V
 {
     [Theory]
     [ClassData(typeof(TestVectorTheoryData))]
-    public async Task Test<T>(TestVector<T> data) where T : notnull
+    public async Task Test<T>(TestVector<T> data)
     {
         GeneratorSpec spec = Generate(id => CPlusPlusCodeGenerator.Create(new CPlusPlusCodeGeneratorConfig(id)), data);
         Assert.NotEmpty(spec.Source);

Src/FastData.Generator.CSharp.Tests/VectorTests.cs

@@ -16,7 +16,7 @@ public class VectorTests
 {
     [Theory]
     [ClassData(typeof(TestVectorTheoryData))]
-    public async Task Test<T>(TestVector<T> data) where T : notnull
+    public async Task Test<T>(TestVector<T> data)
     {
         GeneratorSpec spec = Generate(id => CSharpCodeGenerator.Create(new CSharpCodeGeneratorConfig(id)), data);
         Assert.NotEmpty(spec.Source);

Src/FastData.Generator.Rust.Tests/VectorTests.cs

@@ -17,7 +17,7 @@ public class VectorTests(VectorTests.RustContext context) : IClassFixture<Vector
 {
     [Theory]
     [ClassData(typeof(TestVectorTheoryData))]
-    public async Task Test<T>(TestVector<T> data) where T : notnull
+    public async Task Test<T>(TestVector<T> data)
     {
         GeneratorSpec spec = Generate(id => RustCodeGenerator.Create(new RustCodeGeneratorConfig(id)), data);
         Assert.NotEmpty(spec.Source);

Src/FastData.Generator/Framework/CodeGenerator.cs

@@ -15,7 +15,7 @@ public abstract class CodeGenerator(ILanguageDef langDef, IConstantsDef constDef
 
     public GeneratorEncoding Encoding => langDef.Encoding;
 
-    public virtual string Generate<T>(ReadOnlySpan<T> data, GeneratorConfig<T> genCfg, IContext<T> context) where T : notnull
+    public virtual string Generate<T>(ReadOnlySpan<T> data, GeneratorConfig<T> genCfg, IContext<T> context)
     {
         Shared.Clear();
 
@@ -38,9 +38,9 @@ public virtual string Generate<T>(ReadOnlySpan<T> data, GeneratorConfig<T> genCf
         return sb.ToString();
     }
 
-    protected abstract OutputWriter<T>? GetOutputWriter<T>(GeneratorConfig<T> genCfg, IContext<T> context) where T : notnull;
+    protected abstract OutputWriter<T>? GetOutputWriter<T>(GeneratorConfig<T> genCfg, IContext<T> context);
 
-    protected virtual void AppendHeader<T>(StringBuilder sb, GeneratorConfig<T> genCfg, IContext<T> context) where T : notnull
+    protected virtual void AppendHeader<T>(StringBuilder sb, GeneratorConfig<T> genCfg, IContext<T> context)
     {
         string subType = context.GetType().Name.Replace("Context`1", "");
 
@@ -53,7 +53,7 @@ protected virtual void AppendHeader<T>(StringBuilder sb, GeneratorConfig<T> genC
 #endif
     }
 
-    protected virtual void AppendBody<T>(StringBuilder sb, GeneratorConfig<T> genCfg, string typeName, IContext<T> context, ReadOnlySpan<T> data) where T : notnull
+    protected virtual void AppendBody<T>(StringBuilder sb, GeneratorConfig<T> genCfg, string typeName, IContext<T> context, ReadOnlySpan<T> data)
     {
         OutputWriter<T>? writer = GetOutputWriter(genCfg, context);
 

Src/FastData.Generator/Framework/Definitions/IntegerTypeDef.cs

@@ -3,7 +3,7 @@
 
 namespace Genbox.FastData.Generator.Framework.Definitions;
 
-public class IntegerTypeDef<T>(string name, T minValue, T maxValue, string minValueStr, string maxValueStr, Func<T, string>? print = null) : ITypeDef<T> where T : notnull
+public class IntegerTypeDef<T>(string name, T minValue, T maxValue, string minValueStr, string maxValueStr, Func<T, string>? print = null) : ITypeDef<T>
 {
     public DataType DataType => (DataType)Type.GetTypeCode(typeof(T));
     public string Name { get; } = name;

Src/FastData.Generator/Framework/OutputWriter.cs

@@ -8,7 +8,7 @@
 
 namespace Genbox.FastData.Generator.Framework;
 
-public abstract class OutputWriter<T> : IOutputWriter<T> where T : notnull
+public abstract class OutputWriter<T> : IOutputWriter<T>
 {
     private IEarlyExitDef _earlyExitDef = null!;
     private ILanguageDef _langDef = null!;

Src/FastData.InternalShared/DummyGenerator.cs

@@ -9,7 +9,7 @@ namespace Genbox.FastData.InternalShared;
 {
     public GeneratorEncoding Encoding => GeneratorEncoding.Unknown;
 
-    public string Generate<T>(ReadOnlySpan<T> data, GeneratorConfig<T> genCfg, IContext<T> context) where T : notnull
+    public string Generate<T>(ReadOnlySpan<T> data, GeneratorConfig<T> genCfg, IContext<T> context)
     {
         Combined<T> combined = new Combined<T>(data.ToArray(), context);
         return JsonConvert.SerializeObject(combined, new JsonSerializerSettings { Formatting = Formatting.Indented });

Src/FastData.InternalShared/Helpers/TestHelper.cs

@@ -95,7 +95,7 @@ public static bool TryWriteFile(string path, string content)
     }
 
     /// <summary>This variant of Generate bypasses the public API to test more advanced combinations of parameters</summary>
-    public static GeneratorSpec Generate<T>(Func<string, ICodeGenerator> func, TestVector<T> vector) where T : notnull
+    public static GeneratorSpec Generate<T>(Func<string, ICodeGenerator> func, TestVector<T> vector)
     {
         DataType dataType = Enum.Parse<DataType>(typeof(T).Name);
 
@@ -131,7 +131,7 @@ public static GeneratorSpec Generate<T>(Func<string, ICodeGenerator> func, TestV
         throw new InvalidOperationException("Unsupported structure type: " + vector.Type.Name);
     }
 
-    private static HashData GetHashData<T>(TestVector<T> vector, DataType dataType, GeneratorEncoding genEnc) where T : notnull
+    private static HashData GetHashData<T>(TestVector<T> vector, DataType dataType, GeneratorEncoding genEnc)
     {
         HashData hashData;
 
@@ -152,7 +152,7 @@ private static HashData GetHashData<T>(TestVector<T> vector, DataType dataType,
         return hashData;
     }
 
-    private static GeneratorSpec Generate<T, TContext>(ICodeGenerator generator, TestVector<T> vector, IProperties props, DataType dataType, StructureType structureType, IStructure<T, TContext> structure) where T : notnull where TContext : IContext<T>
+    private static GeneratorSpec Generate<T, TContext>(ICodeGenerator generator, TestVector<T> vector, IProperties props, DataType dataType, StructureType structureType, IStructure<T, TContext> structure) where TContext : IContext<T>
     {
         ReadOnlySpan<T> values = vector.Values.AsReadOnlySpan();
         TContext context = structure.Create(ref values);

Src/FastData.InternalShared/TestClasses/TestData.cs

@@ -7,7 +7,7 @@
 
 namespace Genbox.FastData.InternalShared.TestClasses;
 
-public class TestData<T>(StructureType structureType, T[] values) : ITestData, IXunitSerializable where T : notnull
+public class TestData<T>(StructureType structureType, T[] values) : ITestData, IXunitSerializable
 {
     private readonly DataType _dataType = Enum.Parse<DataType>(typeof(T).Name);
     private readonly Random _rng = new Random(42);

Src/FastData/FastDataGenerator.cs

@@ -66,7 +66,7 @@ public static string Generate(object[] data, FastDataConfig fdCfg, ICodeGenerato
     /// <param name="factory">A logging factory</param>
     /// <returns>The generated source code.</returns>
     /// <exception cref="InvalidOperationException">Thrown when you gave an unsupported data type in data.</exception>
-    public static string Generate<T>(T[] data, FastDataConfig fdCfg, ICodeGenerator generator, ILoggerFactory? factory = null) where T : notnull
+    public static string Generate<T>(T[] data, FastDataConfig fdCfg, ICodeGenerator generator, ILoggerFactory? factory = null)
     {
         if (typeof(T) == typeof(string))
             return GenerateString(new ReadOnlySpan<string>((string[])(object)data), fdCfg, generator, factory);
@@ -81,7 +81,7 @@ public static string Generate<T>(T[] data, FastDataConfig fdCfg, ICodeGenerator
     /// <param name="factory">A logging factory</param>
     /// <returns>The generated source code.</returns>
     /// <exception cref="InvalidOperationException">Thrown when you gave an unsupported data type in data.</exception>
-    public static string Generate<T>(ReadOnlySpan<T> data, FastDataConfig fdCfg, ICodeGenerator generator, ILoggerFactory? factory = null) where T : notnull
+    public static string Generate<T>(ReadOnlySpan<T> data, FastDataConfig fdCfg, ICodeGenerator generator, ILoggerFactory? factory = null)
     {
         if (data.Length == 0)
             throw new InvalidOperationException("No data provided. Please provide at least one item to generate code for.");
@@ -243,13 +243,13 @@ private static string GenerateString(ReadOnlySpan<string> data, FastDataConfig f
         }
     }
 
-    private static string Generate<T, TContext>(ICodeGenerator generator, GeneratorConfig<T> genCfg, IStructure<T, TContext> structure, ReadOnlySpan<T> data) where T : notnull where TContext : IContext<T>
+    private static string Generate<T, TContext>(ICodeGenerator generator, GeneratorConfig<T> genCfg, IStructure<T, TContext> structure, ReadOnlySpan<T> data) where TContext : IContext<T>
     {
         TContext res = structure.Create(ref data);
         return generator.Generate(data, genCfg, res);
     }
 
-    private static ReadOnlySpan<T> Cast<T>(this ReadOnlySpan<object> data) where T : notnull
+    private static ReadOnlySpan<T> Cast<T>(this ReadOnlySpan<object> data)
     {
         T[] newArr = new T[data.Length];