More cleanup

Author: Genbox

Src/FastData.Benchmarks/Benchmarks/AnalyzerBenchmarks.cs

@@ -2,7 +2,6 @@
 using Genbox.FastData.Internal.Analysis;
 using Genbox.FastData.Internal.Analysis.Analyzers;
 using Genbox.FastData.Internal.Analysis.Properties;
-using Genbox.FastData.InternalShared;
 using Genbox.FastData.InternalShared.Helpers;
 using Microsoft.Extensions.Logging.Abstractions;
 
@@ -17,7 +16,7 @@ public AnalyzerBenchmarks()
     {
         Random rng = new Random(42);
 
-        string[] data = Enumerable.Range(1, 100).Select(x => TestHelper.GenerateRandomString(rng, 50)).ToArray();
+        string[] data = Enumerable.Range(1, 100).Select(_ => TestHelper.GenerateRandomString(rng, 50)).ToArray();
         StringProperties props = DataAnalyzer.GetStringProperties(data);
 
         _analyzer = new GPerfAnalyzer(data, props, new GPerfAnalyzerConfig(), new Simulator(data, new SimulatorConfig()), NullLogger<GPerfAnalyzer>.Instance);

Src/FastData.Benchmarks/Benchmarks/DogsBenchmark.cs

@@ -29,9 +29,5 @@ public static bool Contains(string value)
                 _ => false
             };
         }
-
-        public const int ItemCount = 3;
-        public const int MinLength = 8;
-        public const int MaxLength = 16;
     }
 }

Src/FastData.Benchmarks/Benchmarks/HashBenchmarks.cs

@@ -10,7 +10,7 @@ namespace Genbox.FastData.Benchmarks.Benchmarks;
 [Orderer(SummaryOrderPolicy.FastestToSlowest)]
 public class HashBenchmarks
 {
-    private string[] _array;
+    private string[] _array = null!;
 
     [Params(1_000, 10_000, 100_000, 1_000_000)]
     public int Size { get; set; }

Src/FastData.Benchmarks/Benchmarks/PerfectHashBenchmarks.cs

@@ -7,7 +7,7 @@ namespace Genbox.FastData.Benchmarks.Benchmarks;
 [Orderer(SummaryOrderPolicy.FastestToSlowest)]
 public class PerfectHashBenchmarks
 {
-    private static ulong[] _hashCodes;
+    private static ulong[] _hashCodes = null!;
 
     [GlobalSetup]
     public void Setup()
@@ -27,7 +27,7 @@ public void Setup()
             "Wine", "Wood", "Word", "Work", "Year"
         ];
 
-        _hashCodes = words.Select(x => (ulong)x.GetHashCode()).ToArray();
+        _hashCodes = words.Select(x => (ulong)x.GetHashCode(StringComparison.Ordinal)).ToArray();
     }
 
     [Benchmark]

Src/FastData.Benchmarks/Benchmarks/SegmentGeneratorsBenchmarks.cs

@@ -1,7 +1,6 @@
 using Genbox.FastData.Internal.Analysis;
 using Genbox.FastData.Internal.Analysis.Properties;
 using Genbox.FastData.Internal.Analysis.SegmentGenerators;
-using Genbox.FastData.InternalShared;
 using Genbox.FastData.InternalShared.Helpers;
 
 namespace Genbox.FastData.Benchmarks.Benchmarks;

Src/FastData.Benchmarks/Benchmarks/StringVsByteArrayVsInteger.cs

@@ -1,7 +1,6 @@
 using System.Runtime.CompilerServices;
 using System.Text;
 using BenchmarkDotNet.Order;
-using Genbox.FastData.InternalShared;
 using Genbox.FastData.InternalShared.Helpers;
 
 namespace Genbox.FastData.Benchmarks.Benchmarks;

Src/FastData.Generator.CPlusPlus.Shared/CPlusPlusCompiler.cs

@@ -60,16 +60,14 @@ private bool HasMSVC()
         if (!File.Exists(vsWherePath))
             return false;
 
-        using Process process = new Process
+        using Process process = new Process();
+        process.StartInfo = new ProcessStartInfo
         {
-            StartInfo = new ProcessStartInfo
-            {
-                FileName = vsWherePath,
-                Arguments = "-latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property productPath",
-                UseShellExecute = false,
-                RedirectStandardOutput = true,
-                CreateNoWindow = true
-            }
+            FileName = vsWherePath,
+            Arguments = "-latest -products * -requires Microsoft.VisualStudio.Component.VC.Tools.x86.x64 -property productPath",
+            UseShellExecute = false,
+            RedirectStandardOutput = true,
+            CreateNoWindow = true
         };
 
         process.Start();
@@ -80,7 +78,7 @@ private bool HasMSVC()
             return false;
 
         //productPath points to LaunchDevCmd.bat which is not what we want. We want VsDevCmd.bat in the same folder
-        _path = Path.Combine(Path.GetDirectoryName(productPath), "VsDevCmd.bat");
+        _path = Path.Combine(Path.GetDirectoryName(productPath)!, "VsDevCmd.bat");
         return true;
     }
 

Src/FastData.Generator.CPlusPlus.Tests/ExpressionCompilerTests.cs

@@ -3,7 +3,6 @@
 using Genbox.FastData.Generator.CPlusPlus.Internal.Framework;
 using Genbox.FastData.Generator.Framework;
 using Genbox.FastData.InternalShared;
-using Genbox.FastData.InternalShared.TestClasses;
 using Genbox.FastData.InternalShared.TestClasses.TheoryData;
 
 namespace Genbox.FastData.Generator.CPlusPlus.Tests;

Src/FastData.Generator.CPlusPlus.Tests/Properties/ModuleInitializer.cs

@@ -3,7 +3,7 @@
 
 namespace Genbox.FastData.Generator.CPlusPlus.Tests.Properties;
 
-public static class ModuleInitializer
+internal static class ModuleInitializer
 {
     [ModuleInitializer]
     public static void Initialize() => VerifyDiffPlex.Initialize(OutputType.Compact);

Src/FastData.Generator.CPlusPlus.Tests/VectorTests.cs

@@ -46,6 +46,8 @@ int main(int argc, char* argv[])
     }
 
     [SuppressMessage("Design", "CA1034:Nested types should not be visible")]
+    [SuppressMessage("Maintainability", "CA1515:Consider making public types internal")]
+    [SuppressMessage("ReSharper", "ClassNeverInstantiated.Global")]
     public sealed class CPlusPlusContext
     {
         public CPlusPlusContext()