Fix a bug where HttpClientFactory named instances didn't work

Fixes #67

Author: Genbox

Src/SimpleS3.Core.Tests/OfflineTests/BugTests.cs

@@ -0,0 +1,23 @@
+using Genbox.SimpleS3.GenericS3.Extensions;
+using Microsoft.Extensions.DependencyInjection;
+
+namespace Genbox.SimpleS3.Core.Tests.OfflineTests;
+
+public class BugTests
+{
+    [Fact]
+    public void GitHubIssue67()
+    {
+        // https://github.com/Genbox/SimpleS3/issues/67
+        // This tests if using the DI system interferes with existing HttpClients
+        ServiceCollection collection = new ServiceCollection();
+        collection.AddHttpClient();
+        collection.AddGenericS3();
+
+        using ServiceProvider provider = collection.BuildServiceProvider();
+        IEnumerable<HttpClient> clients = provider.GetServices<HttpClient>();
+        HttpClient client = Assert.Single(clients); //We should only have the HttpClient we added ourselves. SimpleS3 should only register HttpActions for a named HttpClientFactory.
+
+        Assert.Empty(client.DefaultRequestHeaders); //SimpleS3 sets a few headers. They must not be present on the user's HttpClient.
+    }
+}

Src/SimpleS3.Core.Tests/SimpleS3.Core.Tests.csproj

@@ -1,3 +1,5 @@
 <Project Sdk="Microsoft.NET.Sdk">
-
+  <ItemGroup>
+    <ProjectReference Include="..\SimpleS3.GenericS3\SimpleS3.GenericS3.csproj" />
+  </ItemGroup>
 </Project>

Src/SimpleS3.Core/Extensions/SimpleS3CoreServices.cs

@@ -38,7 +38,8 @@ public static class SimpleS3CoreServices
     /// </summary>
     /// <param name="collection">The service collection</param>
     /// <param name="configure">Use this to configure the configuration used by SimpleS3</param>
-    public static ICoreBuilder AddSimpleS3Core(IServiceCollection collection, Action<SimpleS3Config>? configure = null)
+    /// <param name="name">The name to use for the builder. Used for named dependency isolation.</param>
+    public static ICoreBuilder AddSimpleS3Core(IServiceCollection collection, Action<SimpleS3Config>? configure = null, string name = "SimpleS3")
     {
         //We don't use the microsoft extension here as we only want a subset of services.
 
@@ -102,8 +103,7 @@ public static ICoreBuilder AddSimpleS3Core(IServiceCollection collection, Action
         collection.TryAddEnumerable(RegisterAsActual(typeof(IValidator<>), assembly)); //We register IValidator twice to support IValidator<T> as well
         collection.TryAddEnumerable(RegisterAsActual(typeof(IValidateOptions<>), assembly)); //Make sure that the options system validators are added too
 
-        //NOTE: I have not given the user a chance to set the name (named configs) here yet. It will eventually be used for config isolation between instances.
-        return new CoreBuilder(collection);
+        return new CoreBuilder(collection, name);
     }
 
     /// <summary>Register services as the interface type given</summary>