Improve tracing control and cleanup in GeneralTracer

Added an _isTracingEnabled flag to allow enabling/disabling tracing and exposed IsTracingEnabled() for status checks. Removed unnecessary locking in file listener initialization and WriteTraceMessage, streamlining log file rotation and message writing. Cleaned up comments in WindowsOutputDebugListener for clarity.

Author: JusterZhu

src/c#/GeneralUpdate.Common/Internal/Trace/GeneralTracer.cs

@@ -7,7 +7,8 @@ namespace GeneralUpdate.Common.Internal;
 
 public static class GeneralTracer
 {
-    private static readonly object _lockObj = new object();
+    private static readonly object _lockObj = new();
+    private static bool _isTracingEnabled;
     private static string _currentLogDate;
     private static TextWriterTraceListener _fileListener;
 
@@ -28,34 +29,32 @@ static GeneralTracer()
             Trace.Listeners.Add(new DefaultTraceListener());
 
         Trace.AutoFlush = true;
+        _isTracingEnabled = true;
     }
 
     private static void InitializeFileListener()
     {
         //Ensure that log files are rotated on a daily basis
-        lock (_lockObj)
-        {
-            var today = DateTime.Now.ToString("yyyy-MM-dd");
-            if (today == _currentLogDate && _fileListener != null)
-                return;
+        var today = DateTime.Now.ToString("yyyy-MM-dd");
+        if (today == _currentLogDate && _fileListener != null)
+            return;
 
-            if (_fileListener != null)
-            {
-                Trace.Listeners.Remove(_fileListener);
-                _fileListener.Flush();
-                _fileListener.Close();
-                _fileListener.Dispose();
-            }
+        if (_fileListener != null)
+        {
+            Trace.Listeners.Remove(_fileListener);
+            _fileListener.Flush();
+            _fileListener.Close();
+            _fileListener.Dispose();
+        }
 
-            var logDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Logs");
-            Directory.CreateDirectory(logDir);
+        var logDir = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, "Logs");
+        Directory.CreateDirectory(logDir);
 
-            var logFileName = Path.Combine(logDir, $"generalupdate-trace {today}.log");
-            _fileListener = new TextWriterTraceListener(logFileName) { Name = "FileListener" };
+        var logFileName = Path.Combine(logDir, $"generalupdate-trace {today}.log");
+        _fileListener = new TextWriterTraceListener(logFileName) { Name = "FileListener" };
 
-            Trace.Listeners.Add(_fileListener);
-            _currentLogDate = today;
-        }
+        Trace.Listeners.Add(_fileListener);
+        _currentLogDate = today;
     }
 
     public static void Debug(string message) => WriteTraceMessage(TraceLevel.Verbose, message);
@@ -85,15 +84,27 @@ public static void SetTracingEnabled(bool enabled)
         lock (_lockObj)
         {
             Trace.AutoFlush = enabled;
+            _isTracingEnabled = enabled;
             foreach (TraceListener listener in Trace.Listeners)
             {
                 listener.Filter = enabled ? null : new EventTypeFilter(SourceLevels.Off);
             }
         }
     }
 
+    public static bool IsTracingEnabled()
+    {
+        lock (_lockObj)
+        {
+            return _isTracingEnabled;
+        }
+    }
+
     private static void WriteTraceMessage(TraceLevel level, string message)
     {
+        if(!IsTracingEnabled())
+            return;
+        
         InitializeFileListener();
         var timestamp = DateTime.Now.ToString("yyyy-MM-dd HH:mm:ss.fff");
         var levelName = GetLevelName(level);
@@ -114,10 +125,7 @@ private static void WriteTraceMessage(TraceLevel level, string message)
             fullMessage = $"[{timestamp}] [{levelName}] : {message}";
         }
 
-        lock (_lockObj)
-        {
-            Trace.WriteLine(fullMessage);
-        }
+        Trace.WriteLine(fullMessage);
     }
 
     private static string GetLevelName(TraceLevel level) => level switch

src/c#/GeneralUpdate.Common/Internal/Trace/WindowsOutputDebugListener.cs

@@ -6,11 +6,9 @@ namespace GeneralUpdate.Common.Internal;
 
 public class WindowsOutputDebugListener : TraceListener
 {
-    // 声明Win32 API的OutputDebugString函数
     [DllImport("kernel32.dll", CharSet = CharSet.Auto)]
     private static extern void OutputDebugString(string lpOutputString);
 
-    // 重写Write方法（处理无换行的输出）
     public override void Write(string message)
     {
         if (!string.IsNullOrEmpty(message))
@@ -19,10 +17,8 @@ public override void Write(string message)
         }
     }
 
-    // 重写WriteLine方法（处理带换行的输出）
     public override void WriteLine(string message)
     {
-        // 附加换行符，保持与Trace.WriteLine一致的行为
         Write($"{message}{Environment.NewLine}");
     }
 }