remove email field from user entity and update tests to assert email absence in various scenarios

Author: ae2079

src/entities/user.ts

@@ -37,7 +37,6 @@ export const publicSelectionFields = [
   'user.passportScore',
   'user.passportStamps',
   'user.acceptedToS',
-  'user.email',
   'user.qaccPoints',
   'user.username',
 ];

src/repositories/userRepository.test.ts

@@ -335,7 +335,7 @@ function findUserByWalletAddressTestCases() {
     );
     assert.isOk(foundUser);
     assert.equal(foundUser?.walletAddress, user.walletAddress);
-    assert.isOk(foundUser?.email);
+    assert.isNotOk(foundUser?.email);
   });
 
   it('Should find user by walletAddress with all fields', async () => {

src/resolvers/donationResolver.test.ts

@@ -751,7 +751,7 @@ function donationsTestCases() {
     assert.isOk(donations.find(d => Number(d.id) === oldDonation.id));
     assert.notOk(donations.find(d => Number(d.id) === newDonation.id));
     donations.forEach(donation => {
-      assert.isOk(donation.user.email);
+      assert.isNotOk(donation.user.email);
       assert.isOk(donation.user.firstName);
       assert.isOk(donation.user.walletAddress);
     });
@@ -2927,7 +2927,7 @@ function donationsFromWalletsTestCases() {
     // assert.isNotEmpty(result.data.data.donationsFromWallets);
     result.data.data.donationsFromWallets.forEach(item => {
       assert.equal(item.fromWalletAddress, walletAddress);
-      assert.isOk(item.user.email);
+      assert.isNotOk(item.user.email);
       assert.isOk(item.user.walletAddress);
     });
   });
@@ -2953,7 +2953,7 @@ function donationsFromWalletsTestCases() {
 
     result.data.data.donationsFromWallets.forEach(item => {
       assert.equal(item.fromWalletAddress, walletAddress);
-      assert.isOk(item.user.email);
+      assert.isNotOk(item.user.email);
       assert.isOk(item.user.walletAddress);
     });
   });
@@ -2991,7 +2991,7 @@ function donationsFromWalletsTestCases() {
         item.fromWalletAddress.toLowerCase(),
         walletAddress.toLowerCase(),
       );
-      assert.isOk(item.user.email);
+      assert.isNotOk(item.user.email);
       assert.isOk(item.user.walletAddress);
     });
   });
@@ -3193,7 +3193,7 @@ function donationsByProjectIdTestCases() {
     const donations = result.data.data.donationsByProjectId.donations;
     assert.equal(Number(donations[0].id), DONATION_SEED_DATA.FIFTH_DONATION.id);
     donations.forEach(donation => {
-      assert.isOk(donation.user.email);
+      assert.isNotOk(donation.user.email);
       assert.isOk(donation.user.firstName);
       assert.isOk(donation.user.walletAddress);
     });
@@ -4363,7 +4363,7 @@ function donationsByDonorTestCases() {
       SEED_DATA.FIRST_USER.walletAddress,
     );
     firstUserResult.data.data.donationsByDonor.forEach(donation => {
-      assert.isOk(donation.user.email);
+      assert.isNotOk(donation.user.email);
       assert.isOk(donation.user.firstName);
       assert.isOk(donation.user.walletAddress);
     });
@@ -4416,7 +4416,7 @@ function donationsToWalletsTestCases() {
     // assert.isNotEmpty(result.data.data.donationsToWallets);
     result.data.data.donationsToWallets.forEach(item => {
       assert.equal(item.toWalletAddress, project.walletAddress);
-      assert.isOk(item.user.email);
+      assert.isNotOk(item.user.email);
       assert.isOk(item.user.walletAddress);
     });
   });

src/resolvers/projectResolver.test.ts

@@ -622,7 +622,7 @@ function projectsByUserIdTestCases() {
       assert.isOk(project.adminUser.walletAddress);
       assert.isOk(project.adminUser.firstName);
       assert.isNull(project.projectVerificationForm);
-      assert.isOk(project.adminUser.email);
+      assert.isNotOk(project.adminUser.email);
     });
   });
 
@@ -641,7 +641,7 @@ function projectsByUserIdTestCases() {
     projects.forEach(project => {
       assert.isOk(project.adminUser.walletAddress);
       assert.isOk(project.adminUser.firstName);
-      assert.isOk(project.adminUser.email);
+      assert.isNotOk(project.adminUser.email);
     });
   });
 }
@@ -660,7 +660,7 @@ function projectByIdTestCases() {
     assert.isNotEmpty(result.data.data.projectById.addresses);
     assert.isOk(result.data.data.projectById.adminUser.walletAddress);
     assert.isOk(result.data.data.projectById.adminUser.firstName);
-    assert.isOk(result.data.data.projectById.adminUser.email);
+    assert.isNotOk(result.data.data.projectById.adminUser.email);
     assert.isOk(result.data.data.projectById.categories[0].mainCategory.title);
   });
   it('should return error for invalid id', async () => {
@@ -690,7 +690,7 @@ function projectByIdTestCases() {
     assert.equal(result.data.data.projectById.id, project.id);
     assert.isOk(result.data.data.projectById.adminUser.walletAddress);
     assert.isOk(result.data.data.projectById.adminUser.firstName);
-    assert.isOk(result.data.data.projectById.adminUser.email);
+    assert.isNotOk(result.data.data.projectById.adminUser.email);
     assert.isNotOk(result.data.data.projectById.reaction);
   });
   it('should not return reaction when user didnt like the project', async () => {
@@ -708,7 +708,7 @@ function projectByIdTestCases() {
     assert.isNotOk(result.data.data.projectById.reaction);
     assert.isOk(result.data.data.projectById.adminUser.walletAddress);
     assert.isOk(result.data.data.projectById.adminUser.firstName);
-    assert.isOk(result.data.data.projectById.adminUser.email);
+    assert.isNotOk(result.data.data.projectById.adminUser.email);
   });
   it('should not return drafted projects if not logged in', async () => {
     const draftedProject = await saveProjectDirectlyToDb({
@@ -760,7 +760,7 @@ function projectByIdTestCases() {
     assert.equal(Number(project.id), draftedProject.id);
     assert.isOk(project.adminUser.walletAddress);
     assert.isOk(project.adminUser.firstName);
-    assert.isOk(project.adminUser.email);
+    assert.isNotOk(project.adminUser.email);
   });
   it('should not return drafted project is user is logged in but is not owner of project', async () => {
     const accessToken = await generateTestAccessToken(SEED_DATA.SECOND_USER.id);
@@ -844,7 +844,7 @@ function projectByIdTestCases() {
     assert.equal(Number(project.id), cancelledProject.id);
     assert.isOk(project.adminUser.walletAddress);
     assert.isOk(project.adminUser.firstName);
-    assert.isOk(project.adminUser.email);
+    assert.isNotOk(project.adminUser.email);
   });
   it('should not return cancelled project is user is logged in but is not owner of project', async () => {
     const accessToken = await generateTestAccessToken(SEED_DATA.SECOND_USER.id);
@@ -959,7 +959,7 @@ function projectBySlugTestCases() {
     assert.equal(Number(project.id), project1.id);
     assert.isOk(project.adminUser.walletAddress);
     assert.isOk(project.adminUser.firstName);
-    assert.isOk(project.adminUser.email);
+    assert.isNotOk(project.adminUser.email);
     assert.isOk(project.categories[0].mainCategory.title);
   });
 
@@ -996,7 +996,7 @@ function projectBySlugTestCases() {
     assert.equal(Number(project.id), Number(_project.id));
     assert.isOk(project.adminUser.walletAddress);
     assert.isOk(project.adminUser.firstName);
-    assert.isOk(project.adminUser.email);
+    assert.isNotOk(project.adminUser.email);
     assert.isNotEmpty(project.addresses);
     assert.equal(project.addresses[0].address, walletAddress);
     assert.equal(project.addresses[0].chainType, ChainType.EVM);

src/resolvers/userResolver.test.ts

@@ -167,7 +167,7 @@ function userByAddressTestCases() {
     assert.equal(result.data.data.userByAddress.firstName, userData.firstName);
     assert.equal(result.data.data.userByAddress.lastName, userData.lastName);
     assert.isNotOk(result.data.data.userByAddress.role);
-    assert.equal(result.data.data.userByAddress.email, userData.email);
+    assert.isNotOk(result.data.data.userByAddress.email);
     assert.equal(result.data.data.userByAddress.url, userData.url);
   });
   it('Get all fields of a user', async () => {