Merge pull request #43 from GeneralMagicio/check-type

added check and validations using class-transformer

Author: RamRamez

package.json

@@ -29,6 +29,7 @@
     "@nestjs/platform-express": "^11.0.1",
     "@prisma/client": "^6.5.0",
     "@worldcoin/minikit-js": "^1.8.0",
+    "class-transformer": "^0.5.1",
     "class-validator": "^0.14.1",
     "cookie-parser": "^1.4.7",
     "crypto": "^1.0.1",
@@ -47,6 +48,7 @@
     "@nestjs/testing": "^11.0.1",
     "@swc/cli": "^0.6.0",
     "@swc/core": "^1.10.7",
+    "@types/cookie-parser": "^1.4.8",
     "@types/express": "^5.0.0",
     "@types/jest": "^29.5.14",
     "@types/node": "^22.10.7",

src/main.ts

@@ -1,9 +1,16 @@
 import { NestFactory } from '@nestjs/core';
 import { AppModule } from './app.module';
-import * as cookieParser from 'cookie-parser';
+import cookieParser from 'cookie-parser';
+import { ValidationPipe } from '@nestjs/common';
 
 async function bootstrap() {
   const app = await NestFactory.create(AppModule);
+
+  app.useGlobalPipes(
+    new ValidationPipe({
+      transform: true,
+    }),
+  );
   app.use(cookieParser());
 
   await app.listen(process.env.PORT ?? 3000);

src/poll/Poll.dto.ts

@@ -1,3 +1,4 @@
+import { Transform, Type } from 'class-transformer';
 import {
   IsArray,
   IsBoolean,
@@ -16,8 +17,8 @@ export class CreatePollDto {
   title: string;
 
   @IsString()
-  @IsOptional()
-  description?: string;
+  @IsNotEmpty()
+  description: string;
 
   @IsArray()
   @IsString({ each: true })
@@ -34,8 +35,8 @@ export class CreatePollDto {
 
   @IsArray()
   @IsString({ each: true })
-  @IsOptional()
-  tags?: string[];
+  @IsNotEmpty()
+  tags: string[];
 
   @IsBoolean()
   @IsOptional()
@@ -55,14 +56,17 @@ export class GetPollsDto {
 
   @IsOptional()
   @IsBoolean()
+  @Transform(({ value }) => value === 'true')
   isActive?: boolean;
 
   @IsOptional()
   @IsBoolean()
+  @Transform(({ value }) => value === 'true')
   userVoted?: boolean;
 
   @IsOptional()
   @IsBoolean()
+  @Transform(({ value }) => value === 'true')
   userCreated?: boolean;
 
   @IsOptional()

src/poll/poll.controller.ts

@@ -8,6 +8,8 @@ import {
   Query,
   Res,
   Delete,
+  UsePipes,
+  ValidationPipe,
 } from '@nestjs/common';
 import { Response } from 'express';
 import { PollService } from './poll.service';
@@ -18,12 +20,14 @@ export class PollController {
   constructor(private readonly pollService: PollService) {}
 
   @Post()
+  @UsePipes(ValidationPipe)
   create(@Body() createPollDto: CreatePollDto) {
     const userId = 1; // need to implement Auth
     return this.pollService.createPoll(userId, createPollDto);
   }
 
   @Get()
+  @UsePipes(ValidationPipe)
   getPolls(@Req() req, @Query() query: GetPollsDto) {
     const userId = 1;
     return this.pollService.getPolls(userId, query);

src/poll/poll.service.ts

@@ -78,17 +78,17 @@ export class PollService {
     const skip = (page - 1) * limit;
     const now = new Date();
     const filters: any = {};
-    if (isActive === true) {
+    if (isActive) {
       filters.startDate = { lte: now };
       filters.endDate = { gt: now };
     }
-    if (userCreated === true) {
+    if (userCreated) {
       filters.authorUserId = userId;
     }
 
     // Get polls user voted in
     let votedPollIds: number[] = [];
-    if (userVoted === true) {
+    if (userVoted) {
       const userVotes = await this.databaseService.vote.findMany({
         where: { userId },
         select: { pollId: true },

tsconfig.json

@@ -6,6 +6,7 @@
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "allowSyntheticDefaultImports": true,
+    "esModuleInterop": true,
     "target": "ES2021",
     "sourceMap": true,
     "outDir": "./dist",

yarn.lock

@@ -1491,6 +1491,11 @@
   dependencies:
     "@types/node" "*"
 
+"@types/cookie-parser@^1.4.8":
+  version "1.4.8"
+  resolved "https://registry.yarnpkg.com/@types/cookie-parser/-/cookie-parser-1.4.8.tgz#d2215e7915f624fbfe4233da8f063f511679f1f3"
+  integrity sha512-l37JqFrOJ9yQfRQkljb41l0xVphc7kg5JTjjr+pLRZ0IyZ49V4BQ8vbF4Ut2C2e+WH4al3xD3ZwYwIUfnbT4NQ==
+
 "@types/cookiejar@^2.1.5":
   version "2.1.5"
   resolved "https://registry.yarnpkg.com/@types/cookiejar/-/cookiejar-2.1.5.tgz#14a3e83fa641beb169a2dd8422d91c3c345a9a78"
@@ -2515,6 +2520,11 @@ cjs-module-lexer@^1.0.0:
   resolved "https://registry.yarnpkg.com/cjs-module-lexer/-/cjs-module-lexer-1.4.3.tgz#0f79731eb8cfe1ec72acd4066efac9d61991b00d"
   integrity sha512-9z8TZaGM1pfswYeXrUpzPrkx8UnWYdhJclsiYMm6x/w5+nN+8Tf/LnAgfLGQCm59qAOxU8WwHEq2vNwF6i4j+Q==
 
+class-transformer@^0.5.1:
+  version "0.5.1"
+  resolved "https://registry.yarnpkg.com/class-transformer/-/class-transformer-0.5.1.tgz#24147d5dffd2a6cea930a3250a677addf96ab336"
+  integrity sha512-SQa1Ws6hUbfC98vKGxZH3KFY0Y1lm5Zm0SY8XX9zbK7FJCyVEac3ATW0RIpwzW+oOfmHE5PMPufDG9hCfoEOMw==
+
 class-validator@^0.14.1:
   version "0.14.1"
   resolved "https://registry.yarnpkg.com/class-validator/-/class-validator-0.14.1.tgz#ff2411ed8134e9d76acfeb14872884448be98110"