refactor poll controller

Author: RamRamez

src/auth/auth.controller.ts

@@ -1,4 +1,12 @@
-import { Body, Controller, Get, Post, Req, Res } from '@nestjs/common';
+import {
+  BadRequestException,
+  Body,
+  Controller,
+  Get,
+  Post,
+  Req,
+  Res,
+} from '@nestjs/common';
 import { MiniAppWalletAuthSuccessPayload } from '@worldcoin/minikit-js';
 import { Request, Response } from 'express';
 import { AuthService } from './auth.service';
@@ -33,28 +41,20 @@ export class AuthController {
       maxAge: 2 * 60 * 1000, //2 minutes
     });
 
-    return res.json({ nonce });
+    return { nonce };
   }
 
   @Post('verifyPayload')
   async verifyPayload(
     @Req() req: RequestWithCookies,
     @Body() body: IRequestPayload,
-    @Res() res: Response,
   ) {
     const { payload } = body;
     const storedNonce = req.cookies.siwe;
     if (!storedNonce) {
-      return res.status(400).json({
-        status: 'error',
-        isValid: false,
-        message: 'No nonce found in cookies',
-      });
+      throw new BadRequestException('No nonce found in cookies');
     }
-    const validMessage = await this.authService.verifyPayload(
-      payload,
-      storedNonce,
-    );
-    return res.status(200).json({ isValid: validMessage });
+    const isValid = await this.authService.verifyPayload(payload, storedNonce);
+    return { isValid };
   }
 }

src/poll/poll.controller.ts

@@ -6,10 +6,7 @@ import {
   Param,
   Post,
   Query,
-  Req,
-  Res,
 } from '@nestjs/common';
-import { Response } from 'express';
 import { CreatePollDto, DeletePollDto, GetPollsDto } from './Poll.dto';
 import { PollService } from './poll.service';
 
@@ -23,28 +20,18 @@ export class PollController {
   }
 
   @Get()
-  async getPolls(
-    @Req() req,
-    @Query() query: GetPollsDto,
-    @Res() res: Response,
-  ) {
-    const polls = await this.pollService.getPolls(query);
-    return res.status(200).json(polls);
+  async getPolls(@Query() query: GetPollsDto) {
+    return await this.pollService.getPolls(query);
   }
 
   @Get(':id')
-  async getPollDetails(@Param('id') id: number, @Res() res: Response) {
-    const poll = await this.pollService.getPollDetails(Number(id));
-    return res.status(200).json(poll);
+  async getPollDetails(@Param('id') id: number) {
+    return await this.pollService.getPollDetails(Number(id));
   }
 
   @Delete(':id')
-  async deletePoll(
-    @Param('id') id: number,
-    @Body() query: DeletePollDto,
-    @Res() res: Response,
-  ) {
+  async deletePoll(@Param('id') id: number, @Body() query: DeletePollDto) {
     const poll = await this.pollService.deletePoll(Number(id), query);
-    return res.status(200).json({ message: 'Poll deleted', poll: poll });
+    return { message: 'Poll deleted', poll };
   }
 }