Skip to content

Commit 165a8c3

Browse files
authored
Remove grdimage, legend and plot3d xfail markers (#1794)
1 parent 4e24291 commit 165a8c3

File tree

3 files changed

+0
-26
lines changed

3 files changed

+0
-26
lines changed

pygmt/tests/test_grdimage.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -77,11 +77,6 @@ def test_grdimage_slice(grid):
7777

7878

7979
@pytest.mark.mpl_image_compare
80-
@pytest.mark.xfail(
81-
condition=gmt_version > Version("6.3.0"),
82-
reason="Grid extension bug affects baseline image; "
83-
"fixed in https://github.com/GenericMappingTools/gmt/pull/6175.",
84-
)
8580
def test_grdimage_file():
8681
"""
8782
Plot an image using file input.

pygmt/tests/test_legend.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,6 @@
1212

1313

1414
@pytest.mark.mpl_image_compare
15-
@pytest.mark.xfail(
16-
condition=gmt_version > Version("6.3.0"),
17-
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
18-
)
1915
def test_legend_position():
2016
"""
2117
Test that plots a position with each of the four legend coordinate systems.
@@ -31,10 +27,6 @@ def test_legend_position():
3127

3228

3329
@pytest.mark.mpl_image_compare
34-
@pytest.mark.xfail(
35-
condition=gmt_version > Version("6.3.0"),
36-
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
37-
)
3830
def test_legend_default_position():
3931
"""
4032
Test using the default legend position.
@@ -51,10 +43,6 @@ def test_legend_default_position():
5143

5244

5345
@pytest.mark.mpl_image_compare
54-
@pytest.mark.xfail(
55-
condition=gmt_version > Version("6.3.0"),
56-
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
57-
)
5846
def test_legend_entries():
5947
"""
6048
Test different marker types/shapes.
@@ -76,10 +64,6 @@ def test_legend_entries():
7664

7765

7866
@pytest.mark.mpl_image_compare
79-
@pytest.mark.xfail(
80-
condition=gmt_version > Version("6.3.0"),
81-
reason="Defaults updated in https://github.com/GenericMappingTools/gmt/pull/6165",
82-
)
8367
def test_legend_specfile():
8468
"""
8569
Test specfile functionality.

pygmt/tests/test_plot3d.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
Tests plot3d.
33
"""
44
import os
5-
import sys
65

76
import numpy as np
87
import pytest
@@ -334,10 +333,6 @@ def test_plot3d_matrix(data, region, color):
334333
return fig
335334

336335

337-
@pytest.mark.xfail(
338-
condition=sys.platform == "win32",
339-
reason="Wrong plot generated on Windows due to incorrect -i parameter parsing",
340-
)
341336
@pytest.mark.mpl_image_compare
342337
def test_plot3d_matrix_color(data, region):
343338
"""

0 commit comments

Comments
 (0)